An error occurred fetching the project authors.
  1. 07 Oct, 2017 1 commit
    • Jacopo's avatar
      Replaces `tag: true` into `:tag` in the specs · 0ce67858
      Jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
      0ce67858
  2. 29 Aug, 2017 1 commit
  3. 21 Aug, 2017 1 commit
  4. 27 Jul, 2017 1 commit
  5. 04 Jul, 2017 1 commit
  6. 29 Jun, 2017 1 commit
  7. 19 Jun, 2017 2 commits
  8. 14 Jun, 2017 1 commit
  9. 17 May, 2017 1 commit
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      ac382b56
  10. 09 Apr, 2017 1 commit
    • Douglas Lovell's avatar
      Add a name field to the group edit form · d0beb755
      Douglas Lovell authored
      Enables user specification of group name vs. name inferred from group path.
      
      Cause new group form to copy name from path
      
      Adds some new page-specific javascript that copies entry from the
      group path field to the group name field when the group name field
      is initially empty.
      
      Remove duplicate group name entry field on group edit form
      
      This corrects the duplicated name entry field and tests that the
      JavaScript does not update the group name field if the user
      edits the group path.  (Editing the group path is not recommended
      in any case, but it is possible.)
      
      Address eslint errors in group.js
      
      Enable group name copy with dispatch and explore group creation
      
      The dispatch and explore group creation forms require the group.js
      asset, and their tests now require testing against poltergeist
      
      Update workflow new group instruction
      
      Update the gitlab basics group creation document
      
      Add a change log entry
      
      Remove unused variable for eslint
      d0beb755
  11. 06 Apr, 2017 1 commit
  12. 05 Apr, 2017 1 commit
  13. 30 Mar, 2017 1 commit
  14. 28 Mar, 2017 1 commit
  15. 06 Mar, 2017 3 commits
    • Eric Eastwood's avatar
      Use native unicode emojis · e6fc0207
      Eric Eastwood authored
       - gl_emoji for falling back to image/css-sprite when the browser
         doesn't support an emoji
       - Markdown rendering (Banzai filter)
       - Autocomplete
       - Award emoji menu
          - Perceived perf
          - Immediate response because we now build client-side
       - Update `digests.json` generation in gemojione rake task to be more
         useful and  include `unicodeVersion`
      
      MR: !9437
      
      See issues
      
       - #26371
       - #27250
       - #22474
      e6fc0207
    • Z.J. van de Weg's avatar
      Clean up spec · 57847e69
      Z.J. van de Weg authored
      57847e69
    • Z.J. van de Weg's avatar
      Minor edits, incorporate review · b3aae422
      Z.J. van de Weg authored
      b3aae422
  16. 22 Feb, 2017 1 commit
  17. 07 Feb, 2017 1 commit
  18. 29 Dec, 2016 1 commit
  19. 26 Dec, 2016 1 commit
  20. 10 Nov, 2016 1 commit
  21. 14 Oct, 2016 2 commits
  22. 07 Oct, 2016 1 commit
  23. 14 Jul, 2016 1 commit
  24. 07 Jul, 2015 1 commit
  25. 02 Jun, 2015 1 commit