An error occurred fetching the project authors.
  1. 21 Jun, 2017 1 commit
  2. 02 Jun, 2017 1 commit
  3. 18 May, 2017 1 commit
  4. 17 May, 2017 2 commits
    • Yorick Peterse's avatar
      Hide nested group UI/API support for MySQL · 34974258
      Yorick Peterse authored
      This hides/disables some UI elements and API parameters related to
      nested groups when MySQL is used, since nested groups are not supported
      for MySQL.
      34974258
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      ac382b56
  5. 12 May, 2017 2 commits
  6. 10 May, 2017 1 commit
  7. 01 May, 2017 2 commits
  8. 05 Apr, 2017 1 commit
  9. 03 Apr, 2017 2 commits
  10. 30 Mar, 2017 1 commit
  11. 23 Mar, 2017 1 commit
  12. 21 Mar, 2017 1 commit
  13. 24 Feb, 2017 2 commits
    • Timothy Andrew's avatar
      Implement final review comments from @DouweM and @rymai · f2ed82fa
      Timothy Andrew authored
      - Have `Uniquify` take a block instead of a Proc/function. This is more
        idiomatic than passing around a function in Ruby.
      
      - Block a user before moving their issues to the ghost user. This avoids a data
        race where an issue is created after the issues are migrated to the ghost user,
        and before the destroy takes place.
      
      - No need to migrate issues (to the ghost user) in a transaction, because
        we're using `update_all`
      
      - Other minor changes
      f2ed82fa
    • Timothy Andrew's avatar
      Extract code from `Namespace#clean_path` for ghost user generation. · ca16c373
      Timothy Andrew authored
      1. Create a `Uniquify` class, which generalizes the process of generating unique
         strings, by accepting a function that defines what "uniqueness" means in a
         given context.
      
      2. WIP: Make sure tests for `Namespace` pass, add more if necessary.
      
      3. WIP: Add tests for `Uniquify`
      ca16c373
  14. 23 Feb, 2017 5 commits
  15. 22 Feb, 2017 1 commit
  16. 20 Feb, 2017 1 commit
    • Z.J. van de Weg's avatar
      Transactional mattermost team creation · 444d71e0
      Z.J. van de Weg authored
      Before this commit, but still on this feature branch, the creation of
      mattermost teams where a background job. However, it was decided it was
      better that these happened as transaction so feedback could be displayed
      to the user.
      444d71e0
  17. 16 Feb, 2017 1 commit
    • Stan Hu's avatar
      Fix a number of race conditions that can occur during namespace deletion · 6606a450
      Stan Hu authored
      There are two problems in the current implementation:
      
      1. If a project is marked for deletion via the `pending_delete` flag
      and then the namespace was quickly deleted, it's possible that the
      namespace skips over that project and leaves that project in
      an orphaned state.
      
      2. Before namespace deletion, the namespace attempts to clean up
      all the relevant storage paths. However, if all projects have been
      removed synchronously, then the namespace will not be able to clean anything.
      To prevent this, we should load the paths to be deleted before
      actually destroying projects.
      
      The specs were missing this second case due to a permission issue
      that caused project removal never to happen.
      6606a450
  18. 08 Feb, 2017 2 commits
  19. 07 Feb, 2017 1 commit
    • Yorick Peterse's avatar
      Refresh authorizations when transferring projects · ebae3839
      Yorick Peterse authored
      This ensures that project authorizations are refreshed when moving a
      project from one namespace to another. When doing so the permissions for
      all users of both the old and new namespaces are refreshed.
      
      See #26194 for more information.
      ebae3839
  20. 31 Jan, 2017 1 commit
  21. 25 Jan, 2017 1 commit
  22. 23 Jan, 2017 1 commit
  23. 20 Jan, 2017 1 commit
  24. 13 Jan, 2017 1 commit
  25. 21 Dec, 2016 1 commit
    • Markus Koller's avatar
      Add more storage statistics · 3ef4f74b
      Markus Koller authored
      This adds counters for build artifacts and LFS objects, and moves
      the preexisting repository_size and commit_count from the projects
      table into a new project_statistics table.
      
      The counters are displayed in the administration area for projects
      and groups, and also available through the API for admins (on */all)
      and normal users (on */owned)
      
      The statistics are updated through ProjectCacheWorker, which can now
      do more granular updates with the new :statistics argument.
      3ef4f74b
  26. 20 Dec, 2016 1 commit
  27. 15 Dec, 2016 1 commit
  28. 13 Dec, 2016 2 commits
  29. 12 Dec, 2016 1 commit