* upstream/master: (226 commits)
  Polish sidebar toggle
  Add changelog entry
  Fix optional args for POST :id/variables
  Update CHANGELOG.md for 9.3.1
  Bump bootsnap to 1.1.1
  Add explicit message when no runners on admin
  Fix endpoint not being update correctly
  Remove unused Gitlab::Git::Commit#to_diff argument
  Drop GFM support for the title of Milestone/MergeRequest in template
  Handle Promise rejections in mr_widget_pipeline_spec.js
  Handle missing pipeline in merge request widget
  Store merge request ref_fetched status in the database
  Tag a spec as :nested_groups since it fails on MySQL
  Bump premailer-rails gem to 1.9.7 and its dependencies to prevent network retrieval of assets
  Truncate long job names in environment view; wrap author to next line
  Replaces 'dashboard/merge_requests' spinach with rspec
  Update GITLAB_SHELL_VERSION to 5.0.6
  Fix click not being able to find the current element to use trigger('click') instead
  make accepting mrs more prominent
  Remove last references to job for pipeline charts
  ...

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12363#note_33449374

Store merge request ref_fetched status in the database

Closes #34052

See merge request !12424

Fix optional arugments for POST :id/variables

Closes #34282

See merge request !12474

Handle missing pipeline in merge request widget

Closes #32987

See merge request !12127

Polish sidebar toggle

Closes #28046

See merge request !12242

Always use declared_params(include_missing: false)
so that we don't give nils for optional arguments

Drop GFM support for the title of Milestone/MergeReuqest in template

Closes #34309

See merge request !12451

Bump bootsnap to 1.1.1

Closes #34084

See merge request !12425

[ci skip]

Fix an uncaught throw in the ee_compat_check job

Closes #33600

See merge request !12123

Remove unused Gitlab::Git::Commit#to_diff argument

See merge request !12466

Tag a spec as :nested_groups since it fails on MySQL

See merge request !12459

make accepting mrs more prominent

See merge request !12446

Merge branch '34286_add_esperanto_translations_for_cycle_analytics_and_project_and_repository_pages' into 'master'

Add Esperanto translations for Cycle Analytics, Project, and Repository pages

Closes #34286

See merge request !12442

Top navigation redesign

Closes #34022, #34035, #34037, #34038, and #34021

See merge request !12214

Bump premailer-rails gem to 1.9.7 and its dependencies to prevent network retrieval of assets

Closes #34231

See merge request !12456

Add explicit message when no runners on admin

Closes #33846

See merge request !12266

Truncate long job names in environment view; wrap author to next line

Closes #34320

See merge request !12455

Replace 'dashboard/merge_requests' spinach with rspec

See merge request !12440

Fix endpoint not being update correctly

Closes #33546

See merge request !12449

Fix bug where Service `created_at` time was used instead of deployment time.

Closes #33933

See merge request !12395

Update GITLAB_SHELL_VERSION to 5.0.6

See merge request !12450

Closes #34052

This was broken by
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12322.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Since asset compilation was disabled in GitLab 9.3, the premailer-rails gem
would fall back to fetching assets via HTTP(s) since the Sidekiq working
directory was not the Rails root. In some instances, SSL verification would
fail, preventing e-mails from being sent.

premailer-rails 1.9.7 has a fix
(https://github.com/fphilipe/premailer-rails/pull/195) that uses an absolute
directory to load assets from the filesystem so that the assets can be fetched
locally instead of over the network.

Closes #34231

Backport from EE: Introduce #renew for ExclusiveLease

See merge request !12436

Backport from EE: Fixed DestroyService spec to actually test if removal was successful

See merge request !12437

Hint about the wiki page hook actions (doc)

Closes #34242

See merge request !12427

Remove bin/ci/upgrade.rb

Closes #34207

See merge request !12414