1. 10 Aug, 2017 22 commits
    • Yorick Peterse's avatar
      Use a specialized class for querying events · aac1de46
      Yorick Peterse authored
      This changes various controllers to use the new EventCollection class
      for retrieving events. This class uses a JOIN LATERAL query on
      PostgreSQL to retrieve queries in a more efficient way, while falling
      back to a simpler / less efficient query for MySQL.
      
      The EventCollection class also includes a limit on the number of events
      to display to prevent malicious users from cycling through all events,
      as doing so could put a lot of pressure on the database.
      
      JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0
      and as such this optimisation is only used when using PostgreSQL 9.3 or
      newer.
      aac1de46
    • Yorick Peterse's avatar
      Migrate events into a new format · 0395c471
      Yorick Peterse authored
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
      0395c471
    • Filipa Lacerda's avatar
      Merge branch 'remove-affix-issuable-sidebar-new-nav' into 'master' · afd6e517
      Filipa Lacerda authored
      Remove affix plugin from issuable sidebar with new navigation
      
      See merge request !13449
      afd6e517
    • Phil Hughes's avatar
      Merge branch '36158-new-issue-button' into 'master' · 26684325
      Phil Hughes authored
      Render new issue link in failed job as a regular link instead of a UJS one
      
      Closes #36158
      
      See merge request !13450
      26684325
    • Rémy Coutable's avatar
      Merge branch 'db-changes-mr-template' into 'master' · af925037
      Rémy Coutable authored
      Added a template for database changes
      
      See merge request !12355
      af925037
    • Sean McGivern's avatar
      Merge branch 'mk-fix-case-insensitive-redirect-matching' into 'master' · 4c7ada21
      Sean McGivern authored
      Fix conflicting redirect search
      
      See merge request !13357
      4c7ada21
    • Yorick Peterse's avatar
      Added a template for database changes · 6636b6e9
      Yorick Peterse authored
      This template includes a rather large (but fairly easy to follow)
      checklist. This checklist should hopefully take away quite a bit of work
      from database specialists by requiring authors to provide all the
      necessary info.
      
      [ci skip]
      6636b6e9
    • Phil Hughes's avatar
      Merge branch '36185-or-separator' into 'master' · 53ee3805
      Phil Hughes authored
      Aligns OR separater to center properly
      
      Closes #36185
      
      See merge request !13446
      53ee3805
    • Rémy Coutable's avatar
      Merge branch '35342-re2-in-upgrade-docs' into 'master' · 27c19ab5
      Rémy Coutable authored
      Include RE2 in the upgrade docs
      
      See merge request !13448
      27c19ab5
    • Filipa Lacerda's avatar
    • Rémy Coutable's avatar
      Merge branch 'remove-unused-redirect_to_external_issue_tracker' into 'master' · 47ac73b0
      Rémy Coutable authored
      Remove unused `redirect_to_external_issue_tracker` method
      
      See merge request !13444
      47ac73b0
    • Nick Thomas's avatar
      Include RE2 in the upgrade docs · 1c8e4fcd
      Nick Thomas authored
      1c8e4fcd
    • Rémy Coutable's avatar
      Merge branch 'jarv/update-gemfile-lock' into 'master' · f85f272c
      Rémy Coutable authored
      Updating Gemfile.lock for rubocop-rspec dependecy.
      
      See merge request !13410
      f85f272c
    • Phil Hughes's avatar
      Remove affix plugin from issuable sidebar with new navigation · 69f9ee28
      Phil Hughes authored
      This isn't required with the new navigation as it is always position fixed so we are just creating a scroll event listener that will never actually do anything
      69f9ee28
    • Filipa Lacerda's avatar
      Fix linter error · e7d00fbb
      Filipa Lacerda authored
      e7d00fbb
    • Rémy Coutable's avatar
      Merge branch 'gitlab-infrastructure-archive-route-quick-fix' into 'master' · 188181b7
      Rémy Coutable authored
      alternative route for download archive
      
      See merge request !13439
      188181b7
    • haseeb's avatar
      alternative route for download archive · 892ddd38
      haseeb authored
      892ddd38
    • Filipa Lacerda's avatar
      Merge branch 'fixed-sticky-stats-box-commit-view' into 'master' · 8790dc0b
      Filipa Lacerda authored
      Fix the sticky changes bar on commits page
      
      See merge request !13343
      8790dc0b
    • Filipa Lacerda's avatar
      Merge branch 'fly-out-fix-hiding' into 'master' · 7e82da85
      Filipa Lacerda authored
      Removed display styles when hiding the fly out navigation
      
      Closes #36224
      
      See merge request !13431
      7e82da85
    • Filipa Lacerda's avatar
      Aligns OR separater to center properly · 688db54f
      Filipa Lacerda authored
      688db54f
    • Mehdi Lahmam's avatar
      Remove unused `redirect_to_external_issue_tracker` method · 0048fbed
      Mehdi Lahmam authored
      Its usage has been removed at 2fa22a07.
      0048fbed
    • Rémy Coutable's avatar
      Merge branch 'fix-update-guide-with-missing-i18n-section' into 'master' · b79a551c
      Rémy Coutable authored
      Add missing command to compile GetText files
      
      See merge request !13437
      b79a551c
  2. 09 Aug, 2017 18 commits