- 11 Apr, 2018 2 commits
-
-
blackst0ne authored
The `RAILS5=1 rspec spec/controllers/admin/application_settings_controller_spec.rb` command throws the error: Failures: 1) Admin::ApplicationSettingsController PUT #update falls back to defaults when settings are omitted Failure/Error: import_sources = params[:application_setting][:import_sources] NoMethodError: undefined method `[]' for nil:NilClass # ./app/controllers/admin/application_settings_controller.rb:62:in `application_setting_params' This commit fixes it.
-
Robert Speicher authored
Fix enviroments seeding on certain branch names Closes #45051 See merge request gitlab-org/gitlab-ce!18263
-
- 10 Apr, 2018 21 commits
-
-
Robert Speicher authored
Update vendored .gitlab-ci.yml for Auto-Devops See merge request gitlab-org/gitlab-ce!18289
-
Phil Hughes authored
Use axios in the stage component See merge request gitlab-org/gitlab-ce!18286
-
Sean McGivern authored
Make sure hooks run when seeding admin user Closes gitlab-development-kit#335 See merge request gitlab-org/gitlab-ce!18284
-
Olivier Gonzalez authored
-
Rémy Coutable authored
[Rails5] Fix running spinach tests See merge request gitlab-org/gitlab-ce!18281
-
Filipa Lacerda authored
-
Yorick Peterse authored
Reduce complexity of issuable finder query. Closes #37125 See merge request gitlab-org/gitlab-ce!18219
-
Douwe Maan authored
-
Dmitriy Zaporozhets authored
Update Security Products jobs definitions See merge request gitlab-org/gitlab-ce!18265
-
Olivier Gonzalez authored
-
blackst0ne authored
1. Add support for `RAILS5=1|true` for the `bin/spinach` command. 2. Synchronize used spinach versions both for rails4 and rails5. For rails5 it was accidently used spinach 0.10.1 instead of 0.8.10. That brought some problems on running spinach tests. Example of failure message: NoMethodError: undefined method `line' for #<Spinach::Scenario:0x000000000c86ba80> Did you mean? lines /builds/gitlab-org/gitlab-ce/features/support/env.rb:52:in `before_scenario_run'
-
Marin Jankovski authored
Revert "Merge branch 'improve-jobs-queuing-time-metric' into 'master'" See merge request gitlab-org/gitlab-ce!18276
-
Kamil Trzciński authored
This reverts merge request !17730
-
Phil Hughes authored
Replace vue resource with axios for pipelines table See merge request gitlab-org/gitlab-ce!18264
-
Sean McGivern authored
Document process for new Git features See merge request gitlab-org/gitlab-ce!18230
-
Jacob Vosmaer (GitLab) authored
-
Sean McGivern authored
Use Gitaly 0.95.0 See merge request gitlab-org/gitlab-ce!18256
-
Kamil Trzciński authored
Verify that deploy token has valid access when pulling container registry image Closes #45148 See merge request gitlab-org/gitlab-ce!18260
-
Mayra Cabrera authored
-
Zeger-Jan van de Weg authored
Bit of a cryptic commit title, but our seeding will try to guard against branchnames being anything but alphanumerical. These charachters we gsub away but can't have an empty string as replacement. This change is less efficient, but given that the number of seeded MRs per project is very limited, this should be ok.
-
Robert Speicher authored
Migrate features/project/project.feature to RSpec and reorganize several Project feature specs See merge request gitlab-org/gitlab-ce!18223
-
- 09 Apr, 2018 17 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Mayra Cabrera authored
[ci skip]
-
Filipa Lacerda authored
-
Andreas Brandl authored
This removes the extra check for project-ids which is not needed at all. This does not necessarily reduce execution time of the query, but improves planning time by a few millseconds. Closes #37125.
-
Robert Speicher authored
Expose the target commit ID through the tag API See merge request gitlab-org/gitlab-ce!18248
-
Yorick Peterse authored
Use Goldiloader for handling N+1 queries See merge request gitlab-org/gitlab-ce!18217
-
Rémy Coutable authored
Bump Ruby to 2.3.7 and git to 2.17.0 in CI image See merge request gitlab-org/gitlab-ce!18244
-
Phil Hughes authored
Resolve "Cannot read property 'commit_path' of null" Closes #44296 See merge request gitlab-org/gitlab-ce!18231
-
Douwe Maan authored
Use gitlab-shell 7.1.2 See merge request gitlab-org/gitlab-ce!18258
-
Stan Hu authored
-
Stan Hu authored
-
Stan Hu authored
-
Jacob Vosmaer authored
-
Tim Zallmann authored
Update GitLab SVGs version See merge request gitlab-org/gitlab-ce!18250
-
Jacob Vosmaer authored
-
Sean McGivern authored
Goldiloader is great, but has several issues with has_many :through relations: * https://github.com/salsify/goldiloader/issues/12 * https://github.com/salsify/goldiloader/issues/14 * https://github.com/salsify/goldiloader/issues/18 Rather than try to figure out which applies in each case, we should just do the drudge work of manually disabling autoloading for all relations of this type. We can always use regular preloading for specific cases, but this way we avoid generating invalid queries through Goldiloader's magic.
-