- 28 Jun, 2017 12 commits
-
-
Timothy Andrew authored
- Use a struct for scopes, so we can call `scope.if` instead of `scope[:if]` - Refactor the "remove scopes whose :if condition returns false" logic to use a `select` rather than a `reject`.
-
Timothy Andrew authored
-
Timothy Andrew authored
1. Get the spec for `lib/gitlab/auth.rb` passing. - Make the `request` argument to `AccessTokenValidationService` optional - `auth.rb` doesn't need to pass in a request. - Pass in scopes in the format `[{ name: 'api' }]` rather than `['api']`, which is what `AccessTokenValidationService` now expects. 2. Get the spec for `API::V3::Users` passing 2. Get the spec for `AccessTokenValidationService` passing
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- They are not included automatically since `API::Users` does not inherit from `API::API`, as I initially assumed. - Scopes declared in `API::API` are considered global (to the API), and need to be included in all cases.
-
Timothy Andrew authored
- Test `GET` endpoints to check that the scope is allowed. - Test `POST` endpoints to check that the scope is disallowed. - Test both `v3` and `v4` endpoints.
-
Timothy Andrew authored
- Scope declarations of the form: allow_access_with_scope :read_user, if: -> (request) { request.get? } will only apply for `GET` requests - Add a negative test to a `POST` endpoint in the `users` API to test this. Also test for this case in the `AccessTokenValidationService` unit tests.
-
Timothy Andrew authored
- Declaring an endpoint's scopes in a `before` block has proved to be unreliable. For example, if we're accessing the `API::Users` endpoint - code in a `before` block in `API::API` wouldn't be able to see the scopes set in `API::Users` since the `API::API` `before` block runs first. - This commit moves these declarations to the class level, since they don't need to change once set.
-
Tim Zallmann authored
Refactor emoji helpers in preparation for async loading See merge request !12432
-
Clement Ho authored
[ci skip]
-
Sid Sijbrandij authored
-
- 27 Jun, 2017 28 commits
-
-
Douwe Maan authored
Ignore JSON files generated from PO files See merge request !12329
-
Grzegorz Bizon authored
Fix head pipeline stored in merge request for external pipelines Closes #34130 See merge request !12478
-
Grzegorz Bizon authored
[ci skip]
-
Douwe Maan authored
Update mmap2 gem to fix missing symbol error that happens on some installations from source Closes #34221 See merge request !12492
-
Douwe Maan authored
Make the SimpleExecutor rescue exceptions in the executing Checks See merge request !12487
-
Kamil Trzcinski authored
-
Phil Hughes authored
-
Ruben Davila authored
-
Pawel Chojnacki authored
Update mmap2 gem tha disables mmap_obj.gsub! as current implementation uses method that is no longer part of Ruby API
-
Gabriel Mazetto authored
-
Douwe Maan authored
ruby 2.4 compat: update to webmock 2.3.2 See merge request !12471
-
Clement Ho authored
Update templates for 9.3 See merge request !12461
-
Clement Ho authored
Update dependencies list for 9.3 See merge request !12462
-
Robert Speicher authored
Fix application error when Project#last_activity_at is nil Closes #34276 See merge request !12443
-
Phil Hughes authored
Slightly refactor pipeline schedules form in preparation for additions See merge request !12134
-
Bryce Johnson authored
-
Douwe Maan authored
Refactor group members tests See merge request !12465
-
Robert Speicher authored
Adjust commit partial cache key to fix browse buttons Closes #26899 See merge request !12393
-
Clement Ho authored
Merge branch '34014-submitting-reply-to-existing-diff-discussion-using-cmd-ctrl-enter-submits-twice-and-refreshes-page' into 'master' Resolve "Submitting reply to existing diff discussion using Cmd/Ctrl+Enter submits twice and refreshes page" Closes #34014 See merge request !12352
-
Luke "Jared" Bennett authored
Resolve "Submitting reply to existing diff discussion using Cmd/Ctrl+Enter submits twice and refreshes page"
-
Sean McGivern authored
Clean up Gitlab::Git::Commit.find_all See merge request !12476
-
Gabriel Mazetto authored
-
Annabel Dunstone Gray authored
Merge branch '34115-unable-to-access-edit-comment-from-dropdown-menu-in-certain-screen-sizes' into 'master' Resolve "Unable to access edit comment from dropdown menu in certain screen sizes" Closes #34115 See merge request !12421
-
Luke "Jared" Bennett authored
-
Douwe Maan authored
Supplement Traditional Chinese in Hong Kong translation of Project Page & Repository Page Closes #33442 See merge request !11995
-
Douwe Maan authored
Supplement Bulgarian translation of Project Page & Repository Page Closes #33561 See merge request !12083
-
Douwe Maan authored
[ci skip]
-
Mike Greiling authored
-