An error occurred fetching the project authors.
  1. 28 Aug, 2019 1 commit
  2. 23 Aug, 2019 1 commit
    • Stan Hu's avatar
      Eliminate Gitaly N+1 queries with notes API · e24b9c25
      Stan Hu authored
      Similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31834,
      we see that in https://gitlab.com/gitlab-org/gitlab-ce/issues/65957
      there can be hundreds, even thousands, of Gitaly requests in the
      `/api/:version/projects/:id/merge_requests/:noteable_id/notes` endpoint.
      
      Previously, the API to retrieve notes generated hundreds of Gitaly calls
      to determine whether a system note should be shown to the user. It did
      this by:
      
      1. Rendering the Markdown
      2. Extracting cross-references from the Markdown
      3. Issuing a Gitaly `FindCommit` RPC for every reference to validate
      that the commit exists.
      
      The last step is unnecessary because we don't need to display a commit
      if the user doesn't have access to the project in the first place.
      `RendersNotes#prepare_notes_for_rendering` is already used in
      `MergeRequestsController`, which is why we don't see N+1 Gitaly calls
      there. We use it here to optimize the note redaction process.
      e24b9c25
  3. 04 Aug, 2019 1 commit
  4. 01 Aug, 2019 1 commit
  5. 19 Jun, 2019 2 commits
    • Patrick Derichs's avatar
      Simplify result of find_noteable · 5469d21d
      Patrick Derichs authored
      5469d21d
    • Patrick Derichs's avatar
      Use NotesFinder to fetch notes on API and Controllers · 932a9a0c
      Patrick Derichs authored
      Fix missing iid query on NotesFinder
      
      Changed parameters of find_noteable, 
      so changes across a few files were needed.
      MergeRequest also requires iid instead of id query
      
      Make NotesFinder fail with RecordNotFound again
      
      Add specs for target_iid
      
      Using RSpec tablesyntax for target_iid specs
      
      Revert "Using RSpec tablesyntax for target_iid specs"
      
      This reverts commit ba45c7f569a.
      
      Allow find_by! here
      
      Fix variable name
      
      Add readable check
      
      Revert "Add readable check"
      
      This reverts commit 9e3a1a7aa39.
      
      Remove unnecessary assignment
      
      Add required changes for EE
      
      Fix parameter count
      
      Reduce code duplication by extracting a noteable module method
      
      The call to find_noteable was redundant so
      multiple files and lines have changed in that
      commit to use the newly introduced module
      method `noteable`.
      
      Replace casecmp with include check
      
      Add parent_type parameter
      
      
      Revert "Reduce code duplication by extracting
      a noteable module method"
      
      This reverts commit 8c0923babff16.
      
      Method is no longer needed
      
      Check whether noteable can be read by user
      932a9a0c
  6. 04 Mar, 2019 2 commits
  7. 30 Sep, 2018 1 commit
  8. 22 Aug, 2018 2 commits
  9. 12 Jul, 2018 1 commit
  10. 01 May, 2018 1 commit
  11. 23 Apr, 2018 1 commit
  12. 07 Mar, 2018 1 commit
    • Jan Provaznik's avatar
      Add discussion API · dcdfa04b
      Jan Provaznik authored
      * adds basic discussions API for issues and snippets
      * reorganizes notes specs (so same tests can be used for all noteable types - issues, MRs, snippets)
      dcdfa04b