- 06 Jun, 2018 2 commits
-
-
Alexis Reigel authored
-
Alexis Reigel authored
-
- 05 Jun, 2018 38 commits
-
-
Alexis Reigel authored
the related omnibus graphicsmagick package only supports those formats. see https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1975
-
Alexis Reigel authored
the favicon variations don't need to be tested on the entity anymore, as they are A) tested in the dedicated `Gitlab::Favicon` and B) they are created on the client (i.e. the overlays are always the same for all base favicon variants).
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
probably due to recent changes in `UploadsController`.
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
the ci status icons are generated client side, wo we don't need the static files anymore.
-
Alexis Reigel authored
the initial reason for this change was that graphicsmagick does not support writing to ico files. this fact lead to a chain of changes: 1. use png instead of ico (browser support is good enough) 2. render the overlays on the client using the canvas API. this way we only need to store the original favion and generate the overlay versions dynamically. this change also enables (next step) to simplify the handling of the stock favicons as well, as we don't need to generate all the versions upfront.
-
Alexis Reigel authored
-
Alexis Reigel authored
this ways we can keep the `lib/gitlab/ci/status/*` classes to return the bare favicon name as it was before. also the favicon uploader versions are now have the same names as the stock favicons (+ `favicon_` prefix), which makes working with the status names easier.
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
Without the '?' at the end of the favicon url the custom favicon (i.e. the favicons that are served through `UploadController`) are not shown in the browser. It may have something to do with how `#send_file` / `#send_data` set http headers. When serving the same icon file from the public directory everything is fine.
-
Alexis Reigel authored
-
Alexis Reigel authored
`#send_file` won't properly set the favicon's content type otherwise.
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
when versions have a different file format from the original file carrierwave constructs a wrong url (with the original file suffix).
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Rémy Coutable authored
Add Configuration team to the list See merge request gitlab-org/gitlab-ce!19416
-
Sean McGivern authored
Prevent Gitaly WriteConfig log noise Closes gitaly#1221 See merge request gitlab-org/gitlab-ce!19375
-
Jacob Vosmaer (GitLab) authored
-
Kamil Trzciński authored
Add background migrations to archive legacy job traces Closes #46642 See merge request gitlab-org/gitlab-ce!19194
-
Nick Thomas authored
Also verify if extending would override a class method See merge request gitlab-org/gitlab-ce!19377
-
Kamil Trzciński authored
Resolve "NoMethodError: undefined method `previous_changes' for nil:NilClass" Closes #46452 See merge request gitlab-org/gitlab-ce!19190
-
Matija Čupić authored
-
Nick Thomas authored
Perform pull request IO work outside a transaction See merge request gitlab-org/gitlab-ce!19372
-
Achilleas Pipinellis authored
Update security products job and artifact names in documentation. See merge request gitlab-org/gitlab-ce!19315
-