Merge branch '56309-read-only-controller-doesn-t-account-for-relative-paths-for-admin-sidekiq-route' into 'master'

Allow sidekiq admin requests, regardless of root

Closes #56309

See merge request gitlab-org/gitlab-ce!24352

Resolve "Use $EDITOR or another Environment variable to open the new Changelog entry directly in your editor"

Closes #44488

See merge request gitlab-org/gitlab-ce!18020

Use globally-available reCAPTCHA source

Closes #56375

See merge request gitlab-org/gitlab-ce!24390

Fix detecting nested EE constants in RuboCop

See merge request gitlab-org/gitlab-ce!24430

Adopt label renaming from ~"feature proposal" to ~feature

See merge request gitlab-org/gitlab-ce!24371

Add test case to check that branches are correctly listed after CRUD operations

See merge request gitlab-org/gitlab-ce!23850

[master] Validate bundle files before unpacking them

Closes #2770

See merge request gitlab/gitlabhq!2772

Refactor checking personal project limits

See merge request gitlab-org/gitlab-ce!24396

Enable FactoriesInMigration cop for background migrations

See merge request gitlab-org/gitlab-ce!24425

Refactor Project#after_create_default_branch

See merge request gitlab-org/gitlab-ce!24329

The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.

Update changelog entry for !18425

See merge request gitlab-org/gitlab-ce!24432

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18425

Add badge count to projects

Closes #29798

See merge request gitlab-org/gitlab-ce!18425

Extract process_name from GitLab::Sentry

See merge request gitlab-org/gitlab-ce!24422

Document graphicsmagick installation for source installation

Closes #56322

See merge request gitlab-org/gitlab-ce!24404

GitLab::Sentry has a program_context method to determine whether a
Sentry exception occurred in Sidekiq or rails. Since we will need
similar functionality for distributed tracing, this change extracts the
program_context method into GitLab.process_name for more general
consumption.

This refactors some of the logic used for protecting default branches,
in particular Project#after_create_default_branch. The logic for this
method is moved into a separate service class. Ideally we'd get rid of
Project#after_create_default_branch entirely, but unfortunately
Project#after_import depends on it. This means it has to stick around
until we also refactor Project#after_import.

For branch protection levels we introduce
Gitlab::Access::BranchProtection, which provides a small wrapper around
Integer based branch protection levels. Using this class removes the
need for having to constantly refer to Gitlab::Access::PROTECTION_*
constants.

Resolve "In Merge Request diff screen, master is not a hyperlink"

Closes #52275

See merge request gitlab-org/gitlab-ce!23874

This refactors the code used for checking if a user has exceeded the
personal projects limit. As part of this refactor the method has been
renamed from Project#check_limit to "check_personal_projects_limit", as
this name makes it much more clear what the purpose of the method is.
Standalone unit tests have also been added, as before we only had a
single generic validation test that did not cover all cases.

The old implementation of the refactored method also included a `rescue`
statement. This code would only run when a project creator was not set.
The error that would be added wasn't super useful, especially since
there would already be errors for the creator not being present. As none
of the other code in the "check_personal_projects_limit" raises, it has
been removed.

Enable Gitlab-Pages for subgroups

See merge request gitlab-org/gitlab-ce!23505

The Background migration specs also run against a certain version of
the database. So we should avoid using factories.

Fix RSpec/FactoriesInMigrationSpecs in two files

See merge request gitlab-org/gitlab-ce!24405

Add group ful path to project's shared_with_groups

See merge request gitlab-org/gitlab-ce!24052

chore(rubocop): fix Style/TrivialAccessors issues

See merge request gitlab-org/gitlab-ce!24416

Fix contextual_sidebar null function binding

Closes #56394

See merge request gitlab-org/gitlab-ce!24408

Fixed transient user merges immediately spec

Closes gitlab-ee#9206

See merge request gitlab-org/gitlab-ce!24421

Add more information and refactor format of award emoji-related topics

See merge request gitlab-org/gitlab-ce!24288

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9206

Allow setting of feature gates per project

See merge request gitlab-org/gitlab-ce!24184

Update sidekiq-cron 0.6.0 -> 1.0

See merge request gitlab-org/gitlab-ce!24235

Show the correct error page when access is denied

Closes #55110

See merge request gitlab-org/gitlab-ce!23932

Extract internal route logic check out into #internal_route?
Add ? to #grack_route and #lfs_route predicate methods