Commit f4bc6d6f authored by Jason Madden's avatar Jason Madden

Naming cleanup

parent bfbb147b
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
############################################################################## ##############################################################################
# This is very similar to the code in zope.proxy.__init__, but modified # This is very similar to the code in zope.proxy.__init__, but modified
# not to have slots so that we can extend Persistent # to work properly when extending Persistent.
import operator import operator
import sys import sys
...@@ -30,11 +30,10 @@ def _special_name(name): ...@@ -30,11 +30,10 @@ def _special_name(name):
return (name.startswith('_Persistent') return (name.startswith('_Persistent')
or name.startswith('_p_') or name.startswith('_p_')
or name.startswith('_v_') or name.startswith('_v_')
or name in PyProxyBase.__slots__) or name in PyContainedProxyBase.__slots__)
class PyProxyBase(Persistent): class PyContainedProxyBase(Persistent):
"""Persistent proxy """Persistent proxy
""" """
__slots__ = ('_wrapped', '__parent__', '__name__') __slots__ = ('_wrapped', '__parent__', '__name__')
...@@ -140,17 +139,17 @@ class PyProxyBase(Persistent): ...@@ -140,17 +139,17 @@ class PyProxyBase(Persistent):
# Attribute protocol # Attribute protocol
def __getattribute__(self, name): def __getattribute__(self, name):
if _special_name(name): if _special_name(name):
return super(PyProxyBase, self).__getattribute__(name) return super(PyContainedProxyBase, self).__getattribute__(name)
if name in ('__reduce__', '__reduce_ex__', '__getstate__', '__setstate__', '__getnewargs__'): if name in ('__reduce__', '__reduce_ex__', '__getstate__', '__setstate__', '__getnewargs__'):
return object.__getattribute__(self, name) return object.__getattribute__(self, name)
# Only access this if we need it, otherwise persistence problems # Only access this if we need it, otherwise persistence problems
if name == '_wrapped': if name == '_wrapped':
return super(PyProxyBase, self).__getattribute__('_wrapped') return super(PyContainedProxyBase, self).__getattribute__('_wrapped')
try: try:
mine = super(PyProxyBase, self).__getattribute__(name) mine = super(PyContainedProxyBase, self).__getattribute__(name)
except AttributeError: except AttributeError:
mine = _MARKER mine = _MARKER
else: # pragma NO COVER PyPy else: # pragma NO COVER PyPy
...@@ -163,7 +162,7 @@ class PyProxyBase(Persistent): ...@@ -163,7 +162,7 @@ class PyProxyBase(Persistent):
return mine.desc.__get__(self) return mine.desc.__get__(self)
try: try:
try: try:
wrapped = super(PyProxyBase, self).__getattribute__('_wrapped') wrapped = super(PyContainedProxyBase, self).__getattribute__('_wrapped')
except KeyError: except KeyError:
# During commit time of a persistent transaction, we can # During commit time of a persistent transaction, we can
# be in the state where we have an oid, but we are not actually # be in the state where we have an oid, but we are not actually
...@@ -182,16 +181,16 @@ class PyProxyBase(Persistent): ...@@ -182,16 +181,16 @@ class PyProxyBase(Persistent):
def __setattr__(self, name, value): def __setattr__(self, name, value):
if _special_name(name): if _special_name(name):
return super(PyProxyBase, self).__setattr__(name, value) return super(PyContainedProxyBase, self).__setattr__(name, value)
try: try:
super(PyProxyBase, self).__getattribute__(name) super(PyContainedProxyBase, self).__getattribute__(name)
except AttributeError: except AttributeError:
return setattr(self._wrapped, name, value) return setattr(self._wrapped, name, value)
else: else:
return super(PyProxyBase, self).__setattr__(name, value) return super(PyContainedProxyBase, self).__setattr__(name, value)
def __delattr__(self, name): def __delattr__(self, name):
if name in PyProxyBase.__slots__: if name in PyContainedProxyBase.__slots__:
raise AttributeError() raise AttributeError()
delattr(self._wrapped, name) delattr(self._wrapped, name)
...@@ -439,13 +438,13 @@ class PyProxyBase(Persistent): ...@@ -439,13 +438,13 @@ class PyProxyBase(Persistent):
def py_getProxiedObject(obj): def py_getProxiedObject(obj):
if isinstance(obj, PyProxyBase): if isinstance(obj, PyContainedProxyBase):
return obj._wrapped return obj._wrapped
return obj return obj
def py_setProxiedObject(obj, new_value): def py_setProxiedObject(obj, new_value):
if not isinstance(obj, PyProxyBase): if not isinstance(obj, PyContainedProxyBase):
raise TypeError('Not a proxy') raise TypeError('Not a proxy')
old, obj._wrapped = obj._wrapped, new_value old, obj._wrapped = obj._wrapped, new_value
return old return old
...@@ -33,8 +33,8 @@ try: ...@@ -33,8 +33,8 @@ try:
from zope.container._zope_container_contained import ContainedProxyBase from zope.container._zope_container_contained import ContainedProxyBase
from zope.container._zope_container_contained import getProxiedObject from zope.container._zope_container_contained import getProxiedObject
except ImportError: # PyPy except ImportError: # PyPy
from _proxy import py_getProxiedObject as getProxiedObject from zope.container._proxy import py_getProxiedObject as getProxiedObject
from _proxy import PyProxyBase as ContainedProxyBase from zope.container._proxy import PyContainedProxyBase as ContainedProxyBase
from zope.lifecycleevent import ObjectMovedEvent from zope.lifecycleevent import ObjectMovedEvent
from zope.lifecycleevent import ObjectAddedEvent from zope.lifecycleevent import ObjectAddedEvent
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment