- confirm invoice "unconditionally"

Post building script shall work in all possible cases.

Catching only WorkflowException was in consistent:

 * user without privileges in accounting was able to build invoice coming from
   packing list without price currency (script worked well)
 * user with privileges in accounting, which delivered packing list, was not
   able to confirm this invoice, as ValidationFailed was raised


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@31889 20353a03-c40f-0410-a6d1-a30d3c3de9de

bt5/erp5_invoicing/SkinTemplateItem/portal_skins/erp5_invoicing/InvoiceTransaction_postGeneration.xml

@@ -105,19 +105,7 @@ if not invoice.hasTitle() and related_packing_list.hasTitle():\n
 \n
 # initialize accounting_workflow to confirmed state\n
 if invoice.getSimulationState() == \'draft\':\n
-  try :\n
-    context.getPortalObject().portal_workflow.doActionFor(\n
-      invoice, \'confirm_action\',\n
-      comment=translateString(\'Initialised by Delivery Builder.\'),\n
-      skip_period_validation=1)\n
-  except WorkflowException, e:\n
-    # The user cannot pass the transition, it\'s OK\n
-    pass\n
-\n
-  if invoice.getSimulationState() == \'draft\':\n
-    # call the workflow method, if the user cannot perform this operation.\n
-    invoice.confirm(comment=translateString(\'Initialised by Delivery Builder.\'),)\n
-\n
+  invoice.confirm(comment=translateString(\'Initialised by Delivery Builder.\'),)\n
 \n
 # First set the invoice in the building state on the causality workflow\n
 invoice.startBuilding()\n
@@ -184,7 +172,6 @@ invoice.activate(after_path_and_method_id=(related_simulation_movement_path_list
                             <string>order_trade_model_line_copy_id_list</string>
                             <string>order_trade_model_line</string>
                             <string>clipboard</string>
-                            <string>e</string>
                           </tuple>
                         </value>
                     </item>

bt5/erp5_invoicing/bt/revision

-324
\ No newline at end of file
+325
\ No newline at end of file