See merge request nexedi/slapos!1179

This reverts commit 4fa33dfc.

This patch is not complete, backporting full support of
`__{code,defaults}__` on Zope2 would require patching more, so we
decided to keep using func_code with ERP5 on Zope2 and to use
__code__ only with ERP5 on Zope4

Extend the upgrade tests to create data before the upgrade, to
confirm that this data can still be found after the upgrade.

This also extends the test to confirm that after upgrade, inituser
can still login, create content and find content created before and
after upgrade.

After 4fa33dfc (erp5: py3: `func_{code,defaults}` was replaced in
Python3 by `__{code,defaults}__`., 2022-04-25), this was no longer
the case, because during indexation, using existing scripts failed
with AttributeError __code__

There is no real control over port chosen by push/pull.

There is no reason to keep python2 compatibility, as python3 flavour of the
KVM software release is good enough.

Thanks to recent increased test coverage python3 compatibility issue was
spotted, and can be fixed.

That's nothing wrong with such small disk, and the default seems reasonable
enough.

external-disk-* parameters are fully tested, including it's special features
like keeping the image available even in case of dropping them from request
parameters.

See merge request nexedi/slapos!1173

See commit 37cf8a50.

Since
slapos.core@a8917a3c
and slapos.core https://lab.nexedi.com/nexedi/slapos.core/tags/1.7.4 the
tap_ipv4_addr value is empty by default on the servers, especially test nodes.

To not rely on what is provided on the test environment simply mock the
configuration of the machine so that the test is able to prove profile
functionality.

The test does not require to download some enormous images, so provide small
empty qcow2 images, good enough to start the VM.

The problem has been introduced in 5da9c082
"kvm: Improve boot image url handling".

Note the internal usage of md5sum value as image name in the download config
creator.

pim-dm is a python3 only egg and re6st is a python2 only egg.

Deploy pim-dm egg inside a totally separated buildout in python3. 

See merge request nexedi/slapos!1161

See merge request nexedi/slapos!1170

Now the nat-rule-port always has the protocol name, see here:
https://lab.nexedi.com/nexedi/slapos/blob/9a886c4b0c6dd229564292eaa0ef2604fa857aea/software/kvm/instance-kvm.cfg.jinja2#L843

See merge request !1166

fixes CVE-2021-33503

fixes PVE-2022-47833

@tomo reports that parts/golang1.17/pkg/obj/go-build takes ~ 1GB which makes it
wasteful if we want to upload result of compilation to shacache.

It turns out we can drop that particular build cache completely, because it is
used only during the build and test of Go itself and its standard library. And
when Go is installed it will be another - "user" build cache - that will be
used to maintain and reuse build artifacts. For the reference: in SlapOS that
latter "user" build cache is located inside go.work/

-> Purge internal build cache after compilation is over.

Size of parts/golang1.17 before and after hereby patch:

before: 1.6G
after:  447M

See also related discussion in nexedi/slapos!929 (comment 128379)

/reviewed-by @tomo, @jerome
/reviewed-on nexedi/slapos!1169

New revision include a fix for waitdatabases which cause repman test instability.

See merge request nexedi/slapos!1163

Mostly to address the warning in the test that the request parameters
do not comply with schema.

software/{gitlab,nextcloud}: update options to new redis recipe