accounting: review AccountModule_getAvailableGapList

* Remove include_empty_item: We always want an empty item in dialogs
* Remove include_gap_in_path: This was always true

simplify code a little bit.

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_getAvailableGapList.py

@@ -3,18 +3,14 @@
 #  gap / country / gap_name
 # so we always use as "root" the category of depth 2.
 
-results = []
+item_list = [('', '')]
 countries = context.portal_categories.gap.objectValues()
 for country in countries : 
   for gap in country.objectValues() :
-    title = gap.getParentValue().getTranslatedTitle() + '/'+ gap.getTranslatedTitle()
+    title = country.getTranslatedTitle() + '/'+ gap.getTranslatedTitle()
     path = gap.getRelativeUrl()
-    if not include_gap_in_path : 
-      path = path.replace('gap/', '')
+    item_list.append(
+        ((country.getTranslatedTitle() + '/'+ gap.getTranslatedTitle()),
+        path))
 
-    results += [(title, path)]
-
-if include_empty_item == 1:
-  results = [('', '')] + results
-
-return results
+return item_list

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_getAvailableGapList.xml

@@ -50,7 +50,7 @@
         </item>
         <item>
             <key> <string>_params</string> </key>
-            <value> <string>include_gap_in_path=1, include_empty_item=0</string> </value>
+            <value> <string></string> </value>
         </item>
         <item>
             <key> <string>id</string> </key>

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_viewDialogFieldLibrary/your_gap_root.xml

@@ -284,7 +284,7 @@
       <dictionary>
         <item>
             <key> <string>_text</string> </key>
-            <value> <string>python:here.AccountModule_getAvailableGapList(include_gap_in_path=1, include_empty_item=1)</string> </value>
+            <value> <string>python:here.AccountModule_getAvailableGapList()</string> </value>
         </item>
       </dictionary>
     </pickle>

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountModule_viewReportFieldLibrary/your_gap_root.xml

@@ -299,7 +299,7 @@
       <dictionary>
         <item>
             <key> <string>_text</string> </key>
-            <value> <string>python:here.AccountModule_getAvailableGapList(include_gap_in_path=1, include_empty_item=1)</string> </value>
+            <value> <string>python:here.AccountModule_getAvailableGapList()</string> </value>
         </item>
       </dictionary>
     </pickle>

bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/Preference_viewAccounting/my_preferred_accounting_transaction_gap.xml

@@ -275,7 +275,7 @@
       <dictionary>
         <item>
             <key> <string>_text</string> </key>
-            <value> <string>python:here.AccountModule_getAvailableGapList(include_gap_in_path=1, include_empty_item=1)</string> </value>
+            <value> <string>python:here.AccountModule_getAvailableGapList()</string> </value>
         </item>
       </dictionary>
     </pickle>