Remove two XXX and add an entry in the TODO list.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1059 71dcc9de-d417-0410-9af5-da40c76e7ee4

TODO

@@ -113,6 +113,7 @@ RC  - Review output of pylint (CODE)
     - Make admin node able to monitor multiple clusters simultaneously
     - Choose how to compute the storage size
     - Make storage check if the OID match with it's partitions during a store
+    - Send notifications when a storage node is lost
     - When importing data, objects with non-allocated OIDs are stored. The
     storage can detect this and could notify the master to not allocatexd lower
     OIDs. But during import, each object stored trigger this notification and

neo/master/app.py

@@ -592,10 +592,6 @@ class Application(object):
                         if node.getState() == TEMPORARILY_DOWN_STATE \
                                and node.getLastStateChange() + expiration < current_time:
                             logging.warning('%s is down, have to notify the admin' % (node, ))
-                            # XXX: here we should notify the administrator that
-                            # a node seems dead and should be dropped from the
-                            # partition table. This should not be done
-                            # automaticaly to avoid data lost.
                             node.setState(DOWN_STATE)
 
             except OperationFailure:

neo/node.py

@@ -231,8 +231,6 @@ class NodeManager(object):
                 if node.getServer() != addr:
                     # address changed, update it
                     node.setServer(addr)
-                # XXX: detect conflicts, but this should not happened
-                assert node_by_addr is None or node_by_addr is node
                 logging.debug('update node %s %s %s %s' % log_args)
                 node.setState(state)
             else: