Commits · 4e885787494aaacc09e4ba168cbdc748eebf0849 · Iliya Manolov / neoppod

15 Apr, 2009 12 commits

Define accessors for App's tid, conflict_serial, txn_finished and txn_voted... · 4e885787

Vincent Pelletier authored Apr 15, 2009

Define accessors for App's tid, conflict_serial, txn_finished and txn_voted (all in one commit since they are closely related in usage).
Use those accessors instead of accessing properties directly.
Update tests.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@362 71dcc9de-d417-0410-9af5-da40c76e7ee4

4e885787

Fix obvious typo. · 680e33ae

Vincent Pelletier authored Apr 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@361 71dcc9de-d417-0410-9af5-da40c76e7ee4

680e33ae

Factorise self.app accesses. · 694db849

Vincent Pelletier authored Apr 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@360 71dcc9de-d417-0410-9af5-da40c76e7ee4

694db849

Define and use accessors to replace direct access to App's local_var.node_not_ready . · 8311463f
Vincent Pelletier authored Apr 15, 2009
```
Update test.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@359 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8311463f

defned isListeningConnection on mock objects · d3dc0ddc

Aurel authored Apr 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@358 71dcc9de-d417-0410-9af5-da40c76e7ee4

d3dc0ddc

use isListeningConnection instead of isinstance · a2d6fda9

Aurel authored Apr 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@357 71dcc9de-d417-0410-9af5-da40c76e7ee4

a2d6fda9

Add a getter for App's db so it can be tested. · 32c773ec

Vincent Pelletier authored Apr 15, 2009

Update handler to use this accessor.
Update handler test to follow API change.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@356 71dcc9de-d417-0410-9af5-da40c76e7ee4

32c773ec

Raise NotImplementedError instead of NotImplemented in storage/operation.py. · 04c84a2e
Grégory Wisniewski authored Apr 15, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@355 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
04c84a2e
Use isListeningConnection() instead of isinstance in storage/operation.py. · 0dc4a63e
Grégory Wisniewski authored Apr 15, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@354 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0dc4a63e

Update test to follow changes from commit 323. · 85b013cb

Vincent Pelletier authored Apr 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@353 71dcc9de-d417-0410-9af5-da40c76e7ee4

85b013cb

Bug fix in storage/bootstrap test, use test:test as SQL identifiers. · 4fe938d9
Grégory Wisniewski authored Apr 15, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@352 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4fe938d9
Create/drop test database for storage/bootstrap tests. · 52383e85
Grégory Wisniewski authored Apr 15, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@351 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
52383e85

14 Apr, 2009 5 commits

Fix typo on isListeningConnection accesor case. · 846cad64

Grégory Wisniewski authored Apr 14, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@349 71dcc9de-d417-0410-9af5-da40c76e7ee4

846cad64

Add tests for storage/boostrap.py · d61df4a3

Grégory Wisniewski authored Apr 14, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@348 71dcc9de-d417-0410-9af5-da40c76e7ee4

d61df4a3

Use isListeningConnection() instead of isinstance. · 8c5179ff
Grégory Wisniewski authored Apr 14, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@347 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8c5179ff

Fix a discrepancy in connectToPrimaryMasterNode calls: some were providing it... · bba28c85

Vincent Pelletier authored Apr 14, 2009

Fix a discrepancy in connectToPrimaryMasterNode calls: some were providing it a Connector instance, others a Connection instance. It really expects a Connector instance, which is always available on self.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@346 71dcc9de-d417-0410-9af5-da40c76e7ee4

bba28c85

Define boolean accessors on Connection subclasses to be able to determine... · c83cd1b3

Vincent Pelletier authored Apr 14, 2009

Define boolean accessors on Connection subclasses to be able to determine wether a given Connection instance is a listening connection or not.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@345 71dcc9de-d417-0410-9af5-da40c76e7ee4

c83cd1b3

10 Apr, 2009 12 commits

Another batch of TODO removal by implementing them. · 99ad71a9

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@344 71dcc9de-d417-0410-9af5-da40c76e7ee4

99ad71a9

Some more TODO removal by implementing them. · f3e02a3b

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@343 71dcc9de-d417-0410-9af5-da40c76e7ee4

f3e02a3b

Replace StorageNode instance by a Mock object. Remove associated XXX. · 1856d194

Vincent Pelletier authored Apr 10, 2009

Remove outdated TODOs: they are already implemented in the same test.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@342 71dcc9de-d417-0410-9af5-da40c76e7ee4

1856d194

Fix one more unrelated constant comparison. · c5523108

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@341 71dcc9de-d417-0410-9af5-da40c76e7ee4

c5523108

Fix incompatible constant comparisons (spotted by Enum class). · f9d11105
Vincent Pelletier authored Apr 10, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@340 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f9d11105

Add Enum type to protocol constants to automaticaly check code sanity... · f81cae5e

Vincent Pelletier authored Apr 10, 2009

Add Enum type to protocol constants to automaticaly check code sanity (prevents comparing unrelated enumerated constants).
Use Enum class for node and cell states since it's very easy to mix them up.
Update unpack and load-from-mysql code to cast back into EnumItem instances.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@339 71dcc9de-d417-0410-9af5-da40c76e7ee4

f81cae5e

Increase value sanity checks for cell and node states. · 156ef1ef
Vincent Pelletier authored Apr 10, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@338 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
156ef1ef

Fix enumerated constant name. · 445bc004

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@337 71dcc9de-d417-0410-9af5-da40c76e7ee4

445bc004

Remove all test methods which just reimplement Packet decoding methods to check encoding. · 09a29cf4
Vincent Pelletier authored Apr 10, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@336 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
09a29cf4
Do not test instance properties as they are not part of object API. · 9febba7c
Vincent Pelletier authored Apr 10, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@335 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9febba7c

Remove 2 XXX by using real node states. · faa67596

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@334 71dcc9de-d417-0410-9af5-da40c76e7ee4

faa67596

Update test to follow changes introduced in r320. · e5fb619d

Vincent Pelletier authored Apr 10, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@333 71dcc9de-d417-0410-9af5-da40c76e7ee4

e5fb619d

02 Apr, 2009 11 commits

Restore default polling timeout: if we indefinitely wait for activity, we will... · 9194c66f

Vincent Pelletier authored Apr 02, 2009

Restore default polling timeout: if we indefinitely wait for activity, we will never check idle events, so we will never detect application-level timeouts.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@332 71dcc9de-d417-0410-9af5-da40c76e7ee4

9194c66f

Make use of Node.__str__ to avoid crashes when getServer is None (and in other... · 8dacee1b

Vincent Pelletier authored Apr 02, 2009

Make use of Node.__str__ to avoid crashes when getServer is None (and in other places for consistency).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@331 71dcc9de-d417-0410-9af5-da40c76e7ee4

8dacee1b

Rename "node" variable to "cell", since it's actualy a partition cell. · cbd26197
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@330 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cbd26197

Define a string representation of Node isntances. · f3e9bc85

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@329 71dcc9de-d417-0410-9af5-da40c76e7ee4

f3e9bc85

Add a lock-tracing implementation. · c396be67

Vincent Pelletier authored Apr 02, 2009

Update all lock users in Neo to use it instead of threading.Lock and threading.RLock .


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@328 71dcc9de-d417-0410-9af5-da40c76e7ee4

c396be67

app is already present as a local, don't fetch it from self. · a7d9972b
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@327 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a7d9972b

Move "lock" calls outside of "try" block: if "lock" call raises, there are... · b884171c

Vincent Pelletier authored Apr 02, 2009

Move "lock" calls outside of "try" block: if "lock" call raises, there are chances "unlock" call from "finally" will also raise, and hide original exception.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@326 71dcc9de-d417-0410-9af5-da40c76e7ee4

b884171c

Make all connections share the same ClientEventHandler instance. · 283c8d07
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@325 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
283c8d07

Remove unused import. · 9e4d305a

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@324 71dcc9de-d417-0410-9af5-da40c76e7ee4

9e4d305a

Split Dispatcher class into 2: · 256c53ca

Vincent Pelletier authored Apr 02, 2009

 - There is no need for dispatcher to be a thread
 - Polling thread does not need to be a dispatcher
In turns, this allows simplifying Storage.__init__ by moving Dispatcher, ThreadedPoll and EventManager class instantiations to App class.
Add a TODO about missing ThreadedPoll shutdown.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@323 71dcc9de-d417-0410-9af5-da40c76e7ee4

256c53ca

Remove unused imports. · d5a2938b

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@322 71dcc9de-d417-0410-9af5-da40c76e7ee4

d5a2938b