Commits · c396be67884602abc67b4a65ca4356767cb3b345 · Iliya Manolov / neoppod

02 Apr, 2009 16 commits

Add a lock-tracing implementation. · c396be67

Vincent Pelletier authored Apr 02, 2009

Update all lock users in Neo to use it instead of threading.Lock and threading.RLock .


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@328 71dcc9de-d417-0410-9af5-da40c76e7ee4

c396be67

app is already present as a local, don't fetch it from self. · a7d9972b
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@327 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a7d9972b

Move "lock" calls outside of "try" block: if "lock" call raises, there are... · b884171c

Vincent Pelletier authored Apr 02, 2009

Move "lock" calls outside of "try" block: if "lock" call raises, there are chances "unlock" call from "finally" will also raise, and hide original exception.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@326 71dcc9de-d417-0410-9af5-da40c76e7ee4

b884171c

Make all connections share the same ClientEventHandler instance. · 283c8d07
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@325 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
283c8d07

Remove unused import. · 9e4d305a

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@324 71dcc9de-d417-0410-9af5-da40c76e7ee4

9e4d305a

Split Dispatcher class into 2: · 256c53ca

Vincent Pelletier authored Apr 02, 2009

 - There is no need for dispatcher to be a thread
 - Polling thread does not need to be a dispatcher
In turns, this allows simplifying Storage.__init__ by moving Dispatcher, ThreadedPoll and EventManager class instantiations to App class.
Add a TODO about missing ThreadedPoll shutdown.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@323 71dcc9de-d417-0410-9af5-da40c76e7ee4

256c53ca

Remove unused imports. · d5a2938b

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@322 71dcc9de-d417-0410-9af5-da40c76e7ee4

d5a2938b

Add a unit test for Dispatcher class. · 628d8902

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@321 71dcc9de-d417-0410-9af5-da40c76e7ee4

628d8902

Move connectToPrimaryMasterNode from Dispatcher class to App class since it... · 185fa3b3

Vincent Pelletier authored Apr 02, 2009

Move connectToPrimaryMasterNode from Dispatcher class to App class since it does not functionally belong to dispatcher.
This simplifies connectToPrimaryMasterNode code and startup code a bit:
 - connectToPrimaryMasterNode does not need to manually poll to get a response (we use normal code for this)
   This removes a difference between initial master connection and a reconnection.
 - make App instance get a workable dispatcher from the beginning
 - make App handle initial master connection instead of Storage
 - rename "connector" parameter of connectToPrimaryMasterNode into "connector_handler", since it's what it really is
Update caller (ClientEventHandler class).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@320 71dcc9de-d417-0410-9af5-da40c76e7ee4

185fa3b3

Small test cleanups. · 186f65da

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@319 71dcc9de-d417-0410-9af5-da40c76e7ee4

186f65da

Split handler class into 2: · e6ca0260

Vincent Pelletier authored Apr 02, 2009

 - One to handle events expected as answers only, and to treat in their own thread.
 - One to handle all other events, and to tread them in dispatcher thread.
Update "expected answer" caller (app.py's _waitMessage).
Update test.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@318 71dcc9de-d417-0410-9af5-da40c76e7ee4

e6ca0260

Use "super()" instead of explicitely refering to class we inherit from. · f604e270
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@317 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f604e270

Overload handler's dispatch method to always lock connection. · 80c1cc26

Vincent Pelletier authored Apr 02, 2009

Remove explicit locking from one caller.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@316 71dcc9de-d417-0410-9af5-da40c76e7ee4

80c1cc26

Test for partition table readiness at the end of the loop before sleeping... · 462ebca0

Vincent Pelletier authored Apr 02, 2009

Test for partition table readiness at the end of the loop before sleeping rather than at the begining.
 - prevents from sleeping before exiting the loop in the even of a successful connection attemp
 - partition table got flushed a few lines above, so this test is always true on the first loop iteration.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@315 71dcc9de-d417-0410-9af5-da40c76e7ee4

462ebca0

Move import to top-level. · cb08ffaf

Vincent Pelletier authored Apr 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@314 71dcc9de-d417-0410-9af5-da40c76e7ee4

cb08ffaf

Use time.sleep instead of a busy loop to wait for one second to pass. · 9b259cdb
Vincent Pelletier authored Apr 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@313 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9b259cdb

01 Apr, 2009 10 commits

do not fail to return length if body is None · b8ee52f6

Aurel authored Apr 01, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@312 71dcc9de-d417-0410-9af5-da40c76e7ee4

b8ee52f6

add unit test for protocol · 0e5254e8

Aurel authored Apr 01, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@311 71dcc9de-d417-0410-9af5-da40c76e7ee4

0e5254e8

Replace an "*" import by one explicitely stating what it needs to import. · d50e53a8
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@310 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d50e53a8

Initial import of ClientHandler class unit test. · c0335216

Vincent Pelletier authored Apr 01, 2009

Note: there are 3 unimplemented tests (raising NotImplementedError).
test_StopOperation: looks unimplemented in current code (no action besides logging).
test_knownMasterNotifyNodeInformation & test_unknownMasterNotifyNodeInformation: it is yet unsure on how to test those cases.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@309 71dcc9de-d417-0410-9af5-da40c76e7ee4

c0335216

Remove a duplicate assignment to app local variable. · 358f593c
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@308 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
358f593c

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to... · 3593c1aa

Vincent Pelletier authored Apr 01, 2009

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to make it unit-test-friendly: Client node does not have any listening socket, so there cannot be any (MT)ServerConnection instance used to reach handler. Also, Multi-Thread safety is not a runtime but a static criterion (ie, it is most likely a bug to use non-multi-thread-safe Connection subclasses in client). So this test is an always-true check, and can be removed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@307 71dcc9de-d417-0410-9af5-da40c76e7ee4

3593c1aa

There is no need for a client node to retain information on the status of other client nodes. · 241b4eb2
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@306 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
241b4eb2

Change "if" into "elif": it is obviously wrong to call... · 511433ca

Vincent Pelletier authored Apr 01, 2009

Change "if" into "elif": it is obviously wrong to call app.master_conn.getUUID() on None, so this test should only be executed in "not None" case.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@305 71dcc9de-d417-0410-9af5-da40c76e7ee4

511433ca

Commit 303 removed an implicit check againt NoneType. Restore it explicitely. · 9c56ea85
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@304 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9c56ea85

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and... · dfee4fcc

Vincent Pelletier authored Apr 01, 2009

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and similar). This makes things easier to unit test.
Add missing imports.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@303 71dcc9de-d417-0410-9af5-da40c76e7ee4

dfee4fcc

31 Mar, 2009 3 commits

do not hardcode the value everywhere, use a global variable instead · 47d42d56
Aurel authored Mar 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@302 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
47d42d56

check manager is not None before calling it · 6fa4ebc3

Aurel authored Mar 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@301 71dcc9de-d417-0410-9af5-da40c76e7ee4

6fa4ebc3

add unit test for partition table · fd0506e7

Aurel authored Mar 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@300 71dcc9de-d417-0410-9af5-da40c76e7ee4

fd0506e7

27 Mar, 2009 3 commits

fix variable name · 3065a36a

Aurel authored Mar 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@299 71dcc9de-d417-0410-9af5-da40c76e7ee4

3065a36a

same as previous commit but in clear method · c8d119e5

Aurel authored Mar 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@298 71dcc9de-d417-0410-9af5-da40c76e7ee4

c8d119e5

use a list comprehension to instantiate list of partition's rows, othersiwe all · 7d75ebaa

Aurel authored Mar 27, 2009

rows are the same rows thanks to implicit pointer


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@297 71dcc9de-d417-0410-9af5-da40c76e7ee4

7d75ebaa

26 Mar, 2009 8 commits

add unit test for configuration manager · de0813cd

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@296 71dcc9de-d417-0410-9af5-da40c76e7ee4

de0813cd

defined connector in default config · afc808af

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@295 71dcc9de-d417-0410-9af5-da40c76e7ee4

afc808af

add a test for nodes and nodes manager · e5755b0c

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@294 71dcc9de-d417-0410-9af5-da40c76e7ee4

e5755b0c

remove dead code as we can't have a client node connected at this step · dc46f688
Aurel authored Mar 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@293 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dc46f688

add a test for the verification handler · ccd1e781

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@292 71dcc9de-d417-0410-9af5-da40c76e7ee4

ccd1e781

remove unused patch · 5a9a5d56

Aurel authored Mar 26, 2009

fix class name


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@291 71dcc9de-d417-0410-9af5-da40c76e7ee4

5a9a5d56

Revert commit 252: connection is sent to dispatcher via registration, so it's safer to lock it. · 18226f49
Vincent Pelletier authored Mar 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@290 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
18226f49

Revert commit 254: super(MTClientConnection, self).__init__ sends self to... · d04c53f2

Vincent Pelletier authored Mar 26, 2009

Revert commit 254: super(MTClientConnection, self).__init__ sends self to event_manager, which registers it to epoll, and epoll_wait is pending in another thread. So this lock is really needed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@289 71dcc9de-d417-0410-9af5-da40c76e7ee4

d04c53f2