Commits · cac80ee653d3422d5cfb5fe22b540a7333e7b242 · Iliya Manolov / neoppod

21 Jul, 2009 3 commits

Fix neoctl when a node is only known by its UUID (for example, it's present in... · cac80ee6

Vincent Pelletier authored Jul 21, 2009

Fix neoctl when a node is only known by its UUID (for example, it's present in the partition table but never conencted to primary master).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@900 71dcc9de-d417-0410-9af5-da40c76e7ee4

cac80ee6

Change the way PING/PONG are handled: · 499646f4

Vincent Pelletier authored Jul 21, 2009

- PONG is no longer a response (its type value is lower than 0x8000), because it's actually just a "still alive" notification, which happens on demand.
- PING & PONG don't reach the handler level any more, but are directly handled at connection level. There is no point in making them flexible, as a PING really just test that connection is established.
This fixes client's unability to send ping, because of MTClientConnection.ask prototype being incompatible with ClientConnection.ask.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@899 71dcc9de-d417-0410-9af5-da40c76e7ee4

499646f4

Revert commits 889 & 890, as they introduce a bug (all list items are the same instance). · b0c3abbe
Vincent Pelletier authored Jul 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@898 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b0c3abbe

20 Jul, 2009 19 commits

Add a (rather permissive) pylint configuration file. · 8e5b32aa
Vincent Pelletier authored Jul 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@897 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8e5b32aa

Reindent to 4 spaces. Found by pylint. · a1ede2cf

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@896 71dcc9de-d417-0410-9af5-da40c76e7ee4

a1ede2cf

Reindent to 4 spaces. · 8f321c6c

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@895 71dcc9de-d417-0410-9af5-da40c76e7ee4

8f321c6c

Reindent to 4 spaces. · a20c1279

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@894 71dcc9de-d417-0410-9af5-da40c76e7ee4

a20c1279

Remove never-used parameter. Notified by pylint (as being unused, actually being unneeded). · 4fcd66f7
Vincent Pelletier authored Jul 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@893 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4fcd66f7

Fix unaligned indentation. Found by pylint. · 99fb8c6e

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@892 71dcc9de-d417-0410-9af5-da40c76e7ee4

99fb8c6e

Do not shadow "file" global. Found by pylint. · 8e58383b

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@891 71dcc9de-d417-0410-9af5-da40c76e7ee4

8e58383b

(Same as commit 889) · 6482eb8a

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@890 71dcc9de-d417-0410-9af5-da40c76e7ee4

6482eb8a

Use more python-ish way to generate a list of lists. Found py pylint. · 191d17ed
Vincent Pelletier authored Jul 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@889 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
191d17ed

Assortment of pyflakes warnings fixes. · 95456ff6

Vincent Pelletier authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@888 71dcc9de-d417-0410-9af5-da40c76e7ee4

95456ff6

Explain the purpose of IdleEvent in the code, so we stop wondering about it. · 4525ef98

Vincent Pelletier authored Jul 20, 2009

Add XXX where code is overcomplex.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@887 71dcc9de-d417-0410-9af5-da40c76e7ee4

4525ef98

Primary master handle protocol error messages from other nodes without crash. · b5114824
Grégory Wisniewski authored Jul 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@886 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b5114824

Define __str__ method on Packet to help debugging, previous implementation · 8fce97a2

Grégory Wisniewski authored Jul 20, 2009

returned a binary string of packet content.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@885 71dcc9de-d417-0410-9af5-da40c76e7ee4

8fce97a2

Admin node handle answers to askPartitionTable and askNodeInformation into base · a29f63a8

Grégory Wisniewski authored Jul 20, 2009

handler instead of monitoring handler for name consistency. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@884 71dcc9de-d417-0410-9af5-da40c76e7ee4

a29f63a8

Fix address format in neoctl and admin node. · 5203461f

Grégory Wisniewski authored Jul 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@883 71dcc9de-d417-0410-9af5-da40c76e7ee4

5203461f

Store the partition table in the database when receiving answerPartitionTable · d5f7fb10

Grégory Wisniewski authored Jul 20, 2009

packet instead of checking its state.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@882 71dcc9de-d417-0410-9af5-da40c76e7ee4

d5f7fb10

Set the UUID on the connection to ensure good log message because UUID was · 92138046

Grégory Wisniewski authored Jul 20, 2009

missing on tracked packets.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@881 71dcc9de-d417-0410-9af5-da40c76e7ee4

92138046

Broadcast information about a node lost before do specific actions to ensure · c84b66ca

Grégory Wisniewski authored Jul 20, 2009

messages are sent, even if _nodeLost() method raise an exception (like an
OperationException).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@880 71dcc9de-d417-0410-9af5-da40c76e7ee4

c84b66ca

Group test cases by python module in test runner. Add a column with the number · 11b77fc7
Grégory Wisniewski authored Jul 20, 2009
```
of successful tests.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@879 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
11b77fc7

17 Jul, 2009 8 commits

Fix some tests. · 9d430427

Grégory Wisniewski authored Jul 17, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@878 71dcc9de-d417-0410-9af5-da40c76e7ee4

9d430427

Fix super class name. · 625e319f

Grégory Wisniewski authored Jul 17, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@877 71dcc9de-d417-0410-9af5-da40c76e7ee4

625e319f

Disable the commit #723 with comment because this cause many non-critical errors · 4ac7e1f4
Grégory Wisniewski authored Jul 17, 2009
```
from the database adapter.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@876 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4ac7e1f4

Outdate partition table after drop a storage node to set associated cell in · 4766e070

Grégory Wisniewski authored Jul 17, 2009

outdated state and so, trigger the replication process when the node come back.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@875 71dcc9de-d417-0410-9af5-da40c76e7ee4

4766e070

Replace the ip_address and port bu a tuple and set it to None instead of · 982abf85

Grégory Wisniewski authored Jul 17, 2009

('0.0.0.0', 0) default value. This fix a client reject since they are no more
referenced by the default address in the node manager.
This affect protocol message *NodeIdentification, *PrimaryMaster, *NodeList 
and notifyNodeInformation 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@874 71dcc9de-d417-0410-9af5-da40c76e7ee4

982abf85

When starting the cluster from scratch, reset IDs generators, was implicitly · 93c89093

Grégory Wisniewski authored Jul 17, 2009

done with INVALID_*ID values, but fails with None.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@873 71dcc9de-d417-0410-9af5-da40c76e7ee4

93c89093

Do not use INVALID_OID/INVALID_TID/INVALID_PTID out of protocol.py module, · 6df1aa10

Grégory Wisniewski authored Jul 17, 2009

handle special cases with None values, protocol handle the few cases where a TID
can be invalid to indicate there is no value.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@872 71dcc9de-d417-0410-9af5-da40c76e7ee4

6df1aa10

Replace INVALID_UUID values with None out of protocol.py module to unify · ad0d2ccf

Grégory Wisniewski authored Jul 17, 2009

condition. Packet encoding and decoding handle None/INVALID_UUID mapping.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@871 71dcc9de-d417-0410-9af5-da40c76e7ee4

ad0d2ccf

15 Jul, 2009 2 commits

Remove the file descriptor accessor in Connection class because it must be used · 00705a8c

Grégory Wisniewski authored Jul 15, 2009

only in the event manager, at the lowest level of the network system.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@870 71dcc9de-d417-0410-9af5-da40c76e7ee4

00705a8c

Revert commit #864 after a discussion about isolation between the connection and · ee3f9a1d
Grégory Wisniewski authored Jul 15, 2009
```
thread context.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@869 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ee3f9a1d

14 Jul, 2009 8 commits

Some changes in the tests runner, handle import errors to avoid a global crach · 88980cbb

Grégory Wisniewski authored Jul 14, 2009

Add comments to improve this tool later


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@868 71dcc9de-d417-0410-9af5-da40c76e7ee4

88980cbb

Reuse tests for old storage bootstrap handler for the new bootstrap manager. · a1f55c5d
Grégory Wisniewski authored Jul 14, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@867 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a1f55c5d
Change some log message level, especially info to debug. · 078c7786
Grégory Wisniewski authored Jul 14, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@866 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
078c7786

Add application name (configuration section) in log messages to help debugging · 9a7e39d9

Grégory Wisniewski authored Jul 14, 2009

when mixing all application logs: 'cat *.log | sort | less' is helpfull.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@865 71dcc9de-d417-0410-9af5-da40c76e7ee4

9a7e39d9

Remove the 'queue' parameter in MTClientConnection.ask by giving the thread safe · 669eb3ac

Grégory Wisniewski authored Jul 14, 2009

data manager at MTClientConnection's constructor. This allows keep the same
method signature for ask() and to not crash when the client try to send a ping.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@864 71dcc9de-d417-0410-9af5-da40c76e7ee4

669eb3ac

Close the connection before calling the handler method, as it's name implies, · 21c09ad8

Grégory Wisniewski authored Jul 14, 2009

the connection is already closed when the method is triggered. This is fix a bug
where a readable poll event was always available in the event manager (when
doing a poll()) if the close method was never invoked, eg. when a exception is
raised in the connectionClosed method (like VerificationFailure).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@862 71dcc9de-d417-0410-9af5-da40c76e7ee4

21c09ad8

The admin node ask the partition table itself, so don't send it anymore. · d8db8d56

Grégory Wisniewski authored Jul 14, 2009

When a storage node died, leaving the pt in a non-operational state, this now
nicely handled at the connection closure (see previous commit), so it is no more
usefull to check the pt status at temporarily state expiration.
Add an comment to fix a bug just found.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@861 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8db8d56

Call the specialized method after change the node state because the can affect · 378873f2

Grégory Wisniewski authored Jul 14, 2009

the logic in _nodeLost(), especially when dealing with pt and its operational
state.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@860 71dcc9de-d417-0410-9af5-da40c76e7ee4

378873f2