Commits · cfcc8dc3ea84cabd13817fae263bbc8ab10bfb33 · Iliya Manolov / neoppod

28 Jul, 2009 24 commits

Remove an unused "node" local variable (found by pylint). · cfcc8dc3

Vincent Pelletier authored Jul 28, 2009

Avoid using a local variable to display just one in a log.
Fix some inconsistently-named variables.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1048 71dcc9de-d417-0410-9af5-da40c76e7ee4

cfcc8dc3

Except during import, no OID overlapping should happen. Remove TODO entries · 3db3bf56

Grégory Wisniewski authored Jul 28, 2009

about this issue and add another about data import improvements.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1047 71dcc9de-d417-0410-9af5-da40c76e7ee4

3db3bf56

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id... · 773cd549

Vincent Pelletier authored Jul 28, 2009

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id parameter (it was used as a dirty work around to Connection.answer which didn't accept a msg id as parameter).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1046 71dcc9de-d417-0410-9af5-da40c76e7ee4

773cd549

Change Connection.answer prototype: it now takes a msg_id as parameter, not a... · c109d56c

Vincent Pelletier authored Jul 28, 2009

Change Connection.answer prototype: it now takes a msg_id as parameter, not a message any longer. This make this method easier to call from places where the entire message might not be available.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1045 71dcc9de-d417-0410-9af5-da40c76e7ee4

c109d56c

Remove a bug entry in the TODO list, it's fixed with commit #1026. · f04b641b
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1044 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f04b641b
Remove some TODO entries, done in previous commits. · f1aacd24
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1043 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f1aacd24

Don't crash the application when a protocol error packet is received. Since the · 23cd2585

Grégory Wisniewski authored Jul 28, 2009

connection should have been closed, the node should reconnect or trigger any
event as if it was disconnected.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1042 71dcc9de-d417-0410-9af5-da40c76e7ee4

23cd2585

Remove methods that ignore packets to enforce the protocol. · bb8106c2
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1041 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bb8106c2

Remove dead code (_connectionLost raises). · 39357b95

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1040 71dcc9de-d417-0410-9af5-da40c76e7ee4

39357b95

Remove useless method overloading. · 037af03a

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1039 71dcc9de-d417-0410-9af5-da40c76e7ee4

037af03a

Make admin node send a "not ready" error when requested to do something which... · a971382c

Vincent Pelletier authored Jul 28, 2009

Make admin node send a "not ready" error when requested to do something which requires acces to primary master node and the connection is not established.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1038 71dcc9de-d417-0410-9af5-da40c76e7ee4

a971382c

Make neoctl expect & handle properly a "not ready" error code from admin node. · 31c25e4c
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1037 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
31c25e4c
Replace assert with intended ones, do not just disable them. · d1530fcd
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1036 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d1530fcd

An empty partition table is a valid partition table (happens when a master... · 7e103f2a

Vincent Pelletier authored Jul 28, 2009

An empty partition table is a valid partition table (happens when a master didn't get any from a storage). A missing partition table must be detected with a None value.
Don't trash data we received from previous primary master when getting disconnected. It is still valuable, and interesting to fetch from neoctl.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1035 71dcc9de-d417-0410-9af5-da40c76e7ee4

7e103f2a

Remove a line commited by error, used for test purpose. · d1ffa1dc
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1034 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d1ffa1dc
Update neoctl application according to previous commit. · b12e02da
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1033 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b12e02da
Use a named logger and define it in the root module. · db6fcb9b
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1032 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
db6fcb9b

Factorise MasterEventHandler instanciation. · 1b82f1e4

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1031 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b82f1e4

It might not be a good idea to be so strict about partition table changes. Add... · 1657753a

Vincent Pelletier authored Jul 28, 2009

It might not be a good idea to be so strict about partition table changes. Add XXX to mark this in the code.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1030 71dcc9de-d417-0410-9af5-da40c76e7ee4

1657753a

Add a nonn-RC, code cleanup related todo entry. · 53496d04

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1029 71dcc9de-d417-0410-9af5-da40c76e7ee4

53496d04

Factorise Dispatcher.retrieve access. · 9a169bf2

Vincent Pelletier authored Jul 28, 2009

Rename Dispatcher.retrieve into Dispatcher.pop.
When a pop'ing a non-registered connection, don't return a None, but raise a KeyError (rule of repair).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1028 71dcc9de-d417-0410-9af5-da40c76e7ee4

9a169bf2

Fix handleAskPartitionList prototype. Found indirectly by pylint. · ab42ebf8
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1027 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ab42ebf8

Master broadcast to storage nodes the last OID generated. Storage store this · 1e8b930a

Grégory Wisniewski authored Jul 28, 2009

information in their configuration table instead of looking for the greater OID
in the obj table. When a client ask to store an object with an OID greater than
ther last notified by the primary master, the storage log a warning message.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1026 71dcc9de-d417-0410-9af5-da40c76e7ee4

1e8b930a

Implement the notifyLastOID packet. · fb06337c

Grégory Wisniewski authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1025 71dcc9de-d417-0410-9af5-da40c76e7ee4

fb06337c

27 Jul, 2009 11 commits

Fix a potential bug source, where the node retreived by an UUID could be None if · 2f614cb8

Grégory Wisniewski authored Jul 27, 2009

there are connections in identification state.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1024 71dcc9de-d417-0410-9af5-da40c76e7ee4

2f614cb8

Factorize try/except in setConfiguration. · 019d55c5

Grégory Wisniewski authored Jul 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1023 71dcc9de-d417-0410-9af5-da40c76e7ee4

019d55c5

Make Dispatcher.pop expect a msg_id instead of a message. · ce44e838
Vincent Pelletier authored Jul 27, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1022 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ce44e838
Move dispatcher.py to top-level neo module, to share it more broadly. · 51ca7c9e
Vincent Pelletier authored Jul 27, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1021 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
51ca7c9e
Genericise Dispatcher class (remove references to queue). · 5f26aa0a
Vincent Pelletier authored Jul 27, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1020 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5f26aa0a

First draft of the NEO migration tool. · 078084e1

Grégory Wisniewski authored Jul 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1019 71dcc9de-d417-0410-9af5-da40c76e7ee4

078084e1

Admin/master nodes don't answer with ANSWER_CLUSTER_STATE to SET_CLUSTER_STATE, · 1b993a50

Grégory Wisniewski authored Jul 27, 2009

so disable those assertions.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1018 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b993a50

The iterator implementation requires a close() method. · 955b1ed7
Grégory Wisniewski authored Jul 27, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1017 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
955b1ed7

Fix typo. · 60863842

Grégory Wisniewski authored Jul 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1016 71dcc9de-d417-0410-9af5-da40c76e7ee4

60863842

Rewrite of neoctl to split it into 2 parts: · 452c1ca0

Vincent Pelletier authored Jul 27, 2009

- reusable library (neoctl.py)
- console front-end (app.py)


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1015 71dcc9de-d417-0410-9af5-da40c76e7ee4

452c1ca0

Implement iterator() on the Storage. · 80f94b31

Grégory Wisniewski authored Jul 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1014 71dcc9de-d417-0410-9af5-da40c76e7ee4

80f94b31

24 Jul, 2009 5 commits

It has no meaning to require to send cluster name when changing it state: a... · 57f8d9ab

Vincent Pelletier authored Jul 24, 2009

It has no meaning to require to send cluster name when changing it state: a connection can be made to only one cluster at a time, and cluster name coherency is checked upon initial handshake.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1013 71dcc9de-d417-0410-9af5-da40c76e7ee4

57f8d9ab

Fix handleAnswerNodeList prototype. Found indirectly by pylint. · 3612e024
Vincent Pelletier authored Jul 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1012 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3612e024

Decrease logging level of some messages. · d8d12354

Grégory Wisniewski authored Jul 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1011 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8d12354

Implement support of a new transaction with a TID supplied by the client. · f2f0e7be
Grégory Wisniewski authored Jul 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1010 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f2f0e7be

Add new known bugs in the TODO file. · 8c830924

Grégory Wisniewski authored Jul 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1009 71dcc9de-d417-0410-9af5-da40c76e7ee4

8c830924