Commits · efb4da42b3dd15b96b61bf13b395944d915c586a · Iliya Manolov / neoppod

30 Jun, 2009 16 commits

Remove dropNode() calls where it's not safe to change the partition table · efb4da42

Grégory Wisniewski authored Jun 30, 2009

without give the choice to an admin to discard the node's content. Now a node
can be dropped only when requested by the admin node or when a storage has
changed its address (this case should be checked and discussed).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@732 71dcc9de-d417-0410-9af5-da40c76e7ee4

efb4da42

Define the close() method on BaseConnection instead of Connection to allow close · 2cc58316

Grégory Wisniewski authored Jun 30, 2009

a listening connection (as requested in the storage when connecting to the
primary master).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@731 71dcc9de-d417-0410-9af5-da40c76e7ee4

2cc58316

According to previous commit (#729), update bootstrap handler to not expected · 24a4b289

Grégory Wisniewski authored Jun 30, 2009

be applied on a server connection, thus connectionAccepted and
handleRequestNodeIdentification are removed. Remove also some code that should
not be reached, those king of errors should be checked by unit tests on app.py.
Remove handler method that ignore packets to improve the protocol weakness.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@730 71dcc9de-d417-0410-9af5-da40c76e7ee4

24a4b289

Save listenning connection reference in a class variable. Open the listening · 8bee3858

Grégory Wisniewski authored Jun 30, 2009

socket after the primary master connection succeed, because we don't want to any
incoming connections during bootstrap stage.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@729 71dcc9de-d417-0410-9af5-da40c76e7ee4

8bee3858

Same as previous commit but for the storage application. · 254243f5
Grégory Wisniewski authored Jun 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@728 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
254243f5

Accept (but ignore for now) NotifyClusterInformation packets in base master · 393da381

Grégory Wisniewski authored Jun 30, 2009

handler to avoid the application crash.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@727 71dcc9de-d417-0410-9af5-da40c76e7ee4

393da381

Send a notification to any identified node about the cluster state, and cut · 3acd52fa

Grégory Wisniewski authored Jun 30, 2009

any client connections when keaving the RUNNING state.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@726 71dcc9de-d417-0410-9af5-da40c76e7ee4

3acd52fa

Do not remove storage nodes from the partition table when got disconnect, this · 6da1b463

Grégory Wisniewski authored Jun 30, 2009

is a critical operation (can cause data loss) that should only be done by an
administrator.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@725 71dcc9de-d417-0410-9af5-da40c76e7ee4

6da1b463

Split master election handler in two: · d925f14d

Grégory Wisniewski authored Jun 30, 2009

- One the incoming (server) connections 
- Another for initiated (client) connections
Remove checks and decorators no more usefull.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@724 71dcc9de-d417-0410-9af5-da40c76e7ee4

d925f14d

Alias __del__() with close() method to ensure the connection is closed when the · b0fe5e6d
Grégory Wisniewski authored Jun 30, 2009
```
database manager is deleted.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@723 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b0fe5e6d
handleAnswerPrimaryMaster doesn't raise any more, removing a XXX from test. · d939c90f
Vincent Pelletier authored Jun 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@722 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d939c90f

propagate protocolError message to original connection · e712e586

Aurel authored Jun 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@721 71dcc9de-d417-0410-9af5-da40c76e7ee4

e712e586

-when sending an error message use answer method so that admin node · 5c20c924

Aurel authored Jun 30, 2009

retrieve the original connection
- simplify if...else condition


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@720 71dcc9de-d417-0410-9af5-da40c76e7ee4

5c20c924

AnswerPrimaryMaster is now expected to happen before NodeIdentification... · 8b046c68

Vincent Pelletier authored Jun 30, 2009

AnswerPrimaryMaster is now expected to happen before NodeIdentification happens, so this test function becomes pointless.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@719 71dcc9de-d417-0410-9af5-da40c76e7ee4

8b046c68

Fix test_unknownNewPrimaryAnswerPrimaryMaster test (getNodeByUUID is called... · 8cdf5c24

Vincent Pelletier authored Jun 30, 2009

Fix test_unknownNewPrimaryAnswerPrimaryMaster test (getNodeByUUID is called just once, so it retrieved the value intended for the check of answering peer connection).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@718 71dcc9de-d417-0410-9af5-da40c76e7ee4

8cdf5c24

retrieve node at the of the handler method to avoid undefined variable · 74b738ca
Aurel authored Jun 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@717 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
74b738ca

29 Jun, 2009 14 commits

First batch of fixes for testClientHandler: · 5b71dae3

Vincent Pelletier authored Jun 29, 2009

- add trying_master_node where needed
- decrease the expected number of getNodeByUUID calls by one, since the first lookup is rendered useless by splitting handlers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@716 71dcc9de-d417-0410-9af5-da40c76e7ee4

5b71dae3

Replace all faked getConnForNode by faked getConnForCell. · cb51be00
Vincent Pelletier authored Jun 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@715 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cb51be00
Fix test_history: getConnForNode was replaced by getConnForCell where a cell is actually provided. · 82b90e99
Vincent Pelletier authored Jun 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@714 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
82b90e99
Raise instead of continuing if askObjectHistory returned the history of another object. · 0e0ae7b5
Vincent Pelletier authored Jun 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@713 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0e0ae7b5
Woops, NeoException is declared in the main exception.py file, not the one in the client. · a3e5eaa0
Vincent Pelletier authored Jun 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@712 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a3e5eaa0

Add a missing import. · b4a5a9af

Vincent Pelletier authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@711 71dcc9de-d417-0410-9af5-da40c76e7ee4

b4a5a9af

implement "neoctl print cluster" call · 3d837577

Aurel authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@710 71dcc9de-d417-0410-9af5-da40c76e7ee4

3d837577

Fix test_connectToPrimaryMasterNode: connectToPrimaryMasterNode internal behavour changed. · e6ebedf3

Vincent Pelletier authored Jun 29, 2009

- it does not register new primary nodes (this only needs to be implemented in the handler as primary node will always send all nodes it knows)
- it sets app.trying_master_node to None when connection fails


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@709 71dcc9de-d417-0410-9af5-da40c76e7ee4

e6ebedf3

Add missing accessor for cluster state. · bfbb9cf7

Grégory Wisniewski authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@708 71dcc9de-d417-0410-9af5-da40c76e7ee4

bfbb9cf7

Add Ask/Answer/Notify Cluster State messages. · 68ac26ca

Grégory Wisniewski authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@707 71dcc9de-d417-0410-9af5-da40c76e7ee4

68ac26ca

comsetic changes · c791f6d1

Aurel authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@706 71dcc9de-d417-0410-9af5-da40c76e7ee4

c791f6d1

make sure to have a connection to the node before changing it state · de2dfaa0

Aurel authored Jun 29, 2009

only send START_OPERATION message is master is in RUNNING state


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@705 71dcc9de-d417-0410-9af5-da40c76e7ee4

de2dfaa0

initialize replicator variable · 3cd85a3d

Aurel authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@704 71dcc9de-d417-0410-9af5-da40c76e7ee4

3cd85a3d

update replicator only if it exists · a765aa9f

Aurel authored Jun 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@703 71dcc9de-d417-0410-9af5-da40c76e7ee4

a765aa9f

26 Jun, 2009 10 commits

Remove duplicate test. Master do not ignore answerPartitionTable packets in · 525ebba8

Grégory Wisniewski authored Jun 26, 2009

verification stage since it's unexpected because the master already got a
partition table it trust and do not ask another.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@702 71dcc9de-d417-0410-9af5-da40c76e7ee4

525ebba8

Log message requires access to packet. · dcb76e60

Vincent Pelletier authored Jun 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@701 71dcc9de-d417-0410-9af5-da40c76e7ee4

dcb76e60

Only emit log line when packet is actually processed, not when it's received. · c9a147bf
Vincent Pelletier authored Jun 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@700 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c9a147bf
anwser with the no error packet when asking to change node/cluster state · 5610ab92
Aurel authored Jun 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@699 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5610ab92
Cleanup storage code now that message queue is implemented. · b524a503
Vincent Pelletier authored Jun 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@698 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b524a503

Implement message queue. This change makes poll handle at most one packet per... · a19130e1

Vincent Pelletier authored Jun 26, 2009

Implement message queue. This change makes poll handle at most one packet per call, instead of handling all pending packets at once.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@697 71dcc9de-d417-0410-9af5-da40c76e7ee4

a19130e1

Only catch KeyErrors generated when fetching a connection to avoid hiding... · 295a2fa8

Vincent Pelletier authored Jun 26, 2009

Only catch KeyErrors generated when fetching a connection to avoid hiding other exceptions. (missed in r687)


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@696 71dcc9de-d417-0410-9af5-da40c76e7ee4

295a2fa8

add packet encoder for the no error packet · ec2ac947

Aurel authored Jun 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@695 71dcc9de-d417-0410-9af5-da40c76e7ee4

ec2ac947

add NO_ERROR_CODE error message · 7bd41469

Aurel authored Jun 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@694 71dcc9de-d417-0410-9af5-da40c76e7ee4

7bd41469

always answer with an answerNodeState message to a setNodeState message · 27090dfa
Aurel authored Jun 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@693 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
27090dfa