git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@340 71dcc9de-d417-0410-9af5-da40c76e7ee4

Add Enum type to protocol constants to automaticaly check code sanity (prevents comparing unrelated enumerated constants).
Use Enum class for node and cell states since it's very easy to mix them up.
Update unpack and load-from-mysql code to cast back into EnumItem instances.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@339 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@338 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@337 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@336 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@335 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@334 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@333 71dcc9de-d417-0410-9af5-da40c76e7ee4

Restore default polling timeout: if we indefinitely wait for activity, we will never check idle events, so we will never detect application-level timeouts.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@332 71dcc9de-d417-0410-9af5-da40c76e7ee4

Make use of Node.__str__ to avoid crashes when getServer is None (and in other places for consistency).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@331 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@330 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@329 71dcc9de-d417-0410-9af5-da40c76e7ee4

Update all lock users in Neo to use it instead of threading.Lock and threading.RLock .


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@328 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@327 71dcc9de-d417-0410-9af5-da40c76e7ee4

Move "lock" calls outside of "try" block: if "lock" call raises, there are chances "unlock" call from "finally" will also raise, and hide original exception.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@326 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@325 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@324 71dcc9de-d417-0410-9af5-da40c76e7ee4

 - There is no need for dispatcher to be a thread
 - Polling thread does not need to be a dispatcher
In turns, this allows simplifying Storage.__init__ by moving Dispatcher, ThreadedPoll and EventManager class instantiations to App class.
Add a TODO about missing ThreadedPoll shutdown.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@323 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@322 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@321 71dcc9de-d417-0410-9af5-da40c76e7ee4

Move connectToPrimaryMasterNode from Dispatcher class to App class since it does not functionally belong to dispatcher.
This simplifies connectToPrimaryMasterNode code and startup code a bit:
 - connectToPrimaryMasterNode does not need to manually poll to get a response (we use normal code for this)
   This removes a difference between initial master connection and a reconnection.
 - make App instance get a workable dispatcher from the beginning
 - make App handle initial master connection instead of Storage
 - rename "connector" parameter of connectToPrimaryMasterNode into "connector_handler", since it's what it really is
Update caller (ClientEventHandler class).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@320 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@319 71dcc9de-d417-0410-9af5-da40c76e7ee4

 - One to handle events expected as answers only, and to treat in their own thread.
 - One to handle all other events, and to tread them in dispatcher thread.
Update "expected answer" caller (app.py's _waitMessage).
Update test.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@318 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@317 71dcc9de-d417-0410-9af5-da40c76e7ee4

Remove explicit locking from one caller.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@316 71dcc9de-d417-0410-9af5-da40c76e7ee4

Test for partition table readiness at the end of the loop before sleeping rather than at the begining.
 - prevents from sleeping before exiting the loop in the even of a successful connection attemp
 - partition table got flushed a few lines above, so this test is always true on the first loop iteration.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@315 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@314 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@313 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@312 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@311 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@310 71dcc9de-d417-0410-9af5-da40c76e7ee4

Note: there are 3 unimplemented tests (raising NotImplementedError).
 test_StopOperation: looks unimplemented in current code (no action besides logging).
 test_knownMasterNotifyNodeInformation & test_unknownMasterNotifyNodeInformation: it is yet unsure on how to test those cases.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@309 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@308 71dcc9de-d417-0410-9af5-da40c76e7ee4

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to make it unit-test-friendly: Client node does not have any listening socket, so there cannot be any (MT)ServerConnection instance used to reach handler. Also, Multi-Thread safety is not a runtime but a static criterion (ie, it is most likely a bug to use non-multi-thread-safe Connection subclasses in client). So this test is an always-true check, and can be removed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@307 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@306 71dcc9de-d417-0410-9af5-da40c76e7ee4

Change "if" into "elif": it is obviously wrong to call app.master_conn.getUUID() on None, so this test should only be executed in "not None" case.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@305 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@304 71dcc9de-d417-0410-9af5-da40c76e7ee4

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and similar). This makes things easier to unit test.
Add missing imports.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@303 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@302 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@301 71dcc9de-d417-0410-9af5-da40c76e7ee4