Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Iliya Manolov
  • slaposslapos
  • Repository
  • slapos
  • software
  • ipython_notebook
  • software.cfg
Find file BlameHistoryPermalink
  • Kirill Smelkov's avatar
    Jupyter: Switch to using JSON in instance parameters · 7b199c9c
    Kirill Smelkov authored Jan 27, 2016
    The reason is: we are going to integrate Jupyter into ERP5 SR, and in
    ERP5 SR code, there is already established infrastructure, which
    requests slave instances. That infrastructure passes parameters in
    serialized (= json) form, that's why we need to switch.
    
    On the other hand, slapos.cookbook:slapconfiguration.serialised handles
    non-json instance parameters as well: when there parameters format is
    not
    
        {'_' -> <json>}
    
    it decodes them as slapos.cookbook:slapconfiguration would do:
    
        https://lab.nexedi.com/nexedi/slapos/blob/69229988/slapos/recipe/slapconfiguration.py#L232
        https://lab.nexedi.com/nexedi/slapos/blob/69229988/slapos/recipe/librecipe/__init__.py#L51
    
    So from this point of view, though we don't really need it here (Jupyter
    SR is relatively new), we are staying backward compatible.
    
    /cc @tiwariayush
    7b199c9c
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7