runUnitTest: Backport d4c2e1c3 from generic ERP5 for 'runUnitTest: ZODB is removed on '--save', so also recreate the Catalog tables installed by bt5s.'.

Author: Kazuhiko Shiozaki <kazuhiko@nexedi.com>
Date:   Thu Feb 4 10:35:33 2016 +0100

    ERP5TypeTestCase: reduce needless ERP5Site_reindexAll call in setUpERP5Site().

    ERP5Site_reindexAll is now called only once when --recreate_catalog=1 is explicitly specified.
    Also manage_catalogClear is not called with --load unless --recreate_catalog=1 is explicitly specified.

Assuming that the test database already exists and 'movement' table already
contains data, on '--save' before this commit:
  1. Create a new ERP5 Site:
     1. Install erp5_mysql_innodb_catalog.
     2. Call ERP5Site_reindexAll(clear_catalog=True) (from ERP5Generator.setupIndex()).
        => At this point, erp5_mysql_innodb_catalog tables are recreated.
  2. Install erp5_movement_table_catalog or any bt5 adding a new SQL table.
     => This does not recreate the table and leave the existing data as it is.
  3. Dump MySQL database to dump.sql.
  => dump.sql contains 'INSERT INTO' for 'movement' table *before* calling runUnitTest command.

This fixes random Unit Tests failures on SQL queries accessing 'movement'
table directly and getting {non-existing,past executions} Movements.

SQL query separator is ';' whereas it is '\0' for ZSQLCatalog. Without
this, "Commands out of sync; you can't run this command now" errors
may happen.

zope.{interface,component} implement Interfaces through __implements__,
__implemented__ (both implementedBy instances) and __provides__ (ClassProvides
instance) attributes set on the class itself through implementedByFallback
(zope.interface.declarations).

However, this implementation creates circular references by referencing the
class itself and thus erp5.* classes (and all its Accessors instances) were
never GC even after a reset.

When running testXHTML and installing the Unit Tests bt5s:
  * After 10 resets:  21MB leak (~  7% of Zope process USS).
  * After 20 resets:  70MB leak (~ 18% of Zope process USS).
  * After 28 resets: 122MB leak (~ 26% of Zope process USS).

If it is the case *and* the action script does not redirect, the password will be
in user's browser history.
There can be two different reasons to not redirect:
- not following the API (ie, intentionally not redirecting)
- letting an exception reach ZPublisher
Also, if the non-redirection causes an HTML page to be rendered, resources
loaded by that page will have a referrer containing the password, leaking it
to potentially foreign servers.

Before fixing this bug, 'listbox_previousPage:method' input button was
submitted but with no value (''). However, this was not handled by the
backward-compatibility code and thus next/previous page buttons would
not work properly if erp5_xhtml_style is not updated.

ListBox: Navigation methods should not be created when rendering ListBox (#20161014-741678).

These methods were generated when rendering the ListBox and with the id
of the ListBox in their name. However, a customer reported the following
problem on Accounting Periods ListBox:

  1. Display Accounting Period ListBox on ZEO-1.
       => The ListBox will be rendered and 'listbox_period_list_*' methods will be generated on ZEO-1.
  2.  Click on 'Next Page' button and the user is redirect to ZEO-2 where the ListBox has never been generated.
       => The method does not exist yet and thus a 404 error is raised.

Instead of having one method per ListBox ID, only one is now created (eg
listbox_setPage() for SelectionTool.setPage()) at Zope startup and the
ListBox ID previously defined in the method name is now defined in the
value attributes of the buttons.

Portal Type as Classes: Fix memory leak: Workflow method list was never emptied and thus reset Workflow Methods were never GC.

ERP5Site.log and Base.log are wrappers to the 'log' function from
Product.ERP5Type.Log, but parameters were forwarded in a wrong way
when called with a single argument:

  self.log(message) # Base method

This was equivalent to:

  log(message, '')  # function from Product.ERP5Type.Log

And the whole message was later part of subsystem in:

  logger = logging.getLogger(subsystem)

But because loggers are never freed, it is important that 'subsystem' does not
vary too often, to avoid a memory leak.

The fix is to simply forwarding parameters with catchall arguments, instead of
duplicating the signature from Product.ERP5Type.Log.

Of course, it remains important to call these methods correctly, otherwise
memory leaks can happen again. For this reason, catchall arguments also
prevents ERP5Site.log and Base.log to be called by ZPublisher.
Reported-by: Kirill Smelkov <kirr@nexedi.com>
Reviewed-by: Kirill Smelkov <kirr@nexedi.com>

Make sure that catalog knows portal_type column and reference column. If catalog does not know those columns, then it will fetch all cataloged objects and will cause memory bloat. This can happen when MariaDB server disk is full.

Also, factorise related key string generation.

As MKCOL_handler() is not implemented on OFS.Folder.Folder class, the one from
ERP5Site was acquired when calling webdav.NullResource.NullResource.MKCOL().

Only Constraints to be kept could be specified by reference, but sometimes
it is convenient to apply all Constraints but one.

Fix mass workflow transition function. If transition is customized and its actbox_url does not use ERP5 Form, then use the default workfl
ow action dialog form instead.

we can and should use 'update_catalog' argument instead to clear catalog.

From Chromium 31, pressing enter key to select ListBox page submit the form
through JS (submitFormOnEnter) *and* wrongly on the default button, at the end
following HTML5 behavior (4.10.22.2 Implicit submission).

Conflicts:
	product/ERP5/bootstrap/erp5_xhtml_style/bt/change_log
	product/ERP5/bootstrap/erp5_xhtml_style/bt/revision

other ZEO clients even if ZODB Components are not.

Steps to reproduce:

  1/ On zope1, view and edit a person to make sure class is fully loaded.
  2/ On zope2 add an interaction in person_interaction_workflow and add a script raising an exception.
  3/ Edit a person on zope2. The exception is raised, confirming that the interaction is called.

  When editing a person on zope1, the exception is not raised.

Fix a problem that access-tab-front-page wrongly caching old page, for example,
even if a user switching to use 'https' from 'http', old 'http' links are
remaining at the front page.

That was because the key of the CachingMethod which was used for caching the
page was ('user' and 'language').
Now the caching key is ('user', 'language' and 'site_url').

This is not a new feature, this behavior is compatible with the old caching
implementation that was using inventory_stock table.
In other words, this brings backs the backword compatibility in invetory
caching.

Selection: Do not set Selections if the new and store name differs instead of raising AssertionError.

http://bugs.jquery.com/attachment/ticket/5968/0001-Fix-jQuery.ajax-success-function-being-called-when-H.patch

When importing back ace.js containing a last line with whitespaces only, the
last line was not imported, and thus the file could never been downloaded
completely as its really size was less than the one on the File ZODB object.

Tests may login/logout with different users. This fixes
testDynamicClassGeneration.TestZodbTestComponent.testRunLiveTest.

ZODB Components: Only Manager or Developer Role should be able to access Component Tools and Components.

Otherwise, without passing the new height/width to resize() and without force,
text is not visible when switching to maximize/fullscreen mode.