1. 28 Aug, 2018 1 commit
    • Jérome Perrin's avatar
      Category self membership after move and clone · 524b5443
      Jérome Perrin authored
      Categories are member of themselves. When a category is renamed, the membership to self was already preserved thanks to nexedi/erp5@7f2e8eb2
      , but this was not the case when a category was cut and pasted.
      
      There are two different cases:
       * When just created, a category is member of itself because this is the [default behavior](https://lab.nexedi.com/nexedi/erp5/blob/b705495de0f04645b7b3ad3b74c46de00c923876/product/CMFCategory/CategoryTool.py#L1193-1196) for categories not having categories set. In this case, it's dynamic.
       * When category has some categories set ( in `self.categories` ) - this happens for example after being renamed - then behavior is different and `self.categories` has to be updated.
      
      7f2e8eb2 was handling properly the later case after a clone, but not in a cut and paste ( move ) scenario, because in this case "after clone" hook is not called.
      
      The first idea was to move the same hook at another level by overloading `_postCopy` but after some discussion and thinking, it seemed more logical to make sure `CategoryTool.setCategoryList` does not save categories membership to self, which is consistent in the way `CategoryTool.getCategoryList` adds the membership to self dynamically.
      
      This MR brings a few more tests, so that we can claim [#1900](https://nexedi.erp5.net/bug_module/1900) and [#704](https://nexedi.erp5.net/bug_module/704) are tested enough and close these old bugs.
      
      
      /reviewed-on nexedi/erp5!664
      524b5443
  2. 27 Aug, 2018 2 commits
  3. 24 Aug, 2018 3 commits
    • Julien Muchembled's avatar
      fixup! Folder: Make recursiveReindexObject scalable by calling _recurseCallMethod · 614a8349
      Julien Muchembled authored
      With commit babbf56f, some objects that were
      not indexed are now indexed, and this fails when these objects can't be indexed.
      
      An exemple is when a PythonScript is stored inside a Web Site:
      
        Traceback (innermost last):
        Module Products.CMFActivity.ActivityTool, line 1360, in invokeGroup
          traverse(method_id)(expanded_object_list)
        Module Products.ERP5Catalog.CatalogTool, line 939, in catalogObjectList
          super(CatalogTool, self).catalogObjectList(tmp_object_list, **m.kw)
        Module Products.ZSQLCatalog.ZSQLCatalog, line 828, in catalogObjectList
          catalog_value=catalog,
        Module Products.ERP5Catalog.CatalogTool, line 875, in wrapObjectList
          - __traceback_info__: (<PythonScript at /erp5/web_site_module/...>,)
          and document_object._getAcquireLocalRoles():
        AttributeError: _getAcquireLocalRoles
      
      Before, such object was skipped because it does not have recursiveReindexObject.
      614a8349
    • Sven Franck's avatar
      erp5_corporate_identity: remove skin layer priority · 05f96cb8
      Sven Franck authored
      /reviewed-on !725
      05f96cb8
    • Vincent Bechu's avatar
  4. 23 Aug, 2018 14 commits
  5. 22 Aug, 2018 1 commit
    • Xiaowu Zhang's avatar
      erp5_web_renderjs_ui_test: wait for page loaded · 8aa74de6
      Xiaowu Zhang authored
      this commit should fix random plus button not present issue when open sort editor
      the reason is sort editor is opened before launcher call editor_panel.close()
      so wait for page loaded before open sort editor
      8aa74de6
  6. 21 Aug, 2018 6 commits
  7. 20 Aug, 2018 2 commits
  8. 17 Aug, 2018 6 commits
  9. 16 Aug, 2018 5 commits