Commit 816609b5 authored by Nicolas Dumazet's avatar Nicolas Dumazet

do not iterate over a changing dict.

Behavior depends on hash orders, hence the success of the migration
test in testBusinessTemplate, and the bad failures at some other places


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@42941 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent c63e7d0d
...@@ -3625,7 +3625,9 @@ class PropertySheetTemplateItem(DocumentTemplateItem, ...@@ -3625,7 +3625,9 @@ class PropertySheetTemplateItem(DocumentTemplateItem,
property_sheet_tool = context.getPortalObject().portal_property_sheets property_sheet_tool = context.getPortalObject().portal_property_sheets
property_sheet_id_set = set(property_sheet_tool.objectIds()) property_sheet_id_set = set(property_sheet_tool.objectIds())
for class_id in migrate_object_dict: # careful, that dictionary will change
class_id_list = migrate_object_dict.keys()
for class_id in class_id_list:
# If the Property Sheet already exists in ZODB, then skip it, # If the Property Sheet already exists in ZODB, then skip it,
# otherwise it should not be needed anymore once the deletion # otherwise it should not be needed anymore once the deletion
# code of the filesystem Property Sheets is enabled # code of the filesystem Property Sheets is enabled
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment