Commit ccd340d4 authored by Vincent Pelletier's avatar Vincent Pelletier

Improve comment.

parent 31917c18
...@@ -1568,10 +1568,19 @@ class SimulationTool(BaseTool): ...@@ -1568,10 +1568,19 @@ class SimulationTool(BaseTool):
elif line_a[key] == line_b[key]: elif line_a[key] == line_b[key]:
result[key] = line_a[key] result[key] = line_a[key]
elif key not in ('date', 'stock_uid', 'path'): elif key not in ('date', 'stock_uid', 'path'):
# This case happens when we got columns in result # There are 2 possible reasons to end up here:
# which are not part of the group by statement, MySQL # - key corresponds to a projected column for which are neither
# used to choose randomly a value for this column, here # known aggregated columns (in which case they should be in
# we just do not set the key in result returned # result_column_id_dict) nor part of grouping columns, and the
# result happens to be unstable. There are cases in ERP5 where
# such result is suposed to be stable, for example
# group_by=('xxx_uid'), selection_list=('xxx_path') because the
# relation is bijective (although the database doesn't know it).
# These should result in stable results (but don't necessarily
# do, ex: xxx_title when object title has been changed between
# cache fill and cache lookup).
# - line_a and line_b are indeed mismatched, and code calling us
# has a bug.
LOG('InventoryTool.getInventoryList.addLineValues', LOG('InventoryTool.getInventoryList.addLineValues',
PROBLEM, PROBLEM,
'mismatch for %s column: %s and %s' % ( 'mismatch for %s column: %s and %s' % (
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment