Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
W
web-apps
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boris Kocherov
web-apps
Commits
a590cac3
Commit
a590cac3
authored
Jun 02, 2017
by
Julia Radzhabova
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[DE] Added option for show/hide resolved comments./
parent
c9dc4183
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
29 additions
and
7 deletions
+29
-7
apps/documenteditor/main/app/controller/LeftMenu.js
apps/documenteditor/main/app/controller/LeftMenu.js
+8
-4
apps/documenteditor/main/app/controller/Main.js
apps/documenteditor/main/app/controller/Main.js
+2
-1
apps/documenteditor/main/app/view/FileMenuPanels.js
apps/documenteditor/main/app/view/FileMenuPanels.js
+17
-1
apps/documenteditor/main/locale/en.json
apps/documenteditor/main/locale/en.json
+1
-0
apps/documenteditor/mobile/app/controller/Main.js
apps/documenteditor/mobile/app/controller/Main.js
+1
-1
No files found.
apps/documenteditor/main/app/controller/LeftMenu.js
View file @
a590cac3
...
...
@@ -302,7 +302,8 @@ define([
}
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
);
(
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
))
?
this
.
api
.
asc_showComments
()
:
this
.
api
.
asc_hideComments
();
var
resolved
=
Common
.
localStorage
.
getItem
(
"
de-settings-resolvedcomment
"
);
(
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
))
?
this
.
api
.
asc_showComments
(
!
(
resolved
!==
null
&&
parseInt
(
resolved
)
==
0
))
:
this
.
api
.
asc_hideComments
();
/** coauthoring end **/
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-fontrender
"
);
...
...
@@ -498,9 +499,12 @@ define([
},
commentsShowHide
:
function
(
mode
)
{
var
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
);
if
(
value
!==
null
&&
0
===
parseInt
(
value
))
{
(
mode
===
'
show
'
)
?
this
.
api
.
asc_showComments
()
:
this
.
api
.
asc_hideComments
();
var
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
),
resolved
=
Common
.
localStorage
.
getItem
(
"
de-settings-resolvedcomment
"
);
value
=
(
value
!==
null
&&
parseInt
(
value
)
==
0
);
resolved
=
(
resolved
!==
null
&&
parseInt
(
resolved
)
==
0
);
if
(
value
||
resolved
)
{
(
mode
===
'
show
'
)
?
this
.
api
.
asc_showComments
(
true
)
:
((
!
value
)
?
this
.
api
.
asc_showComments
(
!
resolved
)
:
this
.
api
.
asc_hideComments
());
}
if
(
mode
===
'
show
'
)
{
...
...
apps/documenteditor/main/app/controller/Main.js
View file @
a590cac3
...
...
@@ -745,7 +745,8 @@ define([
/** coauthoring begin **/
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
);
this
.
isLiveCommenting
=
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
);
this
.
isLiveCommenting
?
this
.
api
.
asc_showComments
()
:
this
.
api
.
asc_hideComments
();
var
resolved
=
Common
.
localStorage
.
getItem
(
"
de-settings-resolvedcomment
"
);
this
.
isLiveCommenting
?
this
.
api
.
asc_showComments
(
!
(
resolved
!==
null
&&
parseInt
(
resolved
)
==
0
))
:
this
.
api
.
asc_hideComments
();
/** coauthoring end **/
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-zoom
"
);
...
...
apps/documenteditor/main/app/view/FileMenuPanels.js
View file @
a590cac3
...
...
@@ -115,6 +115,10 @@ define([
'
<td class="left"><label><%= scope.txtLiveComment %></label></td>
'
,
'
<td class="right"><div id="fms-chb-live-comment"/></td>
'
,
'
</tr>
'
,
'
<tr class="divider coauth"></tr>
'
,
'
<tr class="coauth">
'
,
'
<td class="left"></td>
'
,
'
<td class="right"><div id="fms-chb-resolved-comment"/></td>
'
,
'
</tr>
'
,
'
<tr class="divider coauth"></tr>
'
,
/** coauthoring end **/
'
<tr class="edit">
'
,
'
<td class="left"><label><%= scope.txtSpellCheck %></label></td>
'
,
...
...
@@ -185,6 +189,13 @@ define([
this
.
chLiveComment
=
new
Common
.
UI
.
CheckBox
({
el
:
$
(
'
#fms-chb-live-comment
'
),
labelText
:
this
.
strLiveComment
}).
on
(
'
change
'
,
_
.
bind
(
function
(
field
,
newValue
,
oldValue
,
eOpts
){
this
.
chResolvedComment
.
setDisabled
(
field
.
getValue
()
!==
'
checked
'
);
},
this
));
this
.
chResolvedComment
=
new
Common
.
UI
.
CheckBox
({
el
:
$
(
'
#fms-chb-resolved-comment
'
),
labelText
:
this
.
strResolvedComment
});
/** coauthoring end **/
...
...
@@ -342,6 +353,9 @@ define([
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
);
this
.
chLiveComment
.
setValue
(
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
));
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-resolvedcomment
"
);
this
.
chResolvedComment
.
setValue
(
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
));
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-coauthmode
"
);
if
(
value
===
null
&&
Common
.
localStorage
.
getItem
(
"
de-settings-autosave
"
)
===
null
&&
this
.
mode
.
customization
&&
this
.
mode
.
customization
.
autosave
===
false
)
...
...
@@ -391,6 +405,7 @@ define([
Common
.
localStorage
.
setItem
(
"
de-settings-zoom
"
,
this
.
cmbZoom
.
getValue
());
/** coauthoring begin **/
Common
.
localStorage
.
setItem
(
"
de-settings-livecomment
"
,
this
.
chLiveComment
.
isChecked
()
?
1
:
0
);
Common
.
localStorage
.
setItem
(
"
de-settings-resolvedcomment
"
,
this
.
chResolvedComment
.
isChecked
()
?
1
:
0
);
if
(
this
.
mode
.
isEdit
&&
!
this
.
mode
.
isOffline
&&
this
.
mode
.
canCoAuthoring
)
{
Common
.
localStorage
.
setItem
(
"
de-settings-coauthmode
"
,
this
.
cmbCoAuthMode
.
getValue
());
Common
.
localStorage
.
setItem
(
this
.
cmbCoAuthMode
.
getValue
()
?
"
de-settings-showchanges-fast
"
:
"
de-settings-showchanges-strict
"
,
this
.
cmbShowChanges
.
getValue
());
...
...
@@ -463,7 +478,8 @@ define([
txtFitPage
:
'
Fit to Page
'
,
txtFitWidth
:
'
Fit to Width
'
,
textForceSave
:
'
Save to Server
'
,
strForcesave
:
'
Always save to server (otherwise save to server on document close)
'
strForcesave
:
'
Always save to server (otherwise save to server on document close)
'
,
strResolvedComment
:
'
Turn on display of the resolved comments
'
},
DE
.
Views
.
FileMenuPanels
.
Settings
||
{}));
DE
.
Views
.
FileMenuPanels
.
RecentFiles
=
Common
.
UI
.
BaseView
.
extend
({
...
...
apps/documenteditor/main/locale/en.json
View file @
a590cac3
...
...
@@ -961,6 +961,7 @@
"DE.Views.FileMenuPanels.Settings.txtPt"
:
"Point"
,
"DE.Views.FileMenuPanels.Settings.txtSpellCheck"
:
"Spell Checking"
,
"DE.Views.FileMenuPanels.Settings.txtWin"
:
"as Windows"
,
"DE.Views.FileMenuPanels.Settings.strResolvedComment"
:
"Turn on display of the resolved comments"
,
"DE.Views.HeaderFooterSettings.textBottomCenter"
:
"Bottom Center"
,
"DE.Views.HeaderFooterSettings.textBottomLeft"
:
"Bottom Left"
,
"DE.Views.HeaderFooterSettings.textBottomRight"
:
"Bottom Right"
,
...
...
apps/documenteditor/mobile/app/controller/Main.js
View file @
a590cac3
...
...
@@ -455,7 +455,7 @@ define([
/** coauthoring begin **/
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-livecomment
"
);
this
.
isLiveCommenting
=
!
(
value
!==
null
&&
parseInt
(
value
)
==
0
);
this
.
isLiveCommenting
?
this
.
api
.
asc_showComments
()
:
this
.
api
.
asc_hideComments
();
this
.
isLiveCommenting
?
this
.
api
.
asc_showComments
(
true
)
:
this
.
api
.
asc_hideComments
();
/** coauthoring end **/
value
=
Common
.
localStorage
.
getItem
(
"
de-settings-zoom
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment