Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
T
todomvc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Eugene Shen
todomvc
Commits
40dc71b5
Commit
40dc71b5
authored
Oct 08, 2014
by
Sindre Sorhus
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1000 from ColinEberhardt/master
Updates based on a full run of the browser tests
parents
ae057e10
eb6d776d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
34 deletions
+3
-34
browser-tests/knownIssues.js
browser-tests/knownIssues.js
+2
-34
browser-tests/page.js
browser-tests/page.js
+1
-0
No files found.
browser-tests/knownIssues.js
View file @
40dc71b5
...
...
@@ -23,13 +23,7 @@ module.exports = [
'
TodoMVC - typescript-backbone, Item, should allow me to mark items as complete
'
,
'
TodoMVC - typescript-backbone, Item, should allow me to un-mark items as complete
'
,
'
TodoMVC - typescript-backbone, Item, should allow me to edit an item
'
,
// https://github.com/tastejs/todomvc/issues/829
// checkbox state is inverted
'
TodoMVC - typescript-angular, Mark all as completed, should allow me to mark all items as completed
'
,
'
TodoMVC - typescript-angular, Mark all as completed, should allow me to clear the completion state of all items
'
,
'
TodoMVC - typescript-angular, Mark all as completed, complete all checkbox should update state when items are completed / cleared
'
,
// https://github.com/tastejs/todomvc/issues/828
// routing should default to all
'
TodoMVC - batman, Routing, should highlight the currently applied filter
'
,
...
...
@@ -42,13 +36,6 @@ module.exports = [
'
TodoMVC - angularjs_require, Mark all as completed, should allow me to clear the completion state of all items
'
,
'
TodoMVC - angularjs_require, Mark all as completed, complete all checkbox should update state when items are completed / cleared
'
,
// https://github.com/tastejs/todomvc/issues/824
// this implementation has numerous edit experience issues
'
TodoMVC - typescript-backbone, Editing, should save edits on enter
'
,
'
TodoMVC - typescript-backbone, Editing, should trim entered text
'
,
'
TodoMVC - typescript-backbone, Editing, should remove the item if an empty text string was entered
'
,
'
TodoMVC - typescript-backbone, Editing, should cancel edits on escape
'
,
// https://github.com/tastejs/todomvc/issues/815
// does not hide other controls while editing
'
TodoMVC - dojo, Editing, should hide other controls when editing
'
,
...
...
@@ -57,38 +44,25 @@ module.exports = [
// atma does not hide the main section, instead it hides the toggle-all checkbox
'
TodoMVC - atmajs, No Todos, should hide #main and #footer
'
,
// https://github.com/tastejs/todomvc/issues/817
// batman does not trim input
'
TodoMVC - batman, New Todo, should trim text input
'
,
'
TodoMVC - typescript-backbone, New Todo, should trim text input
'
,
// https://github.com/tastejs/todomvc/issues/819
// the edit experience with soma is quite broken. You can
// get multiple elements into an edit state
'
TodoMVC - somajs, Editing, should remove the item if an empty text string was entered
'
,
'
TodoMVC - somajs_require, Editing, should remove the item if an empty text string was entered
'
,
'
TodoMVC - somajs_require, Editing, should cancel edits on escape
'
,
// the following are covered by the following issue:
// https://github.com/tastejs/todomvc/issues/789
'
TodoMVC - agilityjs, Editing, should cancel edits on escape
'
,
'
TodoMVC - angularjs-perf, Editing, should cancel edits on escape
'
,
'
TodoMVC - closure, Editing, should cancel edits on escape
'
,
'
TodoMVC - jquery, Editing, should cancel edits on escape
'
,
'
TodoMVC - knockback, Editing, should cancel edits on escape
'
,
'
TodoMVC - spine, Editing, should cancel edits on escape
'
,
'
TodoMVC - yui, Editing, should cancel edits on escape
'
,
'
TodoMVC - ariatemplates, Editing, should cancel edits on escape
'
,
'
TodoMVC - dermis, Editing, should cancel edits on escape
'
,
'
TodoMVC - duel, Editing, should cancel edits on escape
'
,
'
TodoMVC - epitome, Editing, should cancel edits on escape
'
,
'
TodoMVC - extjs_deftjs, Editing, should cancel edits on escape
'
,
'
TodoMVC - kendo, Editing, should cancel edits on escape
'
,
'
TodoMVC - olives, Editing, should cancel edits on escape
'
,
'
TodoMVC - plastronjs, Editing, should cancel edits on escape
'
,
'
TodoMVC - rappidjs, Editing, should cancel edits on escape
'
,
'
TodoMVC - serenadejs, Editing, should cancel edits on escape
'
,
'
TodoMVC - somajs, Editing, should cancel edits on escape
'
,
'
TodoMVC - thorax, Editing, should cancel edits on escape
'
,
'
TodoMVC - typescript-angular, Editing, should cancel edits on escape
'
,
'
TodoMVC - angularjs_require, Editing, should cancel edits on escape
'
,
...
...
@@ -115,9 +89,7 @@ module.exports = [
// the following are covered by this issue:
// https://github.com/tastejs/todomvc/issues/795
'
TodoMVC - spine, Mark all as completed, complete all checkbox should update state when items are completed / cleared
'
,
'
TodoMVC - angularjs-perf, Mark all as completed, complete all checkbox should update state when items are completed / cleared
'
,
'
TodoMVC - kendo, Mark all as completed, complete all checkbox should update state when items are completed / cleared
'
,
// the following implementations do not support routing
'
TodoMVC - extjs_deftjs, Routing, should allow me to display active items
'
,
'
TodoMVC - extjs_deftjs, Routing, should allow me to display completed items
'
,
...
...
@@ -222,10 +194,6 @@ module.exports = [
'
TodoMVC - stapes_require, Routing, should allow me to display all items
'
,
'
TodoMVC - stapes_require, Routing, should respect the back button
'
,
// mozart is not on the public website
'
TodoMVC - mozart, New Todo, should allow me to add todo items
'
,
'
TodoMVC - mozart, New Todo, should trim text input
'
,
// ----------------- Test framework issues -----------
// for some reason the persistence test fails for knockout, even though persistence is working
...
...
browser-tests/page.js
View file @
40dc71b5
...
...
@@ -132,6 +132,7 @@ module.exports = function Page(browser) {
var
deleteKeyPresses
=
''
;
for
(
var
i
=
0
;
i
<
50
;
i
++
)
{
deleteKeyPresses
+=
webdriver
.
Key
.
BACK_SPACE
;
deleteKeyPresses
+=
webdriver
.
Key
.
DELETE
;
}
itemEditField
.
sendKeys
(
deleteKeyPresses
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment