Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
T
todomvc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Eugene Shen
todomvc
Commits
429dc9d1
Commit
429dc9d1
authored
Jan 21, 2016
by
Pascal Hartig
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
vanilla-es6: Replace let with const where possible
parent
0d0c0b4a
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
22 additions
and
22 deletions
+22
-22
examples/vanilla-es6/src/controller.js
examples/vanilla-es6/src/controller.js
+1
-1
examples/vanilla-es6/src/helpers.js
examples/vanilla-es6/src/helpers.js
+1
-1
examples/vanilla-es6/src/model.js
examples/vanilla-es6/src/model.js
+2
-2
examples/vanilla-es6/src/store.js
examples/vanilla-es6/src/store.js
+3
-3
examples/vanilla-es6/src/template.js
examples/vanilla-es6/src/template.js
+7
-7
examples/vanilla-es6/src/view.js
examples/vanilla-es6/src/view.js
+8
-8
No files found.
examples/vanilla-es6/src/controller.js
View file @
429dc9d1
...
@@ -177,7 +177,7 @@ export default class Controller {
...
@@ -177,7 +177,7 @@ export default class Controller {
* @param {boolean|undefined} force forces a re-painting of todo items.
* @param {boolean|undefined} force forces a re-painting of todo items.
*/
*/
_filter
(
force
)
{
_filter
(
force
)
{
le
t
active
=
this
.
_activeRoute
;
cons
t
active
=
this
.
_activeRoute
;
const
activeRoute
=
active
.
charAt
(
0
).
toUpperCase
()
+
active
.
substr
(
1
);
const
activeRoute
=
active
.
charAt
(
0
).
toUpperCase
()
+
active
.
substr
(
1
);
// Update the elements on the page, which change with each completed todo
// Update the elements on the page, which change with each completed todo
...
...
examples/vanilla-es6/src/helpers.js
View file @
429dc9d1
...
@@ -19,7 +19,7 @@ export function $on(target, type, callback, useCapture) {
...
@@ -19,7 +19,7 @@ export function $on(target, type, callback, useCapture) {
// Attach a handler to event for all elements that match the selector,
// Attach a handler to event for all elements that match the selector,
// now or in the future, based on a root element
// now or in the future, based on a root element
export
function
$delegate
(
target
,
selector
,
type
,
handler
)
{
export
function
$delegate
(
target
,
selector
,
type
,
handler
)
{
le
t
dispatchEvent
=
event
=>
{
cons
t
dispatchEvent
=
event
=>
{
const
targetElement
=
event
.
target
;
const
targetElement
=
event
.
target
;
const
potentialElements
=
qsa
(
selector
,
target
);
const
potentialElements
=
qsa
(
selector
,
target
);
const
hasMatch
=
Array
.
from
(
potentialElements
).
includes
(
targetElement
);
const
hasMatch
=
Array
.
from
(
potentialElements
).
includes
(
targetElement
);
...
...
examples/vanilla-es6/src/model.js
View file @
429dc9d1
...
@@ -17,7 +17,7 @@ export default class Model {
...
@@ -17,7 +17,7 @@ export default class Model {
create
(
title
,
callback
){
create
(
title
,
callback
){
title
=
title
||
''
;
title
=
title
||
''
;
le
t
newItem
=
{
cons
t
newItem
=
{
title
:
title
.
trim
(),
title
:
title
.
trim
(),
completed
:
false
completed
:
false
};
};
...
@@ -88,7 +88,7 @@ export default class Model {
...
@@ -88,7 +88,7 @@ export default class Model {
* Returns a count of all todos
* Returns a count of all todos
*/
*/
getCount
(
callback
){
getCount
(
callback
){
le
t
todos
=
{
cons
t
todos
=
{
active
:
0
,
active
:
0
,
completed
:
0
,
completed
:
0
,
total
:
0
total
:
0
...
...
examples/vanilla-es6/src/store.js
View file @
429dc9d1
...
@@ -39,7 +39,7 @@ export default class Store {
...
@@ -39,7 +39,7 @@ export default class Store {
* })
* })
*/
*/
find
(
query
,
callback
){
find
(
query
,
callback
){
le
t
todos
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]).
todos
;
cons
t
todos
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]).
todos
;
callback
.
call
(
this
,
todos
.
filter
(
todo
=>
{
callback
.
call
(
this
,
todos
.
filter
(
todo
=>
{
for
(
let
q
in
query
)
{
for
(
let
q
in
query
)
{
...
@@ -72,7 +72,7 @@ export default class Store {
...
@@ -72,7 +72,7 @@ export default class Store {
*/
*/
save
(
updateData
,
callback
,
id
){
save
(
updateData
,
callback
,
id
){
const
data
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]);
const
data
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]);
le
t
todos
=
data
.
todos
;
cons
t
todos
=
data
.
todos
;
const
len
=
todos
.
length
;
const
len
=
todos
.
length
;
// If an ID was actually given, find the item and update each property
// If an ID was actually given, find the item and update each property
...
@@ -112,7 +112,7 @@ export default class Store {
...
@@ -112,7 +112,7 @@ export default class Store {
*/
*/
remove
(
id
,
callback
){
remove
(
id
,
callback
){
const
data
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]);
const
data
=
JSON
.
parse
(
localStorage
[
this
.
_dbName
]);
le
t
todos
=
data
.
todos
;
cons
t
todos
=
data
.
todos
;
const
len
=
todos
.
length
;
const
len
=
todos
.
length
;
for
(
let
i
=
0
;
i
<
todos
.
length
;
i
++
)
{
for
(
let
i
=
0
;
i
<
todos
.
length
;
i
++
)
{
...
...
examples/vanilla-es6/src/template.js
View file @
429dc9d1
...
@@ -10,8 +10,8 @@ const htmlEscapes = {
...
@@ -10,8 +10,8 @@ const htmlEscapes = {
const
reUnescapedHtml
=
/
[
&<>"'`
]
/g
;
const
reUnescapedHtml
=
/
[
&<>"'`
]
/g
;
const
reHasUnescapedHtml
=
new
RegExp
(
reUnescapedHtml
.
source
);
const
reHasUnescapedHtml
=
new
RegExp
(
reUnescapedHtml
.
source
);
le
t
escape
=
str
=>
(
str
&&
reHasUnescapedHtml
.
test
(
str
))
?
str
.
replace
(
reUnescapedHtml
,
escapeHtmlChar
)
:
str
;
cons
t
escape
=
str
=>
(
str
&&
reHasUnescapedHtml
.
test
(
str
))
?
str
.
replace
(
reUnescapedHtml
,
escapeHtmlChar
)
:
str
;
le
t
escapeHtmlChar
=
chr
=>
htmlEscapes
[
chr
];
cons
t
escapeHtmlChar
=
chr
=>
htmlEscapes
[
chr
];
export
default
class
Template
{
export
default
class
Template
{
constructor
()
{
constructor
()
{
...
@@ -44,10 +44,10 @@ export default class Template {
...
@@ -44,10 +44,10 @@ export default class Template {
* })
* })
*/
*/
show
(
data
){
show
(
data
){
le
t
view
=
data
.
map
(
d
=>
{
cons
t
view
=
data
.
map
(
d
=>
{
le
t
template
=
this
.
defaultTemplate
;
cons
t
template
=
this
.
defaultTemplate
;
le
t
completed
=
d
.
completed
?
'
completed
'
:
''
;
cons
t
completed
=
d
.
completed
?
'
completed
'
:
''
;
le
t
checked
=
d
.
completed
?
'
checked
'
:
''
;
cons
t
checked
=
d
.
completed
?
'
checked
'
:
''
;
return
this
.
defaultTemplate
return
this
.
defaultTemplate
.
replace
(
'
{{id}}
'
,
d
.
id
)
.
replace
(
'
{{id}}
'
,
d
.
id
)
...
@@ -66,7 +66,7 @@ export default class Template {
...
@@ -66,7 +66,7 @@ export default class Template {
* @returns {string} String containing the count
* @returns {string} String containing the count
*/
*/
itemCounter
(
activeTodos
){
itemCounter
(
activeTodos
){
le
t
plural
=
activeTodos
===
1
?
''
:
'
s
'
;
cons
t
plural
=
activeTodos
===
1
?
''
:
'
s
'
;
return
`<strong>
${
activeTodos
}
</strong> item
${
plural
}
left`
;
return
`<strong>
${
activeTodos
}
</strong> item
${
plural
}
left`
;
}
}
...
...
examples/vanilla-es6/src/view.js
View file @
429dc9d1
import
{
qs
,
qsa
,
$on
,
$parent
,
$delegate
}
from
'
./helpers
'
;
import
{
qs
,
qsa
,
$on
,
$parent
,
$delegate
}
from
'
./helpers
'
;
le
t
_itemId
=
element
=>
parseInt
(
$parent
(
element
,
'
li
'
).
dataset
.
id
,
10
);
cons
t
_itemId
=
element
=>
parseInt
(
$parent
(
element
,
'
li
'
).
dataset
.
id
,
10
);
le
t
_setFilter
=
currentPage
=>
{
cons
t
_setFilter
=
currentPage
=>
{
qs
(
'
.filters .selected
'
).
className
=
''
;
qs
(
'
.filters .selected
'
).
className
=
''
;
qs
(
`.filters [href="#/
${
currentPage
}
"]`
).
className
=
'
selected
'
;
qs
(
`.filters [href="#/
${
currentPage
}
"]`
).
className
=
'
selected
'
;
};
};
le
t
_elementComplete
=
(
id
,
completed
)
=>
{
cons
t
_elementComplete
=
(
id
,
completed
)
=>
{
const
listItem
=
qs
(
`[data-id="
${
id
}
"]`
);
const
listItem
=
qs
(
`[data-id="
${
id
}
"]`
);
if
(
!
listItem
)
{
if
(
!
listItem
)
{
...
@@ -20,7 +20,7 @@ let _elementComplete = (id, completed) => {
...
@@ -20,7 +20,7 @@ let _elementComplete = (id, completed) => {
qs
(
'
input
'
,
listItem
).
checked
=
completed
;
qs
(
'
input
'
,
listItem
).
checked
=
completed
;
};
};
le
t
_editItem
=
(
id
,
title
)
=>
{
cons
t
_editItem
=
(
id
,
title
)
=>
{
const
listItem
=
qs
(
`[data-id="
${
id
}
"]`
);
const
listItem
=
qs
(
`[data-id="
${
id
}
"]`
);
if
(
!
listItem
)
{
if
(
!
listItem
)
{
...
@@ -29,7 +29,7 @@ let _editItem = (id, title) => {
...
@@ -29,7 +29,7 @@ let _editItem = (id, title) => {
listItem
.
className
+=
'
editing
'
;
listItem
.
className
+=
'
editing
'
;
le
t
input
=
document
.
createElement
(
'
input
'
);
cons
t
input
=
document
.
createElement
(
'
input
'
);
input
.
className
=
'
edit
'
;
input
.
className
=
'
edit
'
;
listItem
.
appendChild
(
input
);
listItem
.
appendChild
(
input
);
...
@@ -109,7 +109,7 @@ export default class View {
...
@@ -109,7 +109,7 @@ export default class View {
}
}
_bindItemEditDone
(
handler
)
{
_bindItemEditDone
(
handler
)
{
le
t
self
=
this
;
cons
t
self
=
this
;
$delegate
(
self
.
$todoList
,
'
li .edit
'
,
'
blur
'
,
function
()
{
$delegate
(
self
.
$todoList
,
'
li .edit
'
,
'
blur
'
,
function
()
{
if
(
!
this
.
dataset
.
iscanceled
)
{
if
(
!
this
.
dataset
.
iscanceled
)
{
...
@@ -129,11 +129,11 @@ export default class View {
...
@@ -129,11 +129,11 @@ export default class View {
}
}
_bindItemEditCancel
(
handler
)
{
_bindItemEditCancel
(
handler
)
{
le
t
self
=
this
;
cons
t
self
=
this
;
$delegate
(
self
.
$todoList
,
'
li .edit
'
,
'
keyup
'
,
function
(
event
)
{
$delegate
(
self
.
$todoList
,
'
li .edit
'
,
'
keyup
'
,
function
(
event
)
{
if
(
event
.
keyCode
===
self
.
ESCAPE_KEY
)
{
if
(
event
.
keyCode
===
self
.
ESCAPE_KEY
)
{
le
t
id
=
_itemId
(
this
);
cons
t
id
=
_itemId
(
this
);
this
.
dataset
.
iscanceled
=
true
;
this
.
dataset
.
iscanceled
=
true
;
this
.
blur
();
this
.
blur
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment