Commit 5b78e89e authored by Addy Osmani's avatar Addy Osmani

Addressing feedback

parent 174bbc42
...@@ -3,8 +3,8 @@ ...@@ -3,8 +3,8 @@
"version": "0.0.0", "version": "0.0.0",
"dependencies": { "dependencies": {
"todomvc-common": "~0.1.4", "todomvc-common": "~0.1.4",
"polymer-selector": "Polymer/polymer-selector", "polymer-selector": "Polymer/polymer-selector",
"flatiron-director": "Polymer/flatiron-director", "flatiron-director": "Polymer/flatiron-director",
"polymer-localstorage": "Polymer/polymer-localstorage" "polymer-localstorage": "Polymer/polymer-localstorage"
} }
} }
# Names should be added to this file with this pattern:
#
# For individuals:
# Name <email address>
#
# For organizations:
# Organization <fnmatch pattern>
#
Google Inc. <*@google.com>
See https://github.com/Polymer/polymer/blob/master/CONTRIBUTING.md
// Copyright (c) 2012 The Polymer Authors. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Additional IP Rights Grant (Patents)
"This implementation" means the copyrightable works distributed by
Google as part of the Polymer project.
Google hereby grants to You a perpetual, worldwide, non-exclusive,
no-charge, royalty-free, irrevocable (except as stated in this section)
patent license to make, have made, use, offer to sell, sell, import,
transfer and otherwise run, modify and propagate the contents of this
implementation of Polymer, where such license applies only to those
patent claims, both currently owned or controlled by Google and acquired
in the future, licensable by Google that are necessarily infringed by
this implementation of Polymer. This grant does not include claims
that would be infringed only as a consequence of further modification of
this implementation. If you or your agent or exclusive licensee
institute or order or agree to the institution of patent litigation
against any entity (including a cross-claim or counterclaim in a
lawsuit) alleging that this implementation of Polymer or any code
incorporated within this implementation of Polymer constitutes
direct or contributory patent infringement, or inducement of patent
infringement, then any patent rights granted to you under this License
for this implementation of Polymer shall terminate as of the date
such litigation is filed.
{
"name": "polymer-localstorage",
"private": true,
"dependencies": {
"polymer": "Polymer/polymer#0.2.1"
},
"version": "0.2.1"
}
\ No newline at end of file
...@@ -124,8 +124,7 @@ label { ...@@ -124,8 +124,7 @@ label {
} }
.destroy:hover { .destroy:hover {
text-shadow: 0 0 1px #000, text-shadow: 0 0 1px #000, 0 0 10px rgba(199, 107, 107, 0.8);
0 0 10px rgba(199, 107, 107, 0.8);
-webkit-transform: scale(1.3); -webkit-transform: scale(1.3);
-moz-transform: scale(1.3); -moz-transform: scale(1.3);
-ms-transform: scale(1.3); -ms-transform: scale(1.3);
...@@ -148,11 +147,11 @@ label { ...@@ -148,11 +147,11 @@ label {
@media screen and (-webkit-min-device-pixel-ratio:0) { @media screen and (-webkit-min-device-pixel-ratio:0) {
.toggle { .toggle {
background: none; background: none;
/* /*
ShadowDOM Polyfill work around for webkit/blink bug ShadowDOM Polyfill work around for webkit/blink bug
https://code.google.com/p/chromium/issues/detail?id=251510 https://code.google.com/p/chromium/issues/detail?id=251510
*/ */
background-color: transparent; background-color: transparent;
} }
.toggle { .toggle {
......
...@@ -28,7 +28,9 @@ ...@@ -28,7 +28,9 @@
}, },
storageIdChanged: function() { storageIdChanged: function() {
this.storage = document.querySelector('#' + this.storageId); this.storage = document.querySelector('#' + this.storageId);
this.storage && (this.items = this.storage.value); if (this.storage) {
this.items = this.storage.value;
}
}, },
filterItems: function() { filterItems: function() {
var fn = this.filters[this.filter]; var fn = this.filters[this.filter];
...@@ -52,7 +54,7 @@ ...@@ -52,7 +54,7 @@
} }
this.itemsChanged(); this.itemsChanged();
}, },
clearItems: function(){ clearItems: function (){
this.items = this.items.filter(this.filters.active); this.items = this.items.filter(this.filters.active);
}, },
setItemsCompleted: function(completed) { setItemsCompleted: function(completed) {
......
...@@ -247,11 +247,11 @@ label[for='toggle-all'] { ...@@ -247,11 +247,11 @@ label[for='toggle-all'] {
@media screen and (-webkit-min-device-pixel-ratio:0) { @media screen and (-webkit-min-device-pixel-ratio:0) {
#toggle-all { #toggle-all {
background: none; background: none;
/* /*
ShadowDOM Polyfill work around for webkit/blink bug ShadowDOM Polyfill work around for webkit/blink bug
https://code.google.com/p/chromium/issues/detail?id=251510 https://code.google.com/p/chromium/issues/detail?id=251510
*/ */
background-color: transparent; background-color: transparent;
} }
#toggle-all { #toggle-all {
......
...@@ -49,7 +49,9 @@ ...@@ -49,7 +49,9 @@
this.model = document.querySelector('#' + this.modelId); this.model = document.querySelector('#' + this.modelId);
}, },
routeChanged: function() { routeChanged: function() {
this.model && (this.model.filter = this.route); if (this.model) {
this.model.filter = this.route;
}
}, },
addTodoAction: function() { addTodoAction: function() {
this.model.newItem(this.$['new-todo'].value); this.model.newItem(this.$['new-todo'].value);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment