Commit 81d044dc authored by Sindre Sorhus's avatar Sindre Sorhus

Merge pull request #935 from pgilad/patch-2

Cache $todoList and improve readability
parents 33513d75 1655470b
...@@ -35,6 +35,7 @@ define([ ...@@ -35,6 +35,7 @@ define([
this.$input = this.$('#new-todo'); this.$input = this.$('#new-todo');
this.$footer = this.$('#footer'); this.$footer = this.$('#footer');
this.$main = this.$('#main'); this.$main = this.$('#main');
this.$todoList = this.$('#todo-list');
this.listenTo(Todos, 'add', this.addOne); this.listenTo(Todos, 'add', this.addOne);
this.listenTo(Todos, 'reset', this.addAll); this.listenTo(Todos, 'reset', this.addAll);
...@@ -76,12 +77,12 @@ define([ ...@@ -76,12 +77,12 @@ define([
// appending its element to the `<ul>`. // appending its element to the `<ul>`.
addOne: function (todo) { addOne: function (todo) {
var view = new TodoView({ model: todo }); var view = new TodoView({ model: todo });
$('#todo-list').append(view.render().el); this.$todoList.append(view.render().el);
}, },
// Add all items in the **Todos** collection at once. // Add all items in the **Todos** collection at once.
addAll: function () { addAll: function () {
this.$('#todo-list').html(''); this.$todoList.empty();
Todos.each(this.addOne, this); Todos.each(this.addOne, this);
}, },
...@@ -124,7 +125,7 @@ define([ ...@@ -124,7 +125,7 @@ define([
Todos.each(function (todo) { Todos.each(function (todo) {
todo.save({ todo.save({
'completed': completed completed: completed
}); });
}); });
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment