1. 28 Feb, 2015 1 commit
  2. 22 Feb, 2015 1 commit
  3. 21 Feb, 2015 8 commits
  4. 20 Feb, 2015 3 commits
  5. 19 Feb, 2015 4 commits
  6. 17 Feb, 2015 4 commits
    • Sindre Sorhus's avatar
      Merge pull request #1168 from samccone/sjs/fix-escape-behavior · 5ff915aa
      Sindre Sorhus authored
      Fix spec compliance for Marionette.
      5ff915aa
    • Sam Saccone's avatar
      Fix spec compliance for Marionette. · ca2b6620
      Sam Saccone authored
      What:
      
      In issue #789 @ColinEberhardt pointed out that many of the examples do
      not respect the rule that when a user hits the esc key on an input that
      the input should be cleared and the input state should be left.
      
      Upon investigation I found the Marionette example to have never followed
      this directive.
      
      How:
      
      Due the how the escape key works and the keypress event binding from
      jQuery one must use the keyup event to register for the escape key
      keycode.
      
      Once I intercept the event I instruct the input area to simply rerender.
      This has the desired effect in that it clears the transient input state
      and also due to it rendering new childnodes clears the focus from the
      user.
      ca2b6620
    • Sindre Sorhus's avatar
      Merge pull request #1167 from samccone/sjs/update-marionette · f7ece0f5
      Sindre Sorhus authored
      Update use of initializers
      f7ece0f5
    • Sam Saccone's avatar
      Update use of initializers · 88416c1d
      Sam Saccone authored
      Marionette as of v2.3.0 has marked initializers as a deprecated feature.
      https://github.com/marionettejs/backbone.marionette/commit/1717c71af306be28cafebcdafda86ba218df0caa
      
      Why is this?
      
      Back when Marionette was built (late 2011), module patterns were still
      emerging, it was the wild west in many ways. @derickbailey came up with
      the idea of marionette modules. Modules were built for managing "components" and nested
      components. They could be stopped and started at will and were also
      started and stopped with their parents (since modules are nestable).
      
      Initializers and Finalizers (pieces of the Marionette.Callbacks helper
      class) are a great idea, and are a very powerful one at that, allowing people to specifiy actions to take onStart or
      onEnd.
      
      That said, the year is 2015 and much has changed about the landscape of
      modules and javascript. Heck @derickbailey even wrote a post about why you
      should not use them anymore.
      http://derickbailey.com/2014/06/10/browserify-my-new-choice-for-modules-in-a-browser-backbone-app/
      
      Marionette is moving away from modules, and is moving into the land of
      applications and sub applications to help people better handle complex
      applications.
      
      -------
      
      fixes #1105
      88416c1d
  7. 16 Feb, 2015 4 commits
  8. 14 Feb, 2015 3 commits
  9. 12 Feb, 2015 4 commits
  10. 11 Feb, 2015 3 commits
  11. 10 Feb, 2015 2 commits
  12. 09 Feb, 2015 3 commits