1. 13 Jun, 2013 7 commits
  2. 12 Jun, 2013 7 commits
  3. 11 Jun, 2013 10 commits
    • Vincent Pelletier's avatar
      Use single-underscore property prefix. · 43ab06c9
      Vincent Pelletier authored
      For easier debugging, so we don't have to know how python mangles
      double-underscore properties, as introspection is reduced by __slots__
      usage.
      Suggested by Julien Muchembled <jm@nexedi.com>
      43ab06c9
    • Vincent Pelletier's avatar
      Move some work out of Message.__init__ . · fda3f093
      Vincent Pelletier authored
      So that creating an ActiveWrapper (or Method) once and reusing it to spawn
      several activities gets a larger speed-up.
      Message class API is not supposed to be used outside this module, so
      drop failing test rather than fixing it.
      fda3f093
    • Vincent Pelletier's avatar
      Declare __slots__ . · 75e7c3b4
      Vincent Pelletier authored
      Also, inherit from "object" as __slots__ are a new-style-class feature.
      75e7c3b4
    • Vincent Pelletier's avatar
      Replace __getattr__ + __[sg]etitem__ calls by a single __[sg]etattr__ call. · c6fab535
      Vincent Pelletier authored
      Also, provide one argument per line.
      Also, avoid shadowing "id" built-in.
      c6fab535
    • Vincent Pelletier's avatar
      Make registerMessage check for duplicate registration. · 2fa6bfeb
      Vincent Pelletier authored
      isMessageRegistered duplicates work done in registerMessage, so it wastes
      time when creating an activity (in the likely event the activity is not a
      duplicate).
      2fa6bfeb
    • Vincent Pelletier's avatar
      Avoid looking up portal_activities when creating a message. · 290a9b38
      Vincent Pelletier authored
      It is (likely) already known to caller, is only used to look up an option
      which is rarely enabled, and it turns out to be (relatively) expensive.
      290a9b38
    • Vincent Pelletier's avatar
      1ee39d03
    • Vincent Pelletier's avatar
      19e6cc3e
    • Vincent Pelletier's avatar
      Work around poor UPDATE use of index. · 7daaf0a5
      Vincent Pelletier authored
      UPDATE query is exected to use the existing index on (processing_node,
      priority, date) both for WHERE and ORDER BY, as is expected from
      EXPLAIN-ing the equivalent SELECT:
      
      MariaDB [erp5]> explain select uid from message_queue WHERE processing_node=0 AND date <= '2013-06-06 22:22:49' ORDER BY priority, date LIMIT 1;
      +------+-------------+---------------+------+----------------------------------------------------------+-------------------------------+---------+-------+-------+--------------------------+
      | id   | select_type | table         | type | possible_keys                                            | key                           | key_len | ref   | rows  | Extra                    |
      +------+-------------+---------------+------+----------------------------------------------------------+-------------------------------+---------+-------+-------+--------------------------+
      |    1 | SIMPLE      | message_queue | ref  | processing_node_processing,processing_node_priority_date | processing_node_priority_date | 2       | const | 26622 | Using where; Using index |
      +------+-------------+---------------+------+----------------------------------------------------------+-------------------------------+---------+-------+-------+--------------------------+
      
      If it weren't using the index for ORDER BY, "Extra" would contain
      "Using filesort".
      
      Still, UPDATE behaves differently:
      
        # User@Host: user[user] @  [10.0.0.3]
        # Thread_id: 1635880  Schema: erp5  QC_hit: No
        # Query_time: 2.668405  Lock_time: 2.460698  Rows_sent: 0  Rows_examined: 49263
        # Full_scan: No  Full_join: No  Tmp_table: No  Tmp_table_on_disk: No
        # Filesort: Yes  Filesort_on_disk: No  Merge_passes: 0
        SET TIMESTAMP=1370557446;
        UPDATE
          message_queue
        SET
          processing_node=12
        WHERE
          processing_node=0
          AND DATE <= '2013-06-06 22:24:04'
          ORDER BY
          priority, DATE
        LIMIT 1;
      
      So change the UPDATE..SELECT pattern into a SELECT FOR UPDATE..UPDATE
      pattern, so SELECT's correct execution plan is used.
      7daaf0a5
    • Kazuhiko Shiozaki's avatar
      explicitly specify update_catalog argument in business template installation. · 3b74878d
      Kazuhiko Shiozaki authored
      that should be part of commit 9b5c74fb ('force' argument in
      BusinessTemplate._install() should not mean clear catalog. we can and
      should use 'update_catalog' argument instead to clear catalog).
      3b74878d
  4. 10 Jun, 2013 6 commits
  5. 07 Jun, 2013 5 commits
  6. 06 Jun, 2013 4 commits
  7. 05 Jun, 2013 1 commit