1. 03 Nov, 2015 2 commits
  2. 31 Oct, 2015 1 commit
  3. 30 Oct, 2015 1 commit
  4. 27 Oct, 2015 1 commit
  5. 20 Oct, 2015 4 commits
  6. 19 Oct, 2015 10 commits
  7. 18 Oct, 2015 4 commits
  8. 17 Oct, 2015 2 commits
  9. 16 Oct, 2015 1 commit
  10. 15 Oct, 2015 1 commit
  11. 14 Oct, 2015 2 commits
  12. 13 Oct, 2015 2 commits
  13. 12 Oct, 2015 1 commit
    • David Runger's avatar
      use express.js server for tests; closes #1465 · 7b7c8d97
      David Runger authored
      Use an express.js server for tests instead of http-server. The primary
      reason for this is that express has an available middleware that allows
      us to specificy the location of the favicon other than the root
      directory. This is needed because the favicon lives in the site-assets
      directory.
      7b7c8d97
  14. 11 Oct, 2015 2 commits
    • Pascal Hartig's avatar
      Merge pull request #1466 from davidrunger/remove-unneeded-logic · 828b6d1c
      Pascal Hartig authored
      Backbone: remove unneeded logic in todo View
      828b6d1c
    • David Runger's avatar
      Backbone: remove unneeded logic in todo View · 9e16caf8
      David Runger authored
      The removed check is unncecessary and also incorrectly implemented,
      resulting in a test failure (the "Editing should trim entered text"
      example) and flawed user interaction. This change results in 100%
      passing tests and the desired user interaction.
      
      Unneeded: the associated comment states that "Model values changes
      consisting of whitespaces only are not causing change to be triggered",
      and so the code manually triggers a change event when the only change to
      the todo is whitespace being added at the beginning and/or end of the
      todo. However, there is no need for the change event when this is the
      only change. So the situation described in the comment is not a problem.
      The change event triggers a re-rendering of the view, but if the only
      change is whitespace at the beginning or end, which is trimmed off,
      anyway, then re-rendering is pointless.
      
      Incorrectly implemented: The code in question is
      `this.model.trigger('change');`. This ultimately raises an error,
      because (perhaps surprisingly) when the 'change' event is manually
      triggered on a model, the model is not automatically bound as the so-to-
      speak "context" of that change. This can be corrected manually like so:
      `this.model.trigger('change', this.model);`. This eliminates the error
      and failing test case. However, as this code is not needed, anyway, of
      course it's better to simply remove it. :)
      9e16caf8
  15. 10 Oct, 2015 6 commits