- 11 Feb, 2020 10 commits
-
-
Gabriel Monnerat authored
Request body should contain the image data and the active process relative url (depending on which erp5 context the script is called)
-
Gabriel Monnerat authored
make jslint happy
-
Gabriel Monnerat authored
* change the `extra renderjs` parameters list to pass a Python script to call when a new image is cropped. * change the gadget to use jio.util.ajax with the script full url (provided by the server)
-
Gabriel Monnerat authored
Change the gadget checkValidity method to return false when: - no thumbnail has been generated - a thumbnail upload is in failed state
-
Gabriel Monnerat authored
The default value is a JSON containing 2 keys: - the relative_url of an active process - the list of active process image content to aggregate By default, when the field is rendered for the first time, this tales expression is evaluated and a new active process is created at that point. So, default json is like: {active_process: 'portal_activities/1234', image_list: []} * store the active_process relative_url in the gadget state in the render method * store the image_list in the gadget state in the render_method * change getContent method to send a json build from the active_process and image_list state
-
Gabriel Monnerat authored
If device_id is propagated to onStateChange, it means we have a new value. Then, check if we have this property is enough to switch
-
Gabriel Monnerat authored
-
Romain Courteaud authored
XXX Allow to show previously uploaded image. Allow to delete or retry uploading. Form submittion only send the active process informations.
-
Romain Courteaud authored
Stop relying of CSS hide/show attributes. Instead, only put needed elements in the DOM.
-
Romain Courteaud authored
-
- 10 Feb, 2020 9 commits
-
-
Roque authored
- use global preference to get publication section value - test updated
-
Roque authored
-
Roque authored
-
Roque authored
/reviewed-on nexedi/erp5!1017
-
Arnaud Fontaine authored
ZODB Components: Resetting Portal Type classes was also clearing Interfaces of erp5.component.* modules. __implemented__ and __provides__ attributes are cleared on Portal Type reset to break a circular reference (11e2b506). Resetting of ZODB Components is done independently of Portal Type classes, so until the next ZODB Component reset, Interfaces were not implemented anymore. 11e2b506 states that this creates a memory leak but this is not actually true as Python garbage collector will break such circular reference and collect this object, as asserted by a newly introduced Unit Test. This is probably less efficient than explicitly breaking the circular reference and thus relies on reference counting (rather than the garbage collector) but doing otherwise would require introspecting ZODB Components module to find classes implementing Interfaces (erp5.portal_type only contains classes). This only takes care of ZODB Components modules but maybe breaking circular references for Portal Type classes is not even needed (if so, this will be done in a later commit).
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: When migrating FS Mixin, set the ZODB Component reference to the class name (like Interfaces).
-
Arnaud Fontaine authored
ZODB Components: Non-core bt5 with 'Document Component' overriding standard ERP5 Document must create its own version_priority. Otherwise this will clash when standard ERP5 Document will be migrated to ZODB Components to erp5_base.
-
Arnaud Fontaine authored
Like Document and Interface Components for the same reasons (694c9fee).
-
- 07 Feb, 2020 2 commits
-
-
Jérome Perrin authored
Since 264ded5c in ERP5JS we render the form directly after a successful edit, but this was done sometimes too early, namely, the next form was rendered before interaction workflows and this leads to problems like the ones discussed in nexedi/erp5!982 (comment 92893) /reviewed-on nexedi/erp5!1040
-
Jérome Perrin authored
This test click on the delete button which deletes by an ajax request and immediatly after open the "wait for activities" page. Sometimes the second request starts before the first is committed, so there are no activities to wait for. When using ZServer, we had only one worker thread, so this was not visible, but with wsgi we have more than one so it happened sometimes. Use an old jQuery trick to wait that the first request is no longer in flight. /reviewed-on nexedi/erp5!1038
-
- 06 Feb, 2020 3 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Also covers traversal (and a lot more).
-
- 05 Feb, 2020 3 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02 SameSite=None breaks the compatibility with some browser versions. https://www.chromium.org/updates/same-site/incompatible-clients We choose Lax and not Strict so that we can open links to ERP5 from external applications and so that OAuth Logins work. Implementing the "two cookies, one for read one for write" approach suggested in https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2 would be too big change at this point. Allow instances to surcharge the SameSite value for some specific domains if needed, by surcharging the ERP5Site_getAuthCookieSameSite script.
-
Vincent Pelletier authored
-
- 04 Feb, 2020 1 commit
-
-
Romain Courteaud authored
-
- 03 Feb, 2020 5 commits
-
-
Jérome Perrin authored
We want to render the next page after interaction workflows are executed.
-
Jérome Perrin authored
This uses a foo_interaction_workflow that sets a short title when title is set to a special value. We use it to check that when user set the title to that special value and save, next time the form is displayed, the values displayed are the ones after interaction workflow modified. This is a simple and a bit unrealistic scenario, but we have for example interaction workflows that update security definitions when some properties are modified, we want the next form to display the values after modifications. This is also the case of editions of portal components which sets the document to "modified" state and "re-validate" it at the end of transaction, unless pylint detects error.
-
Jérome Perrin authored
action added in a previous commit was removed, probably by mistake because only the metadata was removed.
-
Jérome Perrin authored
workflows were not sorted and some metadata files have an extra \n, probably because of manual edit
-
Jérome Perrin authored
This uses a different approach that what I was using in the past. I'm no longer trying to rename skins that does not match our naming conventions, but just adding them the the "ignore list". This would still allow to detect when new wrongly named scripts are introduced without risking regressions when we rename a script that was used from some places we did not change (like project customisations). /reviewed-on nexedi/erp5!1041
-
- 31 Jan, 2020 7 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This was a false positive
-