Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Gwenaël Samain
cython
Commits
9f7256fd
Commit
9f7256fd
authored
Jan 24, 2014
by
Vitja Makarov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
CF: reference doesn't mean it's not null
parent
12410403
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
6 deletions
+22
-6
Cython/Compiler/FlowControl.py
Cython/Compiler/FlowControl.py
+8
-6
tests/run/uninitialized.py
tests/run/uninitialized.py
+14
-0
No files found.
Cython/Compiler/FlowControl.py
View file @
9f7256fd
...
...
@@ -193,9 +193,11 @@ class ControlFlow(object):
def
mark_reference
(
self
,
node
,
entry
):
if
self
.
block
and
self
.
is_tracked
(
entry
):
self
.
block
.
stats
.
append
(
NameReference
(
node
,
entry
))
# Local variable is definitely bound after this reference
if
not
node
.
allow_null
:
self
.
block
.
bounded
.
add
(
entry
)
## XXX: We don't track expression evaluation order so we can't use
## XXX: successful reference as initialization sign.
## # Local variable is definitely bound after this reference
## if not node.allow_null:
## self.block.bounded.add(entry)
self
.
entries
.
add
(
entry
)
def
normalize
(
self
):
...
...
@@ -548,9 +550,9 @@ def check_definitions(flow, compiler_directives):
references
[
stat
.
node
]
=
stat
.
entry
stat
.
entry
.
cf_references
.
append
(
stat
)
stat
.
node
.
cf_state
.
update
(
state
)
if
not
stat
.
node
.
allow_null
:
i_state
&=
~
i_assmts
.
bit
# after successful read, the state is known to be initialised
##
if not stat.node.allow_null:
##
i_state &= ~i_assmts.bit
#
# #
after successful read, the state is known to be initialised
state
.
discard
(
Uninitialized
)
state
.
discard
(
Unknown
)
for
assmt
in
state
:
...
...
tests/run/uninitialized.py
View file @
9f7256fd
...
...
@@ -163,3 +163,17 @@ def test_try_finally_regression(c):
return
a
finally
:
return
a
def
test_expression_calculation_order_bug
(
a
):
"""
>>> test_expression_calculation_order_bug(False)
[]
>>> test_expression_calculation_order_bug(True)
Traceback (most recent call last):
...
UnboundLocalError: local variable 'b' referenced before assignment
"""
if
not
a
:
b
=
[]
return
(
a
or
b
)
and
(
b
or
a
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment