• Stan Hu's avatar
    Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark · 0fdfd2dd
    Stan Hu authored
    Here was the problem:
    
    1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
    2. If the blob is text, GitLab will attempt to display it.
    3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
    4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.
    
    To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
    an update to gitlab_git: gitlab-org/gitlab_git!86
    
    Closes #13826
    0fdfd2dd
To find the state of this project's repository at the time of any of these versions, check out the tags.
CHANGELOG 149 KB