Refactoring: get rid of ruby antipattern unless/else and use if/else instead

fed1c980 · Andrey Vakarev · f33cf247 · fed1c980
Commit fed1c980 authored May 20, 2012 by Andrey Vakarev
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

app/controllers/application_controller.rb app/controllers/application_controller.rb +3 -3

No files found.
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -97,12 +97,12 @@ class ApplicationController < ActionController::Base
  end
  def load_refs
-    unless params[:ref].blank?
+    if params[:ref].blank?
-      @ref = params[:ref]
-    else
      @branch = params[:branch].blank? ? nil : params[:branch]
      @tag = params[:tag].blank? ? nil : params[:tag]
      @ref = @branch || @tag || @project.try(:default_branch) || Repository.default_ref
+    else
+      @ref = params[:ref]
    end
  end