1. 17 Dec, 2015 27 commits
    • Yorick Peterse's avatar
      Allow filtering of what methods to instrument · 13dbd663
      Yorick Peterse authored
      This makes it possible to determine if a method should be instrumented
      or not using a block.
      13dbd663
    • Yorick Peterse's avatar
      Drop empty tag values from metrics · d67e2045
      Yorick Peterse authored
      InfluxDB throws an error when trying to store a list of tags where one
      or more have an empty value.
      d67e2045
    • Yorick Peterse's avatar
      Cast values to strings before escaping them · 5142c617
      Yorick Peterse authored
      This ensures that e.g. line numbers used in tags are first casted to
      strings.
      5142c617
    • Yorick Peterse's avatar
      Track location information as tags · 9f95ff0d
      Yorick Peterse authored
      This allows the information to be displayed when using certain functions
      (e.g. top()) as well as making it easier to aggregate on a per file
      basis.
      9f95ff0d
    • Yorick Peterse's avatar
      Added specs for MetricsWorker · d0352e66
      Yorick Peterse authored
      d0352e66
    • Yorick Peterse's avatar
      Replace double quotes when obfuscating SQL · f932b781
      Yorick Peterse authored
      InfluxDB escapes double quotes upon output which makes it a pain to deal
      with. This ensures that if we're using PostgreSQL we don't store any
      queries containing double quotes in InfluxDB, solving the escaping
      problem.
      f932b781
    • Yorick Peterse's avatar
      Track object count types as tags · 09a31156
      Yorick Peterse authored
      09a31156
    • Yorick Peterse's avatar
      Instrument Gitlab::Shel and Gitlab::Git · 6dc25ad5
      Yorick Peterse authored
      6dc25ad5
    • Yorick Peterse's avatar
      Only instrument methods defined directly · 641761f1
      Yorick Peterse authored
      When using instrument_methods/instrument_instance_methods we only want
      to instrument methods defined directly in a class, not those included
      via mixins (e.g. whatever RSpec throws in during development).
      
      In case an externally included method _has_ to be instrumented we can
      still use the regular instrument_method/instrument_instance_method
      methods.
      641761f1
    • Yorick Peterse's avatar
      Added Instrumentation.configure · f43f3b89
      Yorick Peterse authored
      This makes it easier to instrument multiple modules without having to
      type the full namespace over and over again.
      f43f3b89
    • Yorick Peterse's avatar
      Methods for instrumenting multiple methods · 5dbcb635
      Yorick Peterse authored
      The methods Instrumentation.instrument_methods and
      Instrumentation.instrument_instance_methods can be used to instrument
      all methods of a module at once.
      5dbcb635
    • Yorick Peterse's avatar
      Proper method instrumentation for special symbols · ad69ba57
      Yorick Peterse authored
      This ensures that methods such as "==" can be instrumented without
      producing syntax errors.
      ad69ba57
    • Yorick Peterse's avatar
      Use custom code for instrumenting method calls · 1b077d2d
      Yorick Peterse authored
      The use of ActiveSupport would slow down instrumented method calls by
      about 180x due to:
      
      1. ActiveSupport itself not being the fastest thing on the planet
      2. caller_locations() having quite some overhead
      
      The use of caller_locations() has been removed because it's not _that_
      useful since we already know the full namespace of receivers and the
      names of the called methods.
      
      The use of ActiveSupport has been replaced with some custom code that's
      generated using eval() (which can be quite a bit faster than using
      define_method).
      
      This new setup results in instrumented methods only being about 35-40x
      slower (compared to non instrumented methods).
      1b077d2d
    • Yorick Peterse's avatar
      Use string evaluation for method instrumentation · b66a16c8
      Yorick Peterse authored
      This is faster than using define_method since we don't have to keep
      block bindings around.
      b66a16c8
    • Yorick Peterse's avatar
      Improved last_relative_application_frame timings · 60a6a240
      Yorick Peterse authored
      The previous setup wasn't exactly fast, resulting in instrumented method
      calls taking about 600 times longer than non instrumented calls
      (including any ActiveSupport code involved). With this commit this
      slowdown has been reduced to around 185 times.
      60a6a240
    • Yorick Peterse's avatar
      Storing of application metrics in InfluxDB · 141e946c
      Yorick Peterse authored
      This adds the ability to write application metrics (e.g. SQL timings) to
      InfluxDB. These metrics can in turn be visualized using Grafana, or
      really anything else that can read from InfluxDB. These metrics can be
      used to track application performance over time, between different Ruby
      versions, different GitLab versions, etc.
      
      == Transaction Metrics
      
      Currently the following is tracked on a per transaction basis (a
      transaction is a Rails request or a single Sidekiq job):
      
      * Timings per query along with the raw (obfuscated) SQL and information
        about what file the query originated from.
      * Timings per view along with the path of the view and information about
        what file triggered the rendering process.
      * The duration of a request itself along with the controller/worker
        class and method name.
      * The duration of any instrumented method calls (more below).
      
      == Sampled Metrics
      
      Certain metrics can't be directly associated with a transaction. For
      example, a process' total memory usage is unrelated to any running
      transactions. While a transaction can result in the memory usage going
      up there's no accurate way to determine what transaction is to blame,
      this becomes especially problematic in multi-threaded environments.
      
      To solve this problem there's a separate thread that takes samples at a
      fixed interval. This thread (using the class Gitlab::Metrics::Sampler)
      currently tracks the following:
      
      * The process' total memory usage.
      * The number of file descriptors opened by the process.
      * The amount of Ruby objects (using ObjectSpace.count_objects).
      * GC statistics such as timings, heap slots, etc.
      
      The default/current interval is 15 seconds, any smaller interval might
      put too much pressure on InfluxDB (especially when running dozens of
      processes).
      
      == Method Instrumentation
      
      While currently not yet used methods can be instrumented to track how
      long they take to run. Unlike the likes of New Relic this doesn't
      require modifying the source code (e.g. including modules), it all
      happens from the outside. For example, to track `User.by_login` we'd add
      the following code somewhere in an initializer:
      
          Gitlab::Metrics::Instrumentation.
            instrument_method(User, :by_login)
      
      to instead instrument an instance method:
      
          Gitlab::Metrics::Instrumentation.
            instrument_instance_method(User, :save)
      
      Instrumentation for either all public model methods or a few crucial
      ones will be added in the near future, I simply haven't gotten to doing
      so just yet.
      
      == Configuration
      
      By default metrics are disabled. This means users don't have to bother
      setting anything up if they don't want to. Metrics can be enabled by
      editing one's gitlab.yml configuration file (see
      config/gitlab.yml.example for example settings).
      
      == Writing Data To InfluxDB
      
      Because InfluxDB is still a fairly young product I expect the worse.
      Data loss, unexpected reboots, the database not responding, you name it.
      Because of this data is _not_ written to InfluxDB directly, instead it's
      queued and processed by Sidekiq. This ensures that users won't notice
      anything when InfluxDB is giving trouble.
      
      The metrics worker can be started in a standalone manner as following:
      
          bundle exec sidekiq -q metrics
      
      The corresponding class is called MetricsWorker.
      141e946c
    • Robert Speicher's avatar
      Merge branch 'gitlab-workhorse-0.5.1' into 'master' · b2c593da
      Robert Speicher authored
      Use gitlab-workhorse 0.5.1
      
      Improves relative URL support.
      
      See merge request !2134
      b2c593da
    • Robert Speicher's avatar
      Merge branch 'issue_4131' into 'master' · 9da5f0b9
      Robert Speicher authored
      Upgrade Poltergeist to 1.8.1.
      
      Close #4131 
      
      See merge request !2126
      9da5f0b9
    • Jacob Vosmaer's avatar
      Use gitlab-workhorse 0.5.1 · b336eb01
      Jacob Vosmaer authored
      b336eb01
    • Kamil Trzciński's avatar
      Merge branch 'fix-migration' into 'master' · 110a5f9c
      Kamil Trzciński authored
      Fix ci_projects migration by using the value only from latest row [ci skip]
      
      This is needed, because for some projects we have duplicate ci_projects.
      This was introduced by lack of DB uniqueness on ci_projects.gitlab_id.
      
      The MR fixes edge case by selecting value from latest.
      
      /cc @yorickpeterse 
      
      Fixes: gitlab-org/gitlab-ce#4123
      
      
      See merge request !2133
      110a5f9c
    • Dmitriy Zaporozhets's avatar
      Merge branch 'revert-sidebar' into 'master' · 61a1bdd7
      Dmitriy Zaporozhets authored
      Revert sidebar position for issue and merge request
      Signed-off-by: default avatarDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
      
      cc @creamzy @skyruler 
      
      See merge request !2132
      61a1bdd7
    • Kamil Trzcinski's avatar
      Fix ci_projects migration by using the value only from latest row [ci skip] · e136a976
      Kamil Trzcinski authored
      This is needed, because for some projects we have duplicate ci_projects.
      This was introduced by lack of DB uniqueness on ci_projects.gitlab_id.
      e136a976
    • Dmitriy Zaporozhets's avatar
    • Dmitriy Zaporozhets's avatar
      Merge branch 'ux/closed-message' into 'master' · 8dc4c7b4
      Dmitriy Zaporozhets authored
      Fix ux issue with "This issue will be closed automatically" message
      
      1. Make a nice box for "issue will be closed automatically" message
      2. move it below emoji navbar. Otherwise looks wierd. 
      
      Fixes #4134 
      
      # Before
      ![Screenshot_2015-12-17_00.01.03](/uploads/2a24de77f76ce8a8b61ebabd3a02c83a/Screenshot_2015-12-17_00.01.03.png)
      
      # After
      
      ![Screenshot_2015-12-17_00.03.08](/uploads/ccd21b87b7509e79773fabd179bef4aa/Screenshot_2015-12-17_00.03.08.png)
      Signed-off-by: default avatarDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
      
      See merge request !2129
      8dc4c7b4
    • Achilleas Pipinellis's avatar
      Merge branch 'doc_private_registry' into 'master' · be52c5d2
      Achilleas Pipinellis authored
      Add info on using private Docker registries in CI
      
      
      
      See merge request !2130
      be52c5d2
    • Achilleas Pipinellis's avatar
    • Rubén Dávila's avatar
      Upgrade Poltergeist to 1.8.1. #4131 · a4e0c7c7
      Rubén Dávila authored
      a4e0c7c7
  2. 16 Dec, 2015 13 commits