- 17 Dec, 2015 31 commits
-
-
Yorick Peterse authored
This allows us to track the counts of actual classes instead of "T_XXX" nodes. This is only enabled on CRuby as it uses CRuby specific APIs.
-
Yorick Peterse authored
This works by searching the raw source code for any references to commonly used ActiveRecord methods. While not bulletproof it saves us from having to list hundreds of methods by hand. It also ensures that (most) newly added methods are instrumented automatically. This _only_ instruments models defined in app/models, should a model reside somewhere else (e.g. somewhere in lib/) it _won't_ be instrumented.
-
Yorick Peterse authored
This will be used to (for example) instrument all ActiveRecord models.
-
Yorick Peterse authored
This ensures we don't end up wasting resources by tracking method calls that only take a few microseconds. By default the threshold is 10 milliseconds but this can be changed using the gitlab.yml configuration file.
-
Yorick Peterse authored
This makes it possible to determine if a method should be instrumented or not using a block.
-
Yorick Peterse authored
InfluxDB throws an error when trying to store a list of tags where one or more have an empty value.
-
Yorick Peterse authored
This ensures that e.g. line numbers used in tags are first casted to strings.
-
Yorick Peterse authored
This allows the information to be displayed when using certain functions (e.g. top()) as well as making it easier to aggregate on a per file basis.
-
Yorick Peterse authored
-
Yorick Peterse authored
InfluxDB escapes double quotes upon output which makes it a pain to deal with. This ensures that if we're using PostgreSQL we don't store any queries containing double quotes in InfluxDB, solving the escaping problem.
-
Yorick Peterse authored
-
Yorick Peterse authored
-
Yorick Peterse authored
When using instrument_methods/instrument_instance_methods we only want to instrument methods defined directly in a class, not those included via mixins (e.g. whatever RSpec throws in during development). In case an externally included method _has_ to be instrumented we can still use the regular instrument_method/instrument_instance_method methods.
-
Yorick Peterse authored
This makes it easier to instrument multiple modules without having to type the full namespace over and over again.
-
Yorick Peterse authored
The methods Instrumentation.instrument_methods and Instrumentation.instrument_instance_methods can be used to instrument all methods of a module at once.
-
Yorick Peterse authored
This ensures that methods such as "==" can be instrumented without producing syntax errors.
-
Yorick Peterse authored
The use of ActiveSupport would slow down instrumented method calls by about 180x due to: 1. ActiveSupport itself not being the fastest thing on the planet 2. caller_locations() having quite some overhead The use of caller_locations() has been removed because it's not _that_ useful since we already know the full namespace of receivers and the names of the called methods. The use of ActiveSupport has been replaced with some custom code that's generated using eval() (which can be quite a bit faster than using define_method). This new setup results in instrumented methods only being about 35-40x slower (compared to non instrumented methods).
-
Yorick Peterse authored
This is faster than using define_method since we don't have to keep block bindings around.
-
Yorick Peterse authored
The previous setup wasn't exactly fast, resulting in instrumented method calls taking about 600 times longer than non instrumented calls (including any ActiveSupport code involved). With this commit this slowdown has been reduced to around 185 times.
-
Yorick Peterse authored
This adds the ability to write application metrics (e.g. SQL timings) to InfluxDB. These metrics can in turn be visualized using Grafana, or really anything else that can read from InfluxDB. These metrics can be used to track application performance over time, between different Ruby versions, different GitLab versions, etc. == Transaction Metrics Currently the following is tracked on a per transaction basis (a transaction is a Rails request or a single Sidekiq job): * Timings per query along with the raw (obfuscated) SQL and information about what file the query originated from. * Timings per view along with the path of the view and information about what file triggered the rendering process. * The duration of a request itself along with the controller/worker class and method name. * The duration of any instrumented method calls (more below). == Sampled Metrics Certain metrics can't be directly associated with a transaction. For example, a process' total memory usage is unrelated to any running transactions. While a transaction can result in the memory usage going up there's no accurate way to determine what transaction is to blame, this becomes especially problematic in multi-threaded environments. To solve this problem there's a separate thread that takes samples at a fixed interval. This thread (using the class Gitlab::Metrics::Sampler) currently tracks the following: * The process' total memory usage. * The number of file descriptors opened by the process. * The amount of Ruby objects (using ObjectSpace.count_objects). * GC statistics such as timings, heap slots, etc. The default/current interval is 15 seconds, any smaller interval might put too much pressure on InfluxDB (especially when running dozens of processes). == Method Instrumentation While currently not yet used methods can be instrumented to track how long they take to run. Unlike the likes of New Relic this doesn't require modifying the source code (e.g. including modules), it all happens from the outside. For example, to track `User.by_login` we'd add the following code somewhere in an initializer: Gitlab::Metrics::Instrumentation. instrument_method(User, :by_login) to instead instrument an instance method: Gitlab::Metrics::Instrumentation. instrument_instance_method(User, :save) Instrumentation for either all public model methods or a few crucial ones will be added in the near future, I simply haven't gotten to doing so just yet. == Configuration By default metrics are disabled. This means users don't have to bother setting anything up if they don't want to. Metrics can be enabled by editing one's gitlab.yml configuration file (see config/gitlab.yml.example for example settings). == Writing Data To InfluxDB Because InfluxDB is still a fairly young product I expect the worse. Data loss, unexpected reboots, the database not responding, you name it. Because of this data is _not_ written to InfluxDB directly, instead it's queued and processed by Sidekiq. This ensures that users won't notice anything when InfluxDB is giving trouble. The metrics worker can be started in a standalone manner as following: bundle exec sidekiq -q metrics The corresponding class is called MetricsWorker.
-
Robert Speicher authored
Use gitlab-workhorse 0.5.1 Improves relative URL support. See merge request !2134
-
Robert Speicher authored
Upgrade Poltergeist to 1.8.1. Close #4131 See merge request !2126
-
Jacob Vosmaer authored
-
Kamil Trzciński authored
Fix ci_projects migration by using the value only from latest row [ci skip] This is needed, because for some projects we have duplicate ci_projects. This was introduced by lack of DB uniqueness on ci_projects.gitlab_id. The MR fixes edge case by selecting value from latest. /cc @yorickpeterse Fixes: gitlab-org/gitlab-ce#4123 See merge request !2133
-
Dmitriy Zaporozhets authored
Revert sidebar position for issue and merge request Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @creamzy @skyruler See merge request !2132
-
Kamil Trzcinski authored
This is needed, because for some projects we have duplicate ci_projects. This was introduced by lack of DB uniqueness on ci_projects.gitlab_id.
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Fix ux issue with "This issue will be closed automatically" message 1. Make a nice box for "issue will be closed automatically" message 2. move it below emoji navbar. Otherwise looks wierd. Fixes #4134 # Before ![Screenshot_2015-12-17_00.01.03](/uploads/2a24de77f76ce8a8b61ebabd3a02c83a/Screenshot_2015-12-17_00.01.03.png) # After ![Screenshot_2015-12-17_00.03.08](/uploads/ccd21b87b7509e79773fabd179bef4aa/Screenshot_2015-12-17_00.03.08.png) Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !2129
-
Achilleas Pipinellis authored
Add info on using private Docker registries in CI See merge request !2130
-
Achilleas Pipinellis authored
-
Rubén Dávila authored
-
- 16 Dec, 2015 9 commits
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Api support for requesting starred projects for user Closes #4112 Note: probably targets the wrong release in the `CHANGELOG`, though 8.4 was not there yet See merge request !2127
-
Dmitriy Zaporozhets authored
Move MR Builds tab next to Commits Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/4132 @dzaporozhets We've got two people who feel strongly about this now, @sytses filed an issue for it :) ![Screen_Shot_2015-12-16_at_22.19.35](/uploads/37e705610ba54e386928d7972398c247/Screen_Shot_2015-12-16_at_22.19.35.png) See merge request !2128
-
Robert Speicher authored
Fix updating and disabling merge button when Merge Immediately is clicked Fixes #4128 See merge request !2124
-
Robert Speicher authored
Fix Rubocop complain. See merge request !2125
-
Douwe Maan authored
-
Zeger-Jan van de Weg authored
Fixes #4112
-
Rubén Dávila authored
-
Achilleas Pipinellis authored
Clean up ci yaml doc * Fix headings so that they are picked up by doc.gitlab.com * Stick to 80 characters * Clean up some examples See merge request !2052
-