Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-shell
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
iv
gitlab-shell
Commits
ca66ab51
Commit
ca66ab51
authored
Nov 25, 2015
by
Jacob Vosmaer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add spec for stricter exec_cmd checks
parent
712daa41
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
0 deletions
+9
-0
spec/gitlab_shell_spec.rb
spec/gitlab_shell_spec.rb
+9
-0
No files found.
spec/gitlab_shell_spec.rb
View file @
ca66ab51
...
@@ -236,6 +236,15 @@ describe GitlabShell do
...
@@ -236,6 +236,15 @@ describe GitlabShell do
Kernel
.
should_receive
(
:exec
).
with
(
kind_of
(
Hash
),
1
,
2
,
unsetenv_others:
true
).
once
Kernel
.
should_receive
(
:exec
).
with
(
kind_of
(
Hash
),
1
,
2
,
unsetenv_others:
true
).
once
shell
.
send
:exec_cmd
,
1
,
2
shell
.
send
:exec_cmd
,
1
,
2
end
end
it
"refuses to execute a lone non-array argument"
do
expect
{
shell
.
send
:exec_cmd
,
1
}.
to
raise_error
(
GitlabShell
::
DisallowedCommandError
)
end
it
"allows one argument if it is an array"
do
Kernel
.
should_receive
(
:exec
).
with
(
kind_of
(
Hash
),
[
1
,
2
],
unsetenv_others:
true
).
once
shell
.
send
:exec_cmd
,
[
1
,
2
]
end
end
end
describe
:api
do
describe
:api
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment