officejs_support_request_ui: prevent submitting comment twice [WIP]

bt5/erp5_officejs_support_request_ui/PathTemplateItem/web_page_module/gadget_supportrequest_pt_form_view_discussable_js.js

@@ -218,8 +218,11 @@
 
           submitButton = gadget.element.querySelector("input[type=submit]");
           submitButton.disabled = true;
+          submitButton.classList.add("ui-disabled");
+
           function enableSubmitButton() {
             submitButton.disabled = false;
+            submitButton.classList.remove("ui-disabled");
           }
           queue = gadget.notifySubmitted({message: "Posting comment"})
             .push(function () {
@@ -231,6 +234,10 @@
               data.append("predecessor", '');
               data.append("data", content.comment);
               data.append("file", file_blob);
+
+              // reset the file upload, otherwise next comment would upload same file again
+              choose_file_html_element.value = "";
+
               // XXX: Hack, call jIO.util.ajax directly to pass the file blob
               // Because the jio_putAttachment will call readBlobAsText, which
               // will broke the binary file. Call the jIO.util.ajax directly
@@ -248,12 +255,17 @@
               return gadget.notifySubmitted({message: "Comment added", status: "success"});
             })
             .push(function () {
-              editor.changeState({value: ''})
-                .push(function () {
-                  return gadget.redirect({command: 'reload'});
-                });
-            });
-          queue.push(enableSubmitButton, enableSubmitButton);
+              // XXX workaround ... because previous state before user start typing was ""
+              // we first set to "something" to be able to reset to nothing later.
+              return editor.changeState({value: ' '});
+            })
+            .push(function () {
+              return editor.changeState({value: ''});
+            })
+            .push(function () {
+              return gadget.redirect({command: 'reload'});
+            })
+            .push(enableSubmitButton, enableSubmitButton);
           return queue;
         });
     })

bt5/erp5_officejs_support_request_ui/PathTemplateItem/web_page_module/gadget_supportrequest_pt_form_view_discussable_js.xml

@@ -252,7 +252,7 @@
                     </tuple>
                     <state>
                       <tuple>
-                        <float>1539939405.65</float>
+                        <float>1539946621.33</float>
                         <string>GMT+9</string>
                       </tuple>
                     </state>

[Jérome Perrin]

HTML5 spec for file input says

The value IDL attribute is in mode filename.

which means:

.. On setting, if the new value is the empty string, empty the list of selected files; ...

so it should be OK, but I'm a bit worried that some browser may cause a security error if we change the value of a file input

[Jérome Perrin]

I wish this was not necessary. If I understood correctly, the value state of the editor is set to "" on initialization and then never changed, in editor gadget, we don't do anything like

editor.on("change", function() {
  gadget.changeState({
     value: editor.value
   })})

so the state of the gadget is always empty string, so this changeState({value: ''}) was always resolving immediately, so user was able to submit again the same content.

@romain if you understand this and you have comment, it would be appreciated.

[Romain Courteaud]

@jerome the value state parameter is modified by ckeditor getContent method. As the editor gadget always calls ckeditor render, I don't see why your change is needed for now.

[Jérome Perrin]

Thanks ! ... so it's should not be needed.

My guess is that it's because ckeditor gadget modifies its state, but it's wrapped in an editor gadget whose state is not modified on getContent. I'll investigate this more and I'll let you know.