officejs_support_request_ui: prevent submitting comment twice [WIP]

bt5/erp5_officejs_support_request_ui/PathTemplateItem/web_page_module/gadget_supportrequest_pt_form_view_discussable_js.js

@@ -218,8 +218,11 @@
 
           submitButton = gadget.element.querySelector("input[type=submit]");
           submitButton.disabled = true;
+          submitButton.classList.add("ui-disabled");
+
           function enableSubmitButton() {
             submitButton.disabled = false;
+            submitButton.classList.remove("ui-disabled");
           }
           queue = gadget.notifySubmitted({message: "Posting comment"})
             .push(function () {
@@ -231,6 +234,10 @@
               data.append("predecessor", '');
               data.append("data", content.comment);
               data.append("file", file_blob);
+
+              // reset the file upload, otherwise next comment would upload same file again
+              choose_file_html_element.value = "";
+
               // XXX: Hack, call jIO.util.ajax directly to pass the file blob
               // Because the jio_putAttachment will call readBlobAsText, which
               // will broke the binary file. Call the jIO.util.ajax directly
@@ -248,12 +255,17 @@
               return gadget.notifySubmitted({message: "Comment added", status: "success"});
             })
             .push(function () {
-              editor.changeState({value: ''})
+              // XXX workaround ... because previous state before user start typing was ""
+              // we first set to "something" to be able to reset to nothing later.
+              return editor.changeState({value: ' '});
+            })
+            .push(function () {
+              return editor.changeState({value: ''});
+            })
             .push(function () {
               return gadget.redirect({command: 'reload'});
-                });
-            });
-          queue.push(enableSubmitButton, enableSubmitButton);
+            })
+            .push(enableSubmitButton, enableSubmitButton);
           return queue;
         });
     })

bt5/erp5_officejs_support_request_ui/PathTemplateItem/web_page_module/gadget_supportrequest_pt_form_view_discussable_js.xml

@@ -252,7 +252,7 @@
                     </tuple>
                     <state>
                       <tuple>
-                        <float>1539939405.65</float>
+                        <float>1539946621.33</float>
                         <string>GMT+9</string>
                       </tuple>
                     </state>

[Jérome Perrin]

HTML5 spec for file input says

The value IDL attribute is in mode filename.

which means:

.. On setting, if the new value is the empty string, empty the list of selected files; ...

so it should be OK, but I'm a bit worried that some browser may cause a security error if we change the value of a file input