1. 19 Sep, 2018 2 commits
  2. 18 Sep, 2018 8 commits
  3. 17 Sep, 2018 18 commits
  4. 15 Sep, 2018 1 commit
    • Julien Muchembled's avatar
      Revert "Folder: call activate on the object instead of... · 1cd37609
      Julien Muchembled authored
      Revert "Folder: call activate on the object instead of portal_activities.activateObject in _recurseCallMethod()."
      
      This reverts commits 3d3ec3cb ((+ fixup), which
      broke recursion to objects that don't inherit ActiveObject, as explained in the
      docstring.
      
      I also think it was wrong in that default activate parameters disappear at the
      end of the transaction whereas _recurseCallMethod may activate itself to avoid
      creating to many activities at once. IOW, it's important that created
      activities are the same no matter where _recurseCallMethod splits the browsing.
      
      This change needed more review, as well as a unit test.
      1cd37609
  5. 14 Sep, 2018 6 commits
  6. 13 Sep, 2018 3 commits
  7. 12 Sep, 2018 2 commits
    • Vincent Pelletier's avatar
      erp5_administration: Stop using getObject. · 920655a2
      Vincent Pelletier authored
      Also, why make only 2 queries when I can make 2n+1 queries for the same
      result ?
      920655a2
    • Vincent Pelletier's avatar
      SQLCatalog_deferFullTextIndex{,Activity}: Do not use getObject . · da7e0f0b
      Vincent Pelletier authored
      getObject is generally a shortcut for "return self", and on brains for
      traversing to corresponding document.
      Except... Not everywhere. portal_catalog for example defines a completely
      unrelated method which takes a UID as argument and does a query retrieving
      one document. Which is basically totally redundant with its __call__
      method. Still, of course, it is used in several places.
      Also, ERP5Form.Report defines yet another getObject method, taking an
      acquisition context as argument and traversing to some other path.
      
      So do not use getObject (at least until the code recovers some sanity and
      consistency), but getPath + custom activity API. Oh well.
      da7e0f0b