- 13 Nov, 2018 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Listbox number of lines is not `limit` ... it's `list_lines` Also add the missing test that should have discovered this earlier.
-
Jérome Perrin authored
* Make it obvious that this script works with catalog brains and does not want to call getObject * Make two queries, one to get the "latest" support requests (by date) and another one to get the "current" (by state), making one big query will return too many results when the number of SR grow * backend directly returns the data in the format expected by graph library.
-
- 05 Nov, 2018 1 commit
-
-
Jérome Perrin authored
This reverts commit 5b251ce6.
-
- 02 Nov, 2018 3 commits
-
-
Yusei Tahara authored
-
Jérome Perrin authored
* Problems with data migration ( some events had no source, the logic of using current user was anyway wrong ) * Problems with security * RSS too small ( see commits for details ) /reviewed-on nexedi/erp5!792
-
Jérome Perrin authored
.pop .popitem and .setdefault where returning None /reviewed-on nexedi/erp5!791
-
- 01 Nov, 2018 8 commits
-
-
Jérome Perrin authored
Security might be configured in a way that even if user can see the support request he cannot see all events related to that support request. We should handle this case by filtering out the event and not letting Unauthorized error happen.
-
Jérome Perrin authored
There was an issue that RSS was failing with Unauthorized errors when there was some events users cannot access. (once again, thank you zope security, it was not leaking information just causing error)
-
Jérome Perrin authored
default of 5 is not enough and must have caused people to miss messages ( when more than 5 messages are posted between 2 refreshes from their RSS reader)
-
Arnaud Fontaine authored
Project use case: Use modification_date instead of operation_date to export ATs modified the day before.
-
Arnaud Fontaine authored
erp5_accounting_l10n_fr: Allow to pass additional Catalog parameters to select Accounting Transaction to FEC export. Introduced for customer Unit Tests to be able to FEC export only ATs of the current Unit Test FEC based on 'title'.
-
Arnaud Fontaine authored
Called by TransformationSimulationRule and did not work with the following use case: BL(trade_phase=TP1, successor=trade_state/TS1): * child_BL1(predecessor=trade_state/TS1, trade_phase=TP1/InventoryAccounting) * child_BL2(predecessor=trade_state/TS1, trade_phase=Transforming)
-
Jérome Perrin authored
.. not the current logged in user. This way, it's possible to run the post ingestion as another user, for example running by an alarm or as a data migration.
-
Yusei Tahara authored
bt5/erp5_scalability_test: Remove a Permission Configurator Item. It depends on standard_module_permission_access.ods, but it was already removed from erp5_configurator_standard skin folder.
-
- 31 Oct, 2018 6 commits
-
-
Tristan Cavelier authored
in accounting_module and sale_order_module listbox. The "Sale Trade Condition" column was showing first found specialise title instead of the Sale Trade Condition one. This adds z_related_specialise_trade_condition with related key specialise_trade_condition_title and an accessor getSpecialiseTradeConditionTitle
-
Jérome Perrin authored
We edited the HTML, but did not include the accompanying increase of modification date. See nexedi/erp5!662 (comment 65953) for more on this issue. /reviewed-on nexedi/erp5!790
-
Tristan Cavelier authored
When a workflow transition was not used by any state, calling some_module.Module_listWorkflowTransitionItemList was raising: [..] Module script, line 49, in Module_listWorkflowTransitionItemList - <PythonScript at /tsxx/Module_listWorkflowTransitionItemList used for /tsxx/some_module> - Line 49 result['listbox_parameter_dict'][transition_id] = [(state_variable, allowed_state_dict[transition_id])] Module AccessControl.ZopeGuards, line 83, in guarded_getitem v = object[index] KeyError: 'some_action' Now, pick transition among the allowed_state_dict instead of workflow.transitions. This also fixes mass change state dialog "??? ()" issue. This commit adds a transition that allows to reproduce that issue. And this line covers the case : bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_zuite/testMassWorkflowTransition.zpt (line 61) /reviewed-on !788
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
Some things in support request app where working apparently a bit by chance and they no longer work with new erp5_hal_json ( 09d00cae ) This aims at using erp5_hal_json as intended and simplifying the customisations by customising "only" the header gadget and not the page gadget. /reviewed-on nexedi/erp5!787
-
- 30 Oct, 2018 12 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
erp5_real_time_inventory_accounting: Accounting Transaction state should be 'Posted to General Ledger' (stopped), not draft.
-
Jérome Perrin authored
erp5_hal_json does not seem to allow using gadgets by page name, anymore, so instead of using a custom "page template" gadget ( disclaimer: I have not really understood this fully at this point). Instead of using a custom page gadget, just use a header gadget that "extends" the default gadget but removes the add_url
-
Jérome Perrin authored
Because the fast input should be used. Also simplify a bit the test, there's no need to add a SR in this case.
-
Jérome Perrin authored
This reverts commit 463855b6. unlike RSVP.all, RSVP.hash is not patched to support cancellation, so it's not safe to use it at the moment.
-
Arnaud Fontaine authored
Such as: - getStartTransitionDateList() and getStartTransitionDate(). - getDeliverTransitionDateList() and getDeliveryTransitionDate(). - ... Where the non-List accessors returned the last element. Use Case: Set AT.{start,stop}_date from PPL stop transition date.
-
- 29 Oct, 2018 4 commits
-
-
Arnaud Fontaine authored
Until this commit, loading a ZODB Component would add it to the current Request object to prevent its reference counter reaching 0 (thus its global being reset to None and then being later GC'ed) when a reset happens in another Request. This problem was found when investigating testFunctionalConfigurator failure when installing bt5s as requested by the Configurator: 1. Request R1 calls Zuite_waitForActivities importing extension.erp5.ERP5Zuite (M1). => Add M1 to R1._module_cache_set. => M1 ref counter equals to 2 (sys.modules and R1._module_cache_set references). 2. R1 terminates and is GC'ed. => M1 ref counter equals to 1 (sys.modules). 3. Request R2 runs Configurator configuring the Site. 4. testFunctionalConfigurator calls Zuite_waitForActivities to wait for the Configurator to finish (request R3 which may take ~15 minutes). This calls time.sleep() in a loop where 'time' module is imported at top-level. 5. R2 installs bt5 triggering reset. => M1 ref counter equals to 0. ===> M1 global variables are reset to None and thus 'time' is set to None raising an Exception in the next call of time.sleep() in the loop. The easiest way would be to have a hook on sys.modules dict lookup and thus add M1 to R2._module_cache_set when being imported, but this is not supported... Instead create a global cache on erp5.component package.
-
Jérome Perrin authored
There is no action with referecne `list` on support request module.
-
Jérome Perrin authored
-
Vincent Pelletier authored
This test alone does not define site-dependent security groups, so this change is not required as such. But in real configuration, ERP5 instance define security groups, which sometimes (often ?) depend on which site a document or user is linked to. When multiple groups apply (ex: having a certain function at a certain site), the final group is composed by joining group identifiers using underscores. This forbids using underscores in group identifiers. And group identifiers are generated from document's (here, the Category) codification if set, otherwise the reference if set, otherwise the document identifier. So set a underscore-less codification on these categories so this test can be run on tests where security is configured to include site in security groups.
-
- 26 Oct, 2018 3 commits
-
-
Georgios Dagkakis authored
as the comment (which is removed now) said: ``` XXX: This method is broken, since "total_size" field is not present in the listbox rendering any longer. It should be removed. ``` Also: - make sure that Listbox always knows how many lines are to be displayed. - add testPagerWithCustomListMethod in listbox_zuite of erp5_ui_test, which checks that listbox jumping to previous/next/first/last works correctly for a list method that returns only the elements that the listbox is to render. /reviewed-on nexedi/erp5!776
-
Jérome Perrin authored
Default method seem to work just fine and is compatible with the recent improvements in erp5_hal_jon_style ( 09d00cae )
-
Vincent Pelletier authored
set.__iadd__ does not like non-set values, but the intent of this API is to allow just any iterable (producing strings) to be returned, so use the more tolerant set.update method instead.
-