- 21 Sep, 2018 1 commit
-
-
Jérome Perrin authored
otherwise it's not executed when test has an error. We should consider using mock library here.
-
- 20 Sep, 2018 7 commits
-
-
Ayush Tiwari authored
DiffTool: removePropertyList function should be working same for both ERP5 object and dictionaries of ERP5 object properties Before we use to neglect removing some properties from ERP5 object properties' dict, which led to error in case of use of DiffTool for Historical Revisions dict. Thus, its important for removeProperties function to act similar in both cases. Also, add `base_data` in attribute_set to be removed because `data`, `base_data` and `text_content` are same
-
Ayush Tiwari authored
This is essential to have better aesthetic of Deepdiff diff for tuples. In general, we treat iterables as long string so as to bypass the complicated diff for iterables provided by DeepDiff, but for tuples this was creating a problem as it was not possible to understand the diff properly. Hence, by soting them, we get more understandable diff for tuples. Also, there is no need to override `__diff_tuple` function as it is itself dependent on `__diff_iterable` which we already override.
-
Ayush Tiwari authored
Following convention, it makes more sense to use view mode for DiffTool view. Also, we don't need selection as of now. Also, update the tests
-
Ayush Tiwari authored
View wise, the date and path for new version/obvject should be on right side which in our case is `your_second_date`. Thus, the case where we run diff action on single object, the right side should show the current version and the left side shoule show the last version.
-
Richard authored
/reviewed-on nexedi/erp5!741
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!748
-
Yusei Tahara authored
-
- 19 Sep, 2018 1 commit
-
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!739
-
- 18 Sep, 2018 8 commits
-
-
Vincent Pelletier authored
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!740
-
Jérome Perrin authored
zope.conf default encoding is also used for responses and converters, so for consistency we should also force default encoding there. This is especially useful when running tests, because zope.conf is not used and default values are used.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
https://tools.ietf.org/html/rfc4329#section-7 states that text/javascript is obsolete. Doesn't really matter in the end because WebPage_viewAsWeb forces the content type.
-
Jérome Perrin authored
In HTTP/1.1 , when not specified , charset detault to ISO-8859-1 https://tools.ietf.org/html/rfc2616#section-3.7.1 > media subtypes of the "text" type are defined to have a default charset value of "ISO-8859-1" when received via HTTP Zope adds a charset with default encoding ( https://github.com/zopefoundation/Zope/blob/2.13/src/ZPublisher/HTTPResponse.py#L512-L515 ) but does this only for text/ type, but we serve our javascript as application/javascript
-
Jérome Perrin authored
-
- 17 Sep, 2018 18 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
Correctly handle multiple interface declarations Reduce DOM modification. Load gadget in an iframe to improve isolation Delay gadget creation to prevent creating hundred of iframes in parallel, which slow down the browser
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Prevent submitting the form if the relation field contains an unknown search string.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Sven Franck authored
-
Sven Franck authored
-
Sven Franck authored
-
Vincent Pelletier authored
_reindexOnCreation API does not expect an expanded activate_kw, but really only an expanded reindex_kw - which may contain its own activate_kw, over which our activate_kw is supposed to take precedence (see Products.ERP5Type.Base.Base._getReindexAndActivateParameterDict). It's all so easy !
-
Vincent Pelletier authored
activate_kw was not honored in immediate indexation code path.
-
Vincent Pelletier authored
Also, tix typo in comment.
-
- 15 Sep, 2018 1 commit
-
-
Julien Muchembled authored
Revert "Folder: call activate on the object instead of portal_activities.activateObject in _recurseCallMethod()." This reverts commits 3d3ec3cb ((+ fixup), which broke recursion to objects that don't inherit ActiveObject, as explained in the docstring. I also think it was wrong in that default activate parameters disappear at the end of the transaction whereas _recurseCallMethod may activate itself to avoid creating to many activities at once. IOW, it's important that created activities are the same no matter where _recurseCallMethod splits the browsing. This change needed more review, as well as a unit test.
-
- 14 Sep, 2018 4 commits
-
-
Sebastien Robin authored
-
Kazuhiko Shiozaki authored
Folder: call activate on the object instead of portal_activities.activateObject in _recurseCallMethod(). so that activate_kw set on the object is respected.
-
Łukasz Nowak authored
The site shall be used with default BT5s.
-
Łukasz Nowak authored
Previous field names came from obsoleted erp5_core_proxy_field_legacy
-