user_spec.rb 24.4 KB
Newer Older
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1 2 3 4
# == Schema Information
#
# Table name: users
#
Stan Hu's avatar
Stan Hu committed
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
#  id                         :integer          not null, primary key
#  email                      :string(255)      default(""), not null
#  encrypted_password         :string(255)      default(""), not null
#  reset_password_token       :string(255)
#  reset_password_sent_at     :datetime
#  remember_created_at        :datetime
#  sign_in_count              :integer          default(0)
#  current_sign_in_at         :datetime
#  last_sign_in_at            :datetime
#  current_sign_in_ip         :string(255)
#  last_sign_in_ip            :string(255)
#  created_at                 :datetime
#  updated_at                 :datetime
#  name                       :string(255)
#  admin                      :boolean          default(FALSE), not null
#  projects_limit             :integer          default(10)
#  skype                      :string(255)      default(""), not null
#  linkedin                   :string(255)      default(""), not null
#  twitter                    :string(255)      default(""), not null
#  authentication_token       :string(255)
#  theme_id                   :integer          default(1), not null
#  bio                        :string(255)
#  failed_attempts            :integer          default(0)
#  locked_at                  :datetime
#  username                   :string(255)
#  can_create_group           :boolean          default(TRUE), not null
#  can_create_team            :boolean          default(TRUE), not null
#  state                      :string(255)
#  color_scheme_id            :integer          default(1), not null
#  notification_level         :integer          default(1), not null
#  password_expires_at        :datetime
#  created_by_id              :integer
#  last_credential_check_at   :datetime
#  avatar                     :string(255)
#  confirmation_token         :string(255)
#  confirmed_at               :datetime
#  confirmation_sent_at       :datetime
#  unconfirmed_email          :string(255)
#  hide_no_ssh_key            :boolean          default(FALSE)
#  website_url                :string(255)      default(""), not null
#  notification_email         :string(255)
#  hide_no_password           :boolean          default(FALSE)
#  password_automatically_set :boolean          default(FALSE)
#  location                   :string(255)
#  encrypted_otp_secret       :string(255)
#  encrypted_otp_secret_iv    :string(255)
#  encrypted_otp_secret_salt  :string(255)
#  otp_required_for_login     :boolean          default(FALSE), not null
#  otp_backup_codes           :text
#  public_email               :string(255)      default(""), not null
#  dashboard                  :integer          default(0)
#  project_view               :integer          default(0)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
57 58
#

gitlabhq's avatar
gitlabhq committed
59 60 61
require 'spec_helper'

describe User do
62 63
  include Gitlab::CurrentSettings

64 65 66 67 68 69 70 71 72 73 74
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

  describe 'associations' do
75 76 77 78 79 80 81 82 83 84 85 86 87
    it { is_expected.to have_one(:namespace) }
    it { is_expected.to have_many(:snippets).class_name('Snippet').dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
    it { is_expected.to have_many(:events).class_name('Event').dependent(:destroy) }
    it { is_expected.to have_many(:recent_events).class_name('Event') }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_issues).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
88 89 90
  end

  describe 'validations' do
91 92 93 94 95
    it { is_expected.to validate_presence_of(:username) }
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
96

97
    it { is_expected.to validate_length_of(:bio).is_within(0..255) }
98 99 100 101 102 103

    describe 'email' do
      it 'accepts info@example.com' do
        user = build(:user, email: 'info@example.com')
        expect(user).to be_valid
      end
104

105 106 107 108 109
      it 'accepts info+test@example.com' do
        user = build(:user, email: 'info+test@example.com')
        expect(user).to be_valid
      end

110 111 112 113 114
      it "accepts o'reilly@example.com" do
        user = build(:user, email: "o'reilly@example.com")
        expect(user).to be_valid
      end

115 116 117 118 119 120 121 122 123
      it 'rejects test@test@example.com' do
        user = build(:user, email: 'test@test@example.com')
        expect(user).to be_invalid
      end

      it 'rejects mailto:test@example.com' do
        user = build(:user, email: 'mailto:test@example.com')
        expect(user).to be_invalid
      end
124 125 126 127 128

      it "rejects lol!'+=?><#$%^&*()@gmail.com" do
        user = build(:user, email: "lol!'+=?><#$%^&*()@gmail.com")
        expect(user).to be_invalid
      end
129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173

      context 'when no signup domains listed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return([]) }
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

      context 'when a signup domain is listed and subdomains are allowed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return(['example.com', '*.example.com']) }
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

      context 'when a signup domain is listed and subdomains are not allowed' do
        before { allow(current_application_settings).to receive(:restricted_signup_domains).and_return(['example.com']) }

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end
174
    end
gitlabhq's avatar
gitlabhq committed
175 176 177
  end

  describe "Respond to" do
178 179 180
    it { is_expected.to respond_to(:is_admin?) }
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
gitlabhq's avatar
gitlabhq committed
181 182
  end

183 184 185 186 187 188 189 190 191 192 193 194 195
  describe '#confirm' do
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
      user.confirm!
      expect(user.confirmed?).to be_truthy
    end
  end

196 197 198 199 200 201 202 203
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

204 205 206
  describe '#generate_password' do
    it "should execute callback when force_random_password specified" do
      user = build(:user, force_random_password: true)
207
      expect(user).to receive(:generate_password)
208 209 210 211
      user.save
    end

    it "should not generate password by default" do
212
      user = create(:user, password: 'abcdefghe')
213
      expect(user.password).to eq('abcdefghe')
214
    end
215

216
    it "should generate password when forcing random password" do
217
      allow(Devise).to receive(:friendly_token).and_return('123456789')
218
      user = create(:user, password: 'abcdefg', force_random_password: true)
219
      expect(user.password).to eq('12345678')
220
    end
221 222
  end

223 224
  describe 'authentication token' do
    it "should have authentication token" do
225
      user = create(:user)
226
      expect(user.authentication_token).not_to be_blank
227
    end
Nihad Abbasov's avatar
Nihad Abbasov committed
228
  end
229

230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
    end
  end

248 249 250 251
  describe 'projects' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
252 253
      @project_2 = create :project, group: create(:group) # Grant MASTER access to the user
      @project_3 = create :project, group: create(:group) # Grant DEVELOPER access to the user
254

255 256
      @project_2.team << [@user, :master]
      @project_3.team << [@user, :developer]
257 258
    end

259 260 261 262 263 264 265 266 267
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
268 269 270 271 272
  end

  describe 'groups' do
    before do
      @user = create :user
273 274
      @group = create :group
      @group.add_owner(@user)
275 276
    end

277 278 279
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
280
    it { expect(@user.namespaces).to match_array([@user.namespace, @group]) }
281 282
  end

283 284 285 286
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
287 288
      @group = create :group
      @group.add_owner(@user)
289

290
      @group.add_user(@user2, GroupMember::OWNER)
291 292
    end

293
    it { expect(@user2.several_namespaces?).to be_truthy }
294 295
  end

296 297 298 299 300 301
  describe 'namespaced' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
    end

302
    it { expect(@user.several_namespaces?).to be_falsey }
303
    it { expect(@user.namespaces).to eq([@user.namespace]) }
304 305 306 307 308 309 310
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

    it "should block user" do
      user.block
311
      expect(user.blocked?).to be_truthy
312 313 314
    end
  end

315 316 317 318 319 320 321
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
      expect(User).to receive(:active).and_return([user])

      expect(User.filter(nil)).to include user
322 323
    end

324 325 326 327
    it 'filters by admins' do
      expect(User).to receive(:admins).and_return([user])

      expect(User.filter('admins')).to include user
328 329
    end

330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
    it 'filters by blocked' do
      expect(User).to receive(:blocked).and_return([user])

      expect(User.filter('blocked')).to include user
    end

    it 'filters by two_factor_disabled' do
      expect(User).to receive(:without_two_factor).and_return([user])

      expect(User.filter('two_factor_disabled')).to include user
    end

    it 'filters by two_factor_enabled' do
      expect(User).to receive(:with_two_factor).and_return([user])

      expect(User.filter('two_factor_enabled')).to include user
    end

    it 'filters by wop' do
      expect(User).to receive(:without_projects).and_return([user])

      expect(User.filter('wop')).to include user
    end
353 354 355 356
  end

  describe :not_in_project do
    before do
357
      User.delete_all
358 359 360 361
      @user = create :user
      @project = create :project
    end

362
    it { expect(User.not_in_project(@project)).to include(@user, @project.owner) }
363
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
364

365 366 367
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
368

369 370 371 372 373
      it { expect(user.is_admin?).to be_falsey }
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
374
    end
375

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
376
    describe 'with defaults' do
377
      let(:user) { User.new }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
378

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
379
      it "should apply defaults to user" do
380 381 382
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
383 384 385
      end
    end

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
386
    describe 'with default overrides' do
387
      let(:user) { User.new(projects_limit: 123, can_create_group: false, can_create_team: true, theme_id: 1) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
388

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
389
      it "should apply defaults to user" do
390 391
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
392
        expect(user.theme_id).to eq(1)
393
      end
394 395
    end
  end
396

397
  describe '.find_by_any_email' do
398 399 400
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

401
      expect(User.find_by_any_email(user.email)).to eq user
402 403 404 405 406 407
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

408
      expect(User.find_by_any_email(email.email)).to eq user
409 410 411
    end

    it 'returns nil when nothing found' do
412
      expect(User.find_by_any_email('')).to be_nil
413 414 415
    end
  end

416 417 418 419 420
  describe 'search' do
    let(:user1) { create(:user, username: 'James', email: 'james@testing.com') }
    let(:user2) { create(:user, username: 'jameson', email: 'jameson@example.com') }

    it "should be case insensitive" do
421 422 423 424 425 426
      expect(User.search(user1.username.upcase).to_a).to eq([user1])
      expect(User.search(user1.username.downcase).to_a).to eq([user1])
      expect(User.search(user2.username.upcase).to_a).to eq([user2])
      expect(User.search(user2.username.downcase).to_a).to eq([user2])
      expect(User.search(user1.username.downcase).to_a.count).to eq(2)
      expect(User.search(user2.username.downcase).to_a.count).to eq(1)
427 428 429
    end
  end

430
  describe 'by_username_or_id' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
431 432
    let(:user1) { create(:user, username: 'foo') }

433
    it "should get the correct user" do
434 435 436 437
      expect(User.by_username_or_id(user1.id)).to eq(user1)
      expect(User.by_username_or_id('foo')).to eq(user1)
      expect(User.by_username_or_id(-1)).to be_nil
      expect(User.by_username_or_id('bar')).to be_nil
438 439
    end
  end
440

441 442 443 444 445 446 447 448 449 450 451 452 453 454
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

    it 'should get the correct user' do
      expect(User.by_login(user.email.upcase)).to eq user
      expect(User.by_login(user.email)).to eq user
      expect(User.by_login(username.downcase)).to eq user
      expect(User.by_login(username)).to eq user
      expect(User.by_login(nil)).to be_nil
      expect(User.by_login('')).to be_nil
    end
  end

455 456 457 458 459 460 461 462 463 464 465 466
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
      expect { described_class.find_by_username!('JohnDoe') }.
        to raise_error(ActiveRecord::RecordNotFound)
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

467
  describe 'all_ssh_keys' do
468
    it { is_expected.to have_many(:keys).dependent(:destroy) }
469 470 471 472 473

    it "should have all ssh keys" do
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

474
      expect(user.all_ssh_keys).to include(key.key)
475
    end
476
  end
477

478 479 480 481 482
  describe :avatar_type do
    let(:user) { create(:user) }

    it "should be true if avatar is image" do
      user.update_attribute(:avatar, 'uploads/avatar.png')
483
      expect(user.avatar_type).to be_truthy
484 485 486 487
    end

    it "should be false if avatar is html page" do
      user.update_attribute(:avatar, 'uploads/avatar.html')
488
      expect(user.avatar_type).to eq(["only images allowed"])
489 490
    end
  end
Jerome Dalbert's avatar
Jerome Dalbert committed
491

492 493 494
  describe :requires_ldap_check? do
    let(:user) { User.new }

495 496
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
497
      allow(user).to receive(:ldap_user?).and_return(true)
498
      user.last_credential_check_at = nil
499
      expect(user.requires_ldap_check?).to be_falsey
500 501
    end

502
    context 'when LDAP is enabled' do
503 504 505
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
506

507
      it 'is false for non-LDAP users' do
508
        allow(user).to receive(:ldap_user?).and_return(false)
509
        expect(user.requires_ldap_check?).to be_falsey
510 511
      end

512
      context 'and when the user is an LDAP user' do
513 514 515
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
516 517 518

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
519
          expect(user.requires_ldap_check?).to be_truthy
520 521 522 523
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
524
          expect(user.requires_ldap_check?).to be_truthy
525
        end
526 527 528 529
      end
    end
  end

530 531
  describe :ldap_user? do
    it "is true if provider name starts with ldap" do
532
      user = create(:omniauth_user, provider: 'ldapmain')
533
      expect( user.ldap_user? ).to be_truthy
534 535 536
    end

    it "is false for other providers" do
537
      user = create(:omniauth_user, provider: 'other-provider')
538
      expect( user.ldap_user? ).to be_falsey
539 540 541
    end

    it "is false if no extern_uid is provided" do
542
      user = create(:omniauth_user, extern_uid: nil)
543
      expect( user.ldap_user? ).to be_falsey
544 545 546
    end
  end

547 548 549
  describe :ldap_identity do
    it "returns ldap identity" do
      user = create :omniauth_user
550
      expect(user.ldap_identity.provider).not_to be_empty
551 552 553
    end
  end

Jerome Dalbert's avatar
Jerome Dalbert committed
554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
593

Jerome Dalbert's avatar
Jerome Dalbert committed
594 595
      expect(user.short_website_url).to eq 'test.com'
    end
596
  end
Ciro Santilli's avatar
Ciro Santilli committed
597

598 599 600 601 602 603
  describe "#starred?" do
    it "determines if user starred a project" do
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

604 605
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
606 607

      star1 = UsersStarProject.create!(project: project1, user: user)
608 609
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
610 611

      star2 = UsersStarProject.create!(project: project2, user: user)
612 613
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
614 615

      star1.destroy
616 617
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
618 619

      star2.destroy
620 621
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
622 623 624
    end
  end

Ciro Santilli's avatar
Ciro Santilli committed
625 626 627 628 629
  describe "#toggle_star" do
    it "toggles stars" do
      user = create :user
      project = create :project, :public

630
      expect(user.starred?(project)).to be_falsey
Ciro Santilli's avatar
Ciro Santilli committed
631
      user.toggle_star(project)
632
      expect(user.starred?(project)).to be_truthy
Ciro Santilli's avatar
Ciro Santilli committed
633
      user.toggle_star(project)
634
      expect(user.starred?(project)).to be_falsey
Ciro Santilli's avatar
Ciro Santilli committed
635 636
    end
  end
Valery Sizov's avatar
Valery Sizov committed
637 638 639 640 641 642 643

  describe "#sort" do
    before do
      User.delete_all
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
    end
644

Valery Sizov's avatar
Valery Sizov committed
645
    it "sorts users as recently_signed_in" do
646
      expect(User.sort('recent_sign_in').first).to eq(@user)
Valery Sizov's avatar
Valery Sizov committed
647 648 649
    end

    it "sorts users as late_signed_in" do
650
      expect(User.sort('oldest_sign_in').first).to eq(@user1)
Valery Sizov's avatar
Valery Sizov committed
651 652 653
    end

    it "sorts users as recently_created" do
654
      expect(User.sort('created_desc').first).to eq(@user)
Valery Sizov's avatar
Valery Sizov committed
655 656 657
    end

    it "sorts users as late_created" do
658
      expect(User.sort('created_asc').first).to eq(@user1)
Valery Sizov's avatar
Valery Sizov committed
659 660 661
    end

    it "sorts users by name when nil is passed" do
662
      expect(User.sort(nil).first).to eq(@user)
Valery Sizov's avatar
Valery Sizov committed
663 664
    end
  end
665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691

  describe "#contributed_projects_ids" do
    subject { create(:user) }
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project3) }
    let!(:project3) { create(:project) }
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
    let!(:push_event) { create(:event, action: Event::PUSHED, project: project1, target: project1, author: subject) }
    let!(:merge_event) { create(:event, action: Event::CREATED, project: project3, target: merge_request, author: subject) }

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
      expect(subject.contributed_projects_ids).to include(project1.id)
    end

    it "includes IDs for projects the user has had merge requests merged into" do
      expect(subject.contributed_projects_ids).to include(project3.id)
    end

    it "doesn't include IDs for unrelated projects" do
      expect(subject.contributed_projects_ids).not_to include(project2.id)
    end
  end
692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708

  describe :can_be_removed? do
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737

  describe "#recent_push" do
    subject { create(:user) }
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project1) }
    let!(:push_data) { Gitlab::PushDataBuilder.build_sample(project2, subject) }
    let!(:push_event) { create(:event, action: Event::PUSHED, project: project2, target: project1, author: subject, data: push_data) }

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes push event" do
      expect(subject.recent_push).to eq(push_event)
    end

    it "excludes push event if branch has been deleted" do
      allow_any_instance_of(Repository).to receive(:branch_names).and_return(['foo'])

      expect(subject.recent_push).to eq(nil)
    end

    it "excludes push event if MR is opened for it" do
      create(:merge_request, source_project: project2, target_project: project1, source_branch: project2.default_branch, target_branch: 'fix', author: subject)

      expect(subject.recent_push).to eq(nil)
    end
  end
gitlabhq's avatar
gitlabhq committed
738
end