Commit 16995b8c authored by Phil Hughes's avatar Phil Hughes

Fixed web IDE review & commit editors getting into incorrect state

Closes #46392
parent 2f7e0aba
...@@ -43,9 +43,13 @@ export default { ...@@ -43,9 +43,13 @@ export default {
}, },
}, },
watch: { watch: {
file(oldVal, newVal) { file(newVal, oldVal) {
if (oldVal.pending) {
this.removePendingTab(oldVal);
}
// Compare key to allow for files opened in review mode to be cached differently // Compare key to allow for files opened in review mode to be cached differently
if (newVal.key !== this.file.key) { if (oldVal.key !== this.file.key) {
this.initMonaco(); this.initMonaco();
if (this.currentActivityView !== activityBarViews.edit) { if (this.currentActivityView !== activityBarViews.edit) {
...@@ -99,6 +103,7 @@ export default { ...@@ -99,6 +103,7 @@ export default {
'setFileViewMode', 'setFileViewMode',
'setFileEOL', 'setFileEOL',
'updateViewer', 'updateViewer',
'removePendingTab',
]), ]),
initMonaco() { initMonaco() {
if (this.shouldHideEditor) return; if (this.shouldHideEditor) return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment