Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
251255e7
Commit
251255e7
authored
Apr 04, 2017
by
Felipe Artur
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not set closed_at to nil when issue is reopened
parent
0a4b853f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
12 deletions
+4
-12
app/models/issue.rb
app/models/issue.rb
+0
-4
changelogs/unreleased/issue_91_ee_backport.yml
changelogs/unreleased/issue_91_ee_backport.yml
+4
-0
spec/models/issue_spec.rb
spec/models/issue_spec.rb
+0
-8
No files found.
app/models/issue.rb
View file @
251255e7
...
@@ -59,10 +59,6 @@ class Issue < ActiveRecord::Base
...
@@ -59,10 +59,6 @@ class Issue < ActiveRecord::Base
before_transition
any
=>
:closed
do
|
issue
|
before_transition
any
=>
:closed
do
|
issue
|
issue
.
closed_at
=
Time
.
zone
.
now
issue
.
closed_at
=
Time
.
zone
.
now
end
end
before_transition
closed:
any
do
|
issue
|
issue
.
closed_at
=
nil
end
end
end
def
hook_attrs
def
hook_attrs
...
...
changelogs/unreleased/issue_91_ee_backport.yml
0 → 100644
View file @
251255e7
---
title
:
Do not set closed_at to nil when issue is reopened
merge_request
:
author
:
spec/models/issue_spec.rb
View file @
251255e7
...
@@ -51,14 +51,6 @@ describe Issue, models: true do
...
@@ -51,14 +51,6 @@ describe Issue, models: true do
expect
(
issue
.
closed_at
).
to
eq
(
now
)
expect
(
issue
.
closed_at
).
to
eq
(
now
)
end
end
it
'sets closed_at to nil when issue is reopened'
do
issue
=
create
(
:issue
,
state:
'closed'
)
issue
.
reopen
expect
(
issue
.
closed_at
).
to
be_nil
end
end
end
describe
'#to_reference'
do
describe
'#to_reference'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment