Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
408e010d
Commit
408e010d
authored
Feb 20, 2016
by
Douglas Barbosa Alexandre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename IssuableBaseService#have_changes? to has_changes?
parent
a7dee0ab
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
app/services/issuable_base_service.rb
app/services/issuable_base_service.rb
+1
-1
app/services/issues/update_service.rb
app/services/issues/update_service.rb
+1
-1
app/services/merge_requests/update_service.rb
app/services/merge_requests/update_service.rb
+1
-1
No files found.
app/services/issuable_base_service.rb
View file @
408e010d
...
@@ -71,7 +71,7 @@ class IssuableBaseService < BaseService
...
@@ -71,7 +71,7 @@ class IssuableBaseService < BaseService
end
end
end
end
def
ha
ve
_changes?
(
issuable
,
options
=
{})
def
ha
s
_changes?
(
issuable
,
options
=
{})
valid_attrs
=
[
:title
,
:description
,
:assignee_id
,
:milestone_id
,
:target_branch
]
valid_attrs
=
[
:title
,
:description
,
:assignee_id
,
:milestone_id
,
:target_branch
]
attrs_changed
=
valid_attrs
.
any?
do
|
attr
|
attrs_changed
=
valid_attrs
.
any?
do
|
attr
|
...
...
app/services/issues/update_service.rb
View file @
408e010d
...
@@ -5,7 +5,7 @@ module Issues
...
@@ -5,7 +5,7 @@ module Issues
end
end
def
handle_changes
(
issue
,
options
=
{})
def
handle_changes
(
issue
,
options
=
{})
if
ha
ve
_changes?
(
issue
,
options
)
if
ha
s
_changes?
(
issue
,
options
)
task_service
.
mark_pending_tasks_as_done
(
issue
,
current_user
)
task_service
.
mark_pending_tasks_as_done
(
issue
,
current_user
)
end
end
...
...
app/services/merge_requests/update_service.rb
View file @
408e010d
...
@@ -15,7 +15,7 @@ module MergeRequests
...
@@ -15,7 +15,7 @@ module MergeRequests
end
end
def
handle_changes
(
merge_request
,
options
=
{})
def
handle_changes
(
merge_request
,
options
=
{})
if
ha
ve
_changes?
(
merge_request
,
options
)
if
ha
s
_changes?
(
merge_request
,
options
)
task_service
.
mark_pending_tasks_as_done
(
merge_request
,
current_user
)
task_service
.
mark_pending_tasks_as_done
(
merge_request
,
current_user
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment