Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
4c86b4e2
Commit
4c86b4e2
authored
Apr 17, 2018
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Properly fill variable pair to the last fields
parent
8d4ad0c7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
9 deletions
+9
-9
qa/qa/factory/resource/secret_variable.rb
qa/qa/factory/resource/secret_variable.rb
+1
-2
qa/qa/page/project/settings/secret_variables.rb
qa/qa/page/project/settings/secret_variables.rb
+5
-6
qa/qa/specs/features/project/deploy_key_clone_spec.rb
qa/qa/specs/features/project/deploy_key_clone_spec.rb
+3
-1
No files found.
qa/qa/factory/resource/secret_variable.rb
View file @
4c86b4e2
...
...
@@ -16,8 +16,7 @@ module QA
Page
::
Project
::
Settings
::
CICD
.
perform
do
|
setting
|
setting
.
expand_secret_variables
do
|
page
|
page
.
fill_variable_key
(
key
)
page
.
fill_variable_value
(
value
)
page
.
fill_variable
(
key
,
value
)
page
.
save_variables
end
...
...
qa/qa/page/project/settings/secret_variables.rb
View file @
4c86b4e2
...
...
@@ -18,12 +18,11 @@ module QA
element
:reveal_values
,
'.js-secret-value-reveal-button'
end
def
fill_variable_key
(
key
)
fill_in
(
'Input variable key'
,
with:
key
,
match: :first
)
end
def
fill_variable_value
(
value
)
fill_in
(
'Input variable value'
,
with:
value
,
match: :first
)
def
fill_variable
(
key
,
value
)
all
(
'.js-ci-variable-input-key'
)[
-
1
].
set
(
key
)
# After we fill the key, JS would generate another field so
# we need to fill the one before last one instead of last one
all
(
'.js-ci-variable-input-value'
)[
-
2
].
set
(
value
)
end
def
save_variables
...
...
qa/qa/specs/features/project/deploy_key_clone_spec.rb
View file @
4c86b4e2
...
...
@@ -65,7 +65,9 @@ module QA
- ssh-add -D
- echo "$
#{
deploy_key_name
}
" | ssh-add -
- git clone
#{
@repository_uri
.
git_uri
}
- sha1sum
#{
@project
.
name
}
/.gitlab-ci.yml
- cd
#{
@project
.
name
}
- git checkout
#{
deploy_key_name
}
- sha1sum .gitlab-ci.yml
tags:
- qa
- docker
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment